Skip to content

Conversation

@filintod
Copy link
Contributor

@filintod filintod commented Aug 6, 2025

Description

Please explain the changes you've made

Issue reference

We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.

#1157

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

@filintod filintod changed the title Conversation update for Dapr 116 update for Dapr 1.16 conversation SDK quickstart Aug 6, 2025
@alicejgibbons
Copy link
Contributor

@filintod not sure we want to put this example in quickstarts otherwise it runs as a test and we dont have an API key to use? we could talk about putting it in https://github.com/dapr/quickstarts/tree/master/tutorials ?

@filintod
Copy link
Contributor Author

@alicejgibbons make sense, some updates are still ok and use the echo provider, I guess we can move the API-dependant parts to the tutorial. I have created a lengthier example one in python-sdk that I could bring to the tutorial instead, like a multi-turn example that is more interesting.

@alicejgibbons
Copy link
Contributor

@filintod here's what i would propose:

@filintod
Copy link
Contributor Author

@alicejgibbons I removed the openai/ollama references and I'll add to tutorials after this is done, and also the Python SDK PR is done (required for this one).

@filintod filintod changed the title update for Dapr 1.16 conversation SDK quickstart update for Dapr 1.16 conversation SDK Python quickstart Aug 18, 2025
@filintod filintod force-pushed the filinto/conversation-sdk-116 branch from 5fbf8fc to 2e19dde Compare September 9, 2025 14:58
@filintod filintod marked this pull request as ready for review September 9, 2025 14:59
@filintod filintod requested review from a team as code owners September 9, 2025 14:59
@filintod
Copy link
Contributor Author

filintod commented Sep 9, 2025

@alicejgibbons if you can take another look

Copy link
Contributor

@alicejgibbons alicejgibbons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Filinto just a couple of things

@filintod
Copy link
Contributor Author

@alicejgibbons all feedback changes are in, ptal

Copy link
Contributor

@alicejgibbons alicejgibbons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks @filintod

@alicejgibbons alicejgibbons merged commit 207a558 into dapr:release-1.16 Sep 15, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants