-
Notifications
You must be signed in to change notification settings - Fork 548
update for Dapr 1.16 conversation SDK Python quickstart #1215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update for Dapr 1.16 conversation SDK Python quickstart #1215
Conversation
Signed-off-by: Filinto Duran <[email protected]>
|
@filintod not sure we want to put this example in quickstarts otherwise it runs as a test and we dont have an API key to use? we could talk about putting it in https://github.com/dapr/quickstarts/tree/master/tutorials ? |
|
@alicejgibbons make sense, some updates are still ok and use the echo provider, I guess we can move the API-dependant parts to the tutorial. I have created a lengthier example one in python-sdk that I could bring to the tutorial instead, like a multi-turn example that is more interesting. |
|
@filintod here's what i would propose:
|
Signed-off-by: Filinto Duran <[email protected]>
Signed-off-by: Filinto Duran <[email protected]>
|
@alicejgibbons I removed the openai/ollama references and I'll add to tutorials after this is done, and also the Python SDK PR is done (required for this one). |
5fbf8fc to
2e19dde
Compare
|
@alicejgibbons if you can take another look |
alicejgibbons
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Filinto just a couple of things
Signed-off-by: Filinto Duran <[email protected]>
|
@alicejgibbons all feedback changes are in, ptal |
Signed-off-by: Filinto Duran <[email protected]>
alicejgibbons
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks @filintod
Description
Please explain the changes you've made
Issue reference
We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.
#1157
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: