Misleading comment in the Invoke example

[NickLarsenNZ]

Looks like it was copy/pasted from the pubsub example.

Topic A Is not returned here, only the default (which is an empty list, given Vec is Default over T):

rust-sdk/examples/invoke/grpc/server.rs

Lines 55 to 66 in b69e1f8

	/// Lists all topics subscribed by this app.
	///
	/// NOTE: Dapr runtime will call this method to get
	/// the list of topics the app wants to subscribe to.
	/// In this example, the app is subscribing to topic `A`.
	async fn list_topic_subscriptions(
	&self,
	_request: Request<()>,
	) -> Result<Response<ListTopicSubscriptionsResponse>, Status> {
	let list_subscriptions = ListTopicSubscriptionsResponse::default();
	Ok(Response::new(list_subscriptions))
	}

Perhaps it should read something like:

/// Return an empty list of topics. 

... but on that note, should the trait methods provide these default behaviours so we don't have to implement defaults for each unused method?

[NickLarsenNZ]

should the trait methods provide these default behaviours so we don't have to implement defaults for each unused method?

I'm not sure it is easily possible, since the trait is generated from proto files.
I'm unaware of a way to provide default implementations for trait methods generated this way.

rust-sdk/src/dapr.rs

Line 10 in ef8ca51

tonic::include_proto!("dapr.proto.runtime.v1");

---

Update: I've asked the question over here: tokio-rs/prost#844

[github-actions]

This issue has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted) or other activity occurs. Thank you for your contributions.

[github-actions]

This issue has been automatically closed because it has not had activity in the last 67 days. If this issue is still valid, please ping a maintainer and ask them to label it as pinned, good first issue or help wanted. Thank you for your contributions.