Skip to content

Commit 31f9413

Browse files
committed
added icon and fixed minimize console bug
1 parent 196a91c commit 31f9413

File tree

7 files changed

+17
-28
lines changed

7 files changed

+17
-28
lines changed

.github/workflows/releases.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ jobs:
3232
run: uv pip install pyinstaller
3333

3434
- name: Build executable
35-
run: uv run pyinstaller --onefile --noconsole --name "TestEditor" --add-data "resources;resources" main.py
35+
run: uv run pyinstaller --onefile --noconsole --name "Test Editor" --icon="resources/testeditor_logo.ico" --add-data "resources;resources" main.py
3636

3737
- name: Create Release
3838
uses: softprops/action-gh-release@v1

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ If a pre-made .exe is not available, you can build it yourself using the instruc
6666
git clone https://github.com/darginmathi/Test-Editor
6767
cd Test-Editor
6868
uv sync
69-
uv run pyinstaller --onefile --noconsole --name "Test Editor" --add-data "resources;resources" main.py
69+
uv run pyinstaller --onefile --noconsole --name "Test Editor" --icon="resources/testeditor_logo.ico" --add-data "resources;resources" main.py
7070
```
7171

7272
**Find Your Application:**

pyproject.toml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,10 @@ dependencies = [
88
"openpyxl>=3.1.5",
99
"pandas>=2.3.3",
1010
"pyqt6-qt6>=6.10.0",
11-
"qtwidgets>=1.1",
12-
"ruff>=0.13.2",
1311
"pyqt6-webengine>=6.10.0",
1412
]
13+
14+
[project.optional-dependencies]
15+
dev = [
16+
"ruff>=0.13.2",
17+
]

resources/testeditor_logo.ico

97.3 KB
Binary file not shown.

ui/output_dock.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88

99
class OutputDock(QDockWidget):
1010
clear_requested = pyqtSignal()
11+
toggle_visibility_requested = pyqtSignal()
1112

1213
def __init__(self, parent=None):
1314
super().__init__("OUTPUT", parent)
@@ -84,7 +85,7 @@ def __init__(self, parent=None):
8485
self.minimize_button.setToolTip("Minimize (Ctrl+`)")
8586

8687
self.setTitleBarWidget(title_bar)
87-
self.minimize_button.clicked.connect(self.hide)
88+
self.minimize_button.clicked.connect(self.toggle_visibility_requested.emit)
8889
self.maximize_button.clicked.connect(self.toggle_maximize)
8990
self.refresh_button.clicked.connect(self.refresh_current_view)
9091

ui/window.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ def __init__(self):
5252
self.output_dock = OutputDock(self)
5353
# self.output_dock.setFixedHeight(int(self.height() * 0.3))
5454
self.addDockWidget(Qt.DockWidgetArea.BottomDockWidgetArea, self.output_dock)
55+
self.output_dock.toggle_visibility_requested.connect(self.toggle_console)
5556
self.output_dock.open_log_button.clicked.connect(self._on_open_log_manually)
5657
self.output_dock.hide() # Ensure it's hidden by default
5758

@@ -265,7 +266,7 @@ def setup_status_bar(self):
265266
self.show_output_button = QPushButton("/\\")
266267
self.show_output_button.setObjectName("StatusBarButton")
267268
self.show_output_button.setToolTip("Console (Ctrl+`)")
268-
self.show_output_button.clicked.connect(self.output_dock.show)
269+
self.show_output_button.clicked.connect(self.toggle_console)
269270
self.status_bar.addPermanentWidget(self.show_output_button)
270271

271272
separator_output = QLabel("|")
@@ -592,7 +593,6 @@ def setup_run_toolbar(self):
592593
self.output_dock.clear_requested.connect(self.clear_output)
593594

594595
def toggle_console(self):
595-
print("toggle_console called")
596596
if self.output_dock.isVisible():
597597
self.output_dock.hide()
598598
self.centralWidget().show()

uv.lock

Lines changed: 6 additions & 21 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)