InstallationStatusUpdater: Add option to configure whether notifications should be shown after automatic scans

Author: darklinkpower

source/Generic/InstallationStatusUpdater/Application/GamesInstallationStatusScanner.cs

@@ -65,10 +65,7 @@ public StatusUpdateResults DetectInstallationStatus(bool showResultsDialog, Canc
 
         public StatusUpdateResults DetectInstallationStatusInternal(CancellationToken cancelToken)
         {
-            int markedInstalled = 0;
-            int markedUninstalled = 0;
             var updateResults = new StatusUpdateResults();
-
             using (_playniteApi.Database.BufferedUpdate())
             {
                 foreach (var game in _playniteApi.Database.Games)
@@ -85,14 +82,12 @@ public StatusUpdateResults DetectInstallationStatusInternal(CancellationToken ca
                         {
                             game.IsInstalled = false;
                             _playniteApi.Database.Games.Update(game);
-                            markedUninstalled++;
                             updateResults.AddUninstalled(game);
                         }
                         else if (!game.IsInstalled && detectedStatus == InstallationDetectionResult.Installed)
                         {
                             game.IsInstalled = true;
                             _playniteApi.Database.Games.Update(game);
-                            markedInstalled++;
                             updateResults.AddInstalled(game);
                         }
                     }
@@ -112,7 +107,8 @@ private void OpenWindowOrAddResultsNotification(bool showResultsDialog, StatusUp
             {
                 OpenResultsWindow(statusUpdateResults);
             }
-            else if (statusUpdateResults.Installed.Count > 0 || statusUpdateResults.Uninstalled.Count > 0)
+            else if (_settings.Settings.ShowNotificationOnAutomaticScans &&
+                (statusUpdateResults.Installed.Count > 0 || statusUpdateResults.Uninstalled.Count > 0))
             {
                 var notificationMessage = new NotificationMessage(
                     Guid.NewGuid().ToString(),

source/Generic/InstallationStatusUpdater/InstallationStatusUpdaterSettings.cs

@@ -22,6 +22,7 @@ public class InstallationStatusUpdaterSettings : ObservableObject
         public bool UpdateStatusOnUsbChanges { get; set; } = true;
         public bool UpdateStatusOnDirChanges { get; set; } = false;
         public bool DetectFilesFromLaunchArguments { get; set; } = true;
+        public bool ShowNotificationOnAutomaticScans { get; set; } = true;
 
         private List<WatchedDirectory> _detectionDirectories = new List<WatchedDirectory>();
         public List<WatchedDirectory> DetectionDirectories

source/Generic/InstallationStatusUpdater/Localization/en_US.xaml

@@ -19,6 +19,7 @@ Previously uninstalled games were set as installed: {1}</sys:String>
     <sys:String x:Key="LOCInstallation_Status_Updater_StatusUpdaterSettingScanLibraryGamesWithAction">Scan games from library plugins using their installation directory</sys:String>
     <sys:String x:Key="LOCInstallation_Status_Updater_StatusUpdaterSettingOnlyUsePlayActionGameActions">Only use Actions marked as "Play Action" for detection</sys:String>
     <sys:String x:Key="LOCInstallation_Status_Updater_StatusUpdaterSettingUpdateOnStartup">Update installation status on startup</sys:String>
+    <sys:String x:Key="LOCInstallation_Status_Updater_StatusUpdaterSettingShowAutoScanNotifications">Show a notification containing results after automatic installation scans</sys:String>
     <sys:String x:Key="LOCInstallation_Status_Updater_StatusUpdaterSettingUpdateOnLibraryUpdate">Update installation status on library update</sys:String>
     <sys:String x:Key="LOCInstallation_Status_Updater_StatusUpdaterSettingUpdateLocTagsOnLibUpdate">Update tag with drive the game is installed on library update</sys:String>
 

source/Generic/InstallationStatusUpdater/Presentation/InstallationStatusUpdaterSettingsView.xaml

@@ -26,7 +26,8 @@
             <CheckBox Margin="0,10,0,0" IsChecked="{Binding Settings.UseOnlyFirstRomDetection}" Content="{DynamicResource LOCInstallation_Status_Updater_StatusUpdaterSettingUseOnlyFirstRomDetection}" />
 
             <TextBlock Text="{DynamicResource LOCInstallation_Status_Updater_StatusUpdaterSectionAutoScanTriggers}" FontWeight="SemiBold" Margin="0,30,0,0" />
-            <CheckBox Margin="0,10,0,0" IsChecked="{Binding Settings.UpdateOnStartup}" Content="{DynamicResource LOCInstallation_Status_Updater_StatusUpdaterSettingUpdateOnStartup}" />
+            <CheckBox Margin="0,10,0,0" IsChecked="{Binding Settings.ShowNotificationOnAutomaticScans}" Content="{DynamicResource LOCInstallation_Status_Updater_StatusUpdaterSettingShowAutoScanNotifications}" />
+            <CheckBox Margin="0,20,0,0" IsChecked="{Binding Settings.UpdateOnStartup}" Content="{DynamicResource LOCInstallation_Status_Updater_StatusUpdaterSettingUpdateOnStartup}" />
             <CheckBox Margin="0,10,0,0" IsChecked="{Binding Settings.UpdateOnLibraryUpdate}" Content="{DynamicResource LOCInstallation_Status_Updater_StatusUpdaterSettingUpdateOnLibraryUpdate}" />
             <CheckBox Margin="0,10,0,0" IsChecked="{Binding Settings.UpdateStatusOnUsbChanges}" Content="{DynamicResource LOCInstallation_Status_Updater_StatusUpdaterSettingUpdateStatusOnUsbChanges}" />