Highlights reconstruction uses exif tag LinearResponseLimit

jenshannoschwalm · jenshannoschwalm · commit 997e5d1b2f20 · 2024-10-21T17:06:09.000+02:00
It's better to set the clip level to what we got via exif LinearResponseLimit instead
of defaulting to 1.0 in `reload_defaults()`

Otherwise code style maintenance
- removed struct in function headers
- use 'd' for 'data'
- missed a case using a magic float instead of value from highlights_clip_magics
- avoid overcast
diff --git a/src/common/exif.cc b/src/common/exif.cc
@@ -863,6 +863,8 @@ static void _check_linear_response_limit(Exiv2::ExifData &exifData,
 {
   bool found_one = false;
 
+  // currently this only reads the dng tag, could also be used for other raws
+
   Exiv2::ExifData::const_iterator linr =
     exifData.findKey(Exiv2::ExifKey("Exif.Image.LinearResponseLimit"));
   if(linr != exifData.end() && linr->count() == 1)
@@ -871,7 +873,6 @@ static void _check_linear_response_limit(Exiv2::ExifData &exifData,
     found_one = true;
   }
 
-  // currently this only reads the dng tag, could also be used for other raws
   if(found_one)
     dt_print(DT_DEBUG_IMAGEIO, "[exif] `%s` has LinearResponseLimit %.4f",
       img->filename, img->linear_response_limit);
diff --git a/src/iop/highlights.c b/src/iop/highlights.c
@@ -385,11 +385,11 @@ void modify_roi_in(dt_iop_module_t *self,
   roi_in->scale = 1.0f;
 }
 
-void tiling_callback(struct dt_iop_module_t *self,
-                     struct dt_dev_pixelpipe_iop_t *piece,
+void tiling_callback(dt_iop_module_t *self,
+                     dt_dev_pixelpipe_iop_t *piece,
                      const dt_iop_roi_t *roi_in,
                      const dt_iop_roi_t *roi_out,
-                     struct dt_develop_tiling_t *tiling)
+                     dt_develop_tiling_t *tiling)
 {
   dt_iop_highlights_data_t *d = piece->data;
   const uint32_t filters = piece->pipe->dsc.filters;
@@ -407,8 +407,7 @@ void tiling_callback(struct dt_iop_module_t *self,
   tiling->overhead = 0;
   tiling->overlap = 0;
 
-  dt_develop_blend_params_t *const bldata =
-    (dt_develop_blend_params_t *const)piece->blendop_data;
+  dt_develop_blend_params_t *const bldata = piece->blendop_data;
   if(bldata
     && (piece->pipe->store_all_raster_masks || dt_iop_is_raster_mask_used(self, BLEND_RASTER_ID)))
   {
@@ -464,7 +463,7 @@ void tiling_callback(struct dt_iop_module_t *self,
 }
 
 #ifdef HAVE_OPENCL
-int process_cl(struct dt_iop_module_t *self,
+int process_cl(dt_iop_module_t *self,
                dt_dev_pixelpipe_iop_t *piece,
                cl_mem dev_in,
                cl_mem dev_out,
@@ -673,15 +672,15 @@ static void process_visualize(dt_dev_pixelpipe_iop_t *piece,
                               void *const ovoid,
                               const dt_iop_roi_t *const roi_in,
                               const dt_iop_roi_t *const roi_out,
-                              dt_iop_highlights_data_t *data)
+                              dt_iop_highlights_data_t *d)
 {
   const uint8_t(*const xtrans)[6] = (const uint8_t(*const)[6])piece->pipe->dsc.xtrans;
   const uint32_t filters = piece->pipe->dsc.filters;
   const gboolean is_xtrans = (filters == 9u);
   const float *const in = (const float *const)ivoid;
   float *const out = (float *const)ovoid;
 
-  const float mclip = data->clip * highlights_clip_magics[data->mode];
+  const float mclip = d->clip * highlights_clip_magics[d->mode];
   const float *cf = piece->pipe->dsc.temperature.coeffs;
   const float clips[4] = { mclip * (cf[RED]   <= 0.0f ? 1.0f : cf[RED]),
                            mclip * (cf[GREEN] <= 0.0f ? 1.0f : cf[GREEN]),
@@ -724,27 +723,28 @@ static void process_visualize(dt_dev_pixelpipe_iop_t *piece,
   }
 }
 
-void process(struct dt_iop_module_t *self,
+void process(dt_iop_module_t *self,
              dt_dev_pixelpipe_iop_t *piece,
              const void *const ivoid,
              void *const ovoid,
              const dt_iop_roi_t *const roi_in,
              const dt_iop_roi_t *const roi_out)
 {
   const uint32_t filters = piece->pipe->dsc.filters;
-  dt_iop_highlights_data_t *data = piece->data;
+  dt_iop_highlights_data_t *d = piece->data;
   dt_iop_highlights_gui_data_t *g = self->gui_data;
 
   const gboolean fullpipe = piece->pipe->type & DT_DEV_PIXELPIPE_FULL;
   const gboolean fastmode = piece->pipe->type & DT_DEV_PIXELPIPE_FAST;
+
   if(g && fullpipe)
   {
     if(g->hlr_mask_mode != DT_HIGHLIGHTS_MASK_OFF)
     {
       piece->pipe->mask_display = DT_DEV_PIXELPIPE_DISPLAY_PASSTHRU;
       if(g->hlr_mask_mode == DT_HIGHLIGHTS_MASK_CLIPPED)
       {
-        process_visualize(piece, ivoid, ovoid, roi_in, roi_out, data);
+        process_visualize(piece, ivoid, ovoid, roi_in, roi_out, d);
         return;
       }
     }
@@ -760,11 +760,11 @@ void process(struct dt_iop_module_t *self,
     high_quality = (level >= min_s);
   }
 
-  const float clip = data->clip * dt_iop_get_processed_minimum(piece);
+  const float clip = d->clip * dt_iop_get_processed_minimum(piece);
 
   if(filters == 0)
   {
-    if(data->mode == DT_IOP_HIGHLIGHTS_CLIP)
+    if(d->mode == DT_IOP_HIGHLIGHTS_CLIP)
     {
       process_clip(self, piece, ivoid, ovoid, roi_in, roi_out, clip);
       const float m = dt_iop_get_processed_minimum(piece);
@@ -778,13 +778,13 @@ void process(struct dt_iop_module_t *self,
     return;
   }
 
-  const dt_iop_highlights_mode_t dmode = fastmode && (data->mode == DT_IOP_HIGHLIGHTS_SEGMENTS)
-                                          ? DT_IOP_HIGHLIGHTS_OPPOSED : data->mode;
+  const dt_iop_highlights_mode_t dmode = fastmode && (d->mode == DT_IOP_HIGHLIGHTS_SEGMENTS)
+                                          ? DT_IOP_HIGHLIGHTS_OPPOSED : d->mode;
   switch(dmode)
   {
     case DT_IOP_HIGHLIGHTS_INPAINT: // a1ex's (magiclantern) idea of color inpainting:
     {
-      const float clipper = data->clip * highlights_clip_magics[DT_IOP_HIGHLIGHTS_INPAINT];
+      const float clipper = d->clip * highlights_clip_magics[DT_IOP_HIGHLIGHTS_INPAINT];
       const float clips[4] = { clipper * piece->pipe->dsc.processed_maximum[0],
                                clipper * piece->pipe->dsc.processed_maximum[1],
                                clipper * piece->pipe->dsc.processed_maximum[2], clip };
@@ -840,7 +840,7 @@ void process(struct dt_iop_module_t *self,
 
       float *tmp = _process_opposed(self, piece, ivoid, ovoid, roi_in, roi_out, TRUE, TRUE);
       if(tmp)
-        _process_segmentation(piece, ivoid, ovoid, roi_in, roi_out, data, vmode, tmp);
+        _process_segmentation(piece, ivoid, ovoid, roi_in, roi_out, d, vmode, tmp);
       dt_free_align(tmp);
       break;
     }
@@ -853,7 +853,7 @@ void process(struct dt_iop_module_t *self,
 
     case DT_IOP_HIGHLIGHTS_LAPLACIAN:
     {
-      const float clipper = data->clip * highlights_clip_magics[DT_IOP_HIGHLIGHTS_LAPLACIAN];
+      const float clipper = d->clip * highlights_clip_magics[DT_IOP_HIGHLIGHTS_LAPLACIAN];
       const dt_aligned_pixel_t clips = { clipper * piece->pipe->dsc.processed_maximum[0],
                                          clipper * piece->pipe->dsc.processed_maximum[1],
                                          clipper * piece->pipe->dsc.processed_maximum[2], clip };
@@ -869,7 +869,7 @@ void process(struct dt_iop_module_t *self,
   }
 
   // update processed maximum
-  if((data->mode != DT_IOP_HIGHLIGHTS_LAPLACIAN) && (data->mode != DT_IOP_HIGHLIGHTS_SEGMENTS) && (data->mode != DT_IOP_HIGHLIGHTS_OPPOSED))
+  if((d->mode != DT_IOP_HIGHLIGHTS_LAPLACIAN) && (d->mode != DT_IOP_HIGHLIGHTS_SEGMENTS) && (d->mode != DT_IOP_HIGHLIGHTS_OPPOSED))
   {
     // The guided laplacian, inpaint opposed and segmentation modes keep signal scene-referred and don't clip highlights to 1
     // For the other modes, we need to notify the pipeline that white point has changed
@@ -878,7 +878,7 @@ void process(struct dt_iop_module_t *self,
   }
 }
 
-void commit_params(struct dt_iop_module_t *self,
+void commit_params(dt_iop_module_t *self,
                    dt_iop_params_t *p1,
                    dt_dev_pixelpipe_t *pipe,
                    dt_dev_pixelpipe_iop_t *piece)
@@ -919,8 +919,7 @@ void commit_params(struct dt_iop_module_t *self,
 void init_global(dt_iop_module_so_t *module)
 {
   const int program = 2; // basic.cl, from programs.conf
-  dt_iop_highlights_global_data_t *gd
-      = (dt_iop_highlights_global_data_t *)malloc(sizeof(dt_iop_highlights_global_data_t));
+  dt_iop_highlights_global_data_t *gd = malloc(sizeof(dt_iop_highlights_global_data_t));
   module->data = gd;
   gd->kernel_highlights_1f_clip = dt_opencl_create_kernel(program, "highlights_1f_clip");
   gd->kernel_highlights_1f_lch_bayer = dt_opencl_create_kernel(program, "highlights_1f_lch_bayer");
@@ -1050,7 +1049,7 @@ void gui_changed(dt_iop_module_t *self, GtkWidget *w, void *previous)
   }
 }
 
-void gui_update(struct dt_iop_module_t *self)
+void gui_update(dt_iop_module_t *self)
 {
   dt_iop_highlights_gui_data_t *g = self->gui_data;
   const dt_image_t *img = &self->dev->image_storage;
@@ -1124,6 +1123,7 @@ void reload_defaults(dt_iop_module_t *self)
     dt_bauhaus_widget_set_quad_active(g->strength, FALSE);
     g->hlr_mask_mode = DT_HIGHLIGHTS_MASK_OFF;
   }
+  d->clip = MIN(d->clip, img->linear_response_limit);
 }
 
 static void _visualize_callback(GtkWidget *quad, dt_iop_module_t *self)
diff --git a/src/iop/hlreconstruct/opposed.c b/src/iop/hlreconstruct/opposed.c
@@ -91,14 +91,13 @@ static inline char _mask_dilated(const char *in, const size_t w1)
 
 
 // A slightly modified version for sraws
-static void _process_linear_opposed(
-        struct dt_iop_module_t *self,
-        dt_dev_pixelpipe_iop_t *piece,
-        const float *const input,
-        float *const output,
-        const dt_iop_roi_t *const roi_in,
-        const dt_iop_roi_t *const roi_out,
-        const gboolean quality)
+static void _process_linear_opposed(dt_iop_module_t *self,
+                                    dt_dev_pixelpipe_iop_t *piece,
+                                    const float *const input,
+                                    float *const output,
+                                    const dt_iop_roi_t *const roi_in,
+                                    const dt_iop_roi_t *const roi_out,
+                                    const gboolean quality)
 {
   dt_iop_highlights_data_t *d = piece->data;
   const float clipval = highlights_clip_magics[DT_IOP_HIGHLIGHTS_OPPOSED] * d->clip;
@@ -203,20 +202,20 @@ static void _process_linear_opposed(
   }
 }
 
-static float *_process_opposed(
-        struct dt_iop_module_t *self,
-        dt_dev_pixelpipe_iop_t *piece,
-        const float *const input,
-        float *const output,
-        const dt_iop_roi_t *const roi_in,
-        const dt_iop_roi_t *const roi_out,
-        const gboolean keep,
-        const gboolean quality)
+static float *_process_opposed(dt_iop_module_t *self,
+                               dt_dev_pixelpipe_iop_t *piece,
+                               const float *const input,
+                               float *const output,
+                               const dt_iop_roi_t *const roi_in,
+                               const dt_iop_roi_t *const roi_out,
+                               const gboolean keep,
+                               const gboolean quality)
 {
   dt_iop_highlights_data_t *d = piece->data;
   const uint8_t(*const xtrans)[6] = (const uint8_t(*const)[6])piece->pipe->dsc.xtrans;
   const uint32_t filters = piece->pipe->dsc.filters;
   const float clipval = highlights_clip_magics[DT_IOP_HIGHLIGHTS_OPPOSED] * d->clip;
+
   const dt_iop_buffer_dsc_t *dsc = &piece->pipe->dsc;
   const gboolean wbon = dsc->temperature.enabled;
   const dt_aligned_pixel_t icoeffs = { wbon ? dsc->temperature.coeffs[0] : 1.0f,
@@ -398,19 +397,19 @@ static float *_process_opposed(
 }
 
 #ifdef HAVE_OPENCL
-static cl_int process_opposed_cl(
-        struct dt_iop_module_t *self,
-        dt_dev_pixelpipe_iop_t *piece,
-        cl_mem dev_in,
-        cl_mem dev_out,
-        const dt_iop_roi_t *const roi_in,
-        const dt_iop_roi_t *const roi_out)
+static cl_int process_opposed_cl(dt_iop_module_t *self,
+                                 dt_dev_pixelpipe_iop_t *piece,
+                                 cl_mem dev_in,
+                                 cl_mem dev_out,
+                                 const dt_iop_roi_t *const roi_in,
+                                 const dt_iop_roi_t *const roi_out)
 {
   dt_iop_highlights_data_t *d = piece->data;
   const dt_iop_highlights_global_data_t *gd = self->global_data;
 
   const int devid = piece->pipe->devid;
   const uint32_t filters = piece->pipe->dsc.filters;
+
   const float clipval = highlights_clip_magics[DT_IOP_HIGHLIGHTS_OPPOSED] * d->clip;
   const dt_iop_buffer_dsc_t *dsc = &piece->pipe->dsc;
   const gboolean wbon = dsc->temperature.enabled;
diff --git a/src/iop/hlreconstruct/segbased.c b/src/iop/hlreconstruct/segbased.c
@@ -453,14 +453,15 @@ static void _process_segmentation(dt_dev_pixelpipe_iop_t *piece,
                                   float *const output,
                                   const dt_iop_roi_t *const roi_in,
                                   const dt_iop_roi_t *const roi_out,
-                                  dt_iop_highlights_data_t *data,
+                                  dt_iop_highlights_data_t *d,
                                   const int vmode,
                                   float *tmpout)
 {
   const uint8_t(*const xtrans)[6] = (const uint8_t(*const)[6])piece->pipe->dsc.xtrans;
   const uint32_t filters = piece->pipe->dsc.filters;
   const gboolean fullpipe = piece->pipe->type & DT_DEV_PIXELPIPE_FULL;
-  const float clipval = fmaxf(0.1f, 0.987f * data->clip);
+  const float clipval = MAX(0.1f, highlights_clip_magics[DT_IOP_HIGHLIGHTS_SEGMENTS] * d->clip);
+
   const dt_aligned_pixel_t icoeffs = { piece->pipe->dsc.temperature.coeffs[0], piece->pipe->dsc.temperature.coeffs[1], piece->pipe->dsc.temperature.coeffs[2]};
   const dt_aligned_pixel_t clips = { clipval * icoeffs[0], clipval * icoeffs[1], clipval * icoeffs[2]};
   const dt_aligned_pixel_t cube_coeffs = { powf(clips[0], 1.0f / HL_POWERF), powf(clips[1], 1.0f / HL_POWERF), powf(clips[2], 1.0f / HL_POWERF)};
@@ -471,8 +472,8 @@ static void _process_segmentation(dt_dev_pixelpipe_iop_t *piece,
                                           late ? (float)(chr->D65coeffs[1] / chr->as_shot[1]) : 1.0f,
                                           late ? (float)(chr->D65coeffs[2] / chr->as_shot[2]) : 1.0f,
                                           1.0f };
-  const int recovery_mode = data->recovery;
-  const float strength = data->strength;
+  const int recovery_mode = d->recovery;
+  const float strength = d->strength;
 
   const int recovery_closing[NUM_RECOVERY_MODES] = { 0, 0, 0, 2, 2, 0, 2};
   const int recovery_close = recovery_closing[recovery_mode];
@@ -574,7 +575,7 @@ static void _process_segmentation(dt_dev_pixelpipe_iop_t *piece,
     _masks_extend_border(plane[i], pwidth, pheight, HL_BORDER);
 
   for(int p = 0; p < HL_RGB_PLANES; p++)
-    dt_segments_combine(&isegments[p], data->combine);
+    dt_segments_combine(&isegments[p], d->combine);
 
   if(dt_get_num_threads() >= HL_RGB_PLANES)
   {
@@ -590,7 +591,7 @@ static void _process_segmentation(dt_dev_pixelpipe_iop_t *piece,
   }
 
   for(int p = 0; p < HL_RGB_PLANES; p++)
-    _calc_plane_candidates(plane[p], refavg[p], &isegments[p], cube_coeffs[p], data->candidating);
+    _calc_plane_candidates(plane[p], refavg[p], &isegments[p], cube_coeffs[p], d->candidating);
 
   DT_OMP_FOR(collapse(2))
   for(int row = 1; row < roi_in->height-1; row++)
@@ -670,7 +671,7 @@ static void _process_segmentation(dt_dev_pixelpipe_iop_t *piece,
 
       dt_gaussian_fast_blur(recout, gradient, pwidth, pheight, 1.2f, 0.0f, 20.0f, 1);
       // possibly add some noise
-      const float noise_level = data->noise_level;
+      const float noise_level = d->noise_level;
       if(noise_level > 0.0f)
       {
         for(uint32_t id = 2; id < segall->nr; id++)

Original file line number	Diff line number	Diff line change
`@@ -863,6 +863,8 @@ static void _check_linear_response_limit(Exiv2::ExifData &exifData,`
`863`	`863`	`{`
`864`	`864`	`bool found_one = false;`
`865`	`865`
	`866`	`+ // currently this only reads the dng tag, could also be used for other raws`
	`867`	`+`
`866`	`868`	`Exiv2::ExifData::const_iterator linr =`
`867`	`869`	`exifData.findKey(Exiv2::ExifKey("Exif.Image.LinearResponseLimit"));`
`868`	`870`	`if(linr != exifData.end() && linr->count() == 1)`
`@@ -871,7 +873,6 @@ static void _check_linear_response_limit(Exiv2::ExifData &exifData,`
`871`	`873`	`found_one = true;`
`872`	`874`	`}`
`873`	`875`
`874`		`- // currently this only reads the dng tag, could also be used for other raws`
`875`	`876`	`if(found_one)`
`876`	`877`	dt_print(DT_DEBUG_IMAGEIO, "[exif] `%s` has LinearResponseLimit %.4f",
`877`	`878`	`img->filename, img->linear_response_limit);`
Original file line number	Diff line number	Diff line change
`@@ -385,11 +385,11 @@ void modify_roi_in(dt_iop_module_t *self,`
`385`	`385`	`roi_in->scale = 1.0f;`
`386`	`386`	`}`
`387`	`387`
`388`		`-void tiling_callback(struct dt_iop_module_t *self,`
`389`		`- struct dt_dev_pixelpipe_iop_t *piece,`
	`388`	`+void tiling_callback(dt_iop_module_t *self,`
	`389`	`+ dt_dev_pixelpipe_iop_t *piece,`
`390`	`390`	`const dt_iop_roi_t *roi_in,`
`391`	`391`	`const dt_iop_roi_t *roi_out,`
`392`		`- struct dt_develop_tiling_t *tiling)`
	`392`	`+ dt_develop_tiling_t *tiling)`
`393`	`393`	`{`
`394`	`394`	`dt_iop_highlights_data_t *d = piece->data;`
`395`	`395`	`const uint32_t filters = piece->pipe->dsc.filters;`
`@@ -407,8 +407,7 @@ void tiling_callback(struct dt_iop_module_t *self,`
`407`	`407`	`tiling->overhead = 0;`
`408`	`408`	`tiling->overlap = 0;`
`409`	`409`
`410`		`- dt_develop_blend_params_t *const bldata =`
`411`		`- (dt_develop_blend_params_t *const)piece->blendop_data;`
	`410`	`+ dt_develop_blend_params_t *const bldata = piece->blendop_data;`
`412`	`411`	`if(bldata`
`413`	`412`	`&& (piece->pipe->store_all_raster_masks \|\| dt_iop_is_raster_mask_used(self, BLEND_RASTER_ID)))`
`414`	`413`	`{`
`@@ -464,7 +463,7 @@ void tiling_callback(struct dt_iop_module_t *self,`
`464`	`463`	`}`
`465`	`464`
`466`	`465`	`#ifdef HAVE_OPENCL`
`467`		`-int process_cl(struct dt_iop_module_t *self,`
	`466`	`+int process_cl(dt_iop_module_t *self,`
`468`	`467`	`dt_dev_pixelpipe_iop_t *piece,`
`469`	`468`	`cl_mem dev_in,`
`470`	`469`	`cl_mem dev_out,`
`@@ -673,15 +672,15 @@ static void process_visualize(dt_dev_pixelpipe_iop_t *piece,`
`673`	`672`	`void *const ovoid,`
`674`	`673`	`const dt_iop_roi_t *const roi_in,`
`675`	`674`	`const dt_iop_roi_t *const roi_out,`
`676`		`- dt_iop_highlights_data_t *data)`
	`675`	`+ dt_iop_highlights_data_t *d)`
`677`	`676`	`{`
`678`	`677`	`const uint8_t(const xtrans)[6] = (const uint8_t(const)[6])piece->pipe->dsc.xtrans;`
`679`	`678`	`const uint32_t filters = piece->pipe->dsc.filters;`
`680`	`679`	`const gboolean is_xtrans = (filters == 9u);`
`681`	`680`	`const float const in = (const float const)ivoid;`
`682`	`681`	`float const out = (float const)ovoid;`
`683`	`682`
`684`		`- const float mclip = data->clip * highlights_clip_magics[data->mode];`
	`683`	`+ const float mclip = d->clip * highlights_clip_magics[d->mode];`
`685`	`684`	`const float *cf = piece->pipe->dsc.temperature.coeffs;`
`686`	`685`	`const float clips[4] = { mclip * (cf[RED] <= 0.0f ? 1.0f : cf[RED]),`
`687`	`686`	`mclip * (cf[GREEN] <= 0.0f ? 1.0f : cf[GREEN]),`
`@@ -724,27 +723,28 @@ static void process_visualize(dt_dev_pixelpipe_iop_t *piece,`
`724`	`723`	`}`
`725`	`724`	`}`
`726`	`725`
`727`		`-void process(struct dt_iop_module_t *self,`
	`726`	`+void process(dt_iop_module_t *self,`
`728`	`727`	`dt_dev_pixelpipe_iop_t *piece,`
`729`	`728`	`const void *const ivoid,`
`730`	`729`	`void *const ovoid,`
`731`	`730`	`const dt_iop_roi_t *const roi_in,`
`732`	`731`	`const dt_iop_roi_t *const roi_out)`
`733`	`732`	`{`
`734`	`733`	`const uint32_t filters = piece->pipe->dsc.filters;`
`735`		`- dt_iop_highlights_data_t *data = piece->data;`
	`734`	`+ dt_iop_highlights_data_t *d = piece->data;`
`736`	`735`	`dt_iop_highlights_gui_data_t *g = self->gui_data;`
`737`	`736`
`738`	`737`	`const gboolean fullpipe = piece->pipe->type & DT_DEV_PIXELPIPE_FULL;`
`739`	`738`	`const gboolean fastmode = piece->pipe->type & DT_DEV_PIXELPIPE_FAST;`
	`739`	`+`
`740`	`740`	`if(g && fullpipe)`
`741`	`741`	`{`
`742`	`742`	`if(g->hlr_mask_mode != DT_HIGHLIGHTS_MASK_OFF)`
`743`	`743`	`{`
`744`	`744`	`piece->pipe->mask_display = DT_DEV_PIXELPIPE_DISPLAY_PASSTHRU;`
`745`	`745`	`if(g->hlr_mask_mode == DT_HIGHLIGHTS_MASK_CLIPPED)`
`746`	`746`	`{`
`747`		`- process_visualize(piece, ivoid, ovoid, roi_in, roi_out, data);`
	`747`	`+ process_visualize(piece, ivoid, ovoid, roi_in, roi_out, d);`
`748`	`748`	`return;`
`749`	`749`	`}`
`750`	`750`	`}`
`@@ -760,11 +760,11 @@ void process(struct dt_iop_module_t *self,`
`760`	`760`	`high_quality = (level >= min_s);`
`761`	`761`	`}`
`762`	`762`
`763`		`- const float clip = data->clip * dt_iop_get_processed_minimum(piece);`
	`763`	`+ const float clip = d->clip * dt_iop_get_processed_minimum(piece);`
`764`	`764`
`765`	`765`	`if(filters == 0)`
`766`	`766`	`{`
`767`		`- if(data->mode == DT_IOP_HIGHLIGHTS_CLIP)`
	`767`	`+ if(d->mode == DT_IOP_HIGHLIGHTS_CLIP)`
`768`	`768`	`{`
`769`	`769`	`process_clip(self, piece, ivoid, ovoid, roi_in, roi_out, clip);`
`770`	`770`	`const float m = dt_iop_get_processed_minimum(piece);`
`@@ -778,13 +778,13 @@ void process(struct dt_iop_module_t *self,`
`778`	`778`	`return;`
`779`	`779`	`}`
`780`	`780`
`781`		`- const dt_iop_highlights_mode_t dmode = fastmode && (data->mode == DT_IOP_HIGHLIGHTS_SEGMENTS)`
`782`		`- ? DT_IOP_HIGHLIGHTS_OPPOSED : data->mode;`
	`781`	`+ const dt_iop_highlights_mode_t dmode = fastmode && (d->mode == DT_IOP_HIGHLIGHTS_SEGMENTS)`
	`782`	`+ ? DT_IOP_HIGHLIGHTS_OPPOSED : d->mode;`
`783`	`783`	`switch(dmode)`
`784`	`784`	`{`
`785`	`785`	`case DT_IOP_HIGHLIGHTS_INPAINT: // a1ex's (magiclantern) idea of color inpainting:`
`786`	`786`	`{`
`787`		`- const float clipper = data->clip * highlights_clip_magics[DT_IOP_HIGHLIGHTS_INPAINT];`
	`787`	`+ const float clipper = d->clip * highlights_clip_magics[DT_IOP_HIGHLIGHTS_INPAINT];`
`788`	`788`	`const float clips[4] = { clipper * piece->pipe->dsc.processed_maximum[0],`
`789`	`789`	`clipper * piece->pipe->dsc.processed_maximum[1],`
`790`	`790`	`clipper * piece->pipe->dsc.processed_maximum[2], clip };`
`@@ -840,7 +840,7 @@ void process(struct dt_iop_module_t *self,`
`840`	`840`
`841`	`841`	`float *tmp = _process_opposed(self, piece, ivoid, ovoid, roi_in, roi_out, TRUE, TRUE);`
`842`	`842`	`if(tmp)`
`843`		`- _process_segmentation(piece, ivoid, ovoid, roi_in, roi_out, data, vmode, tmp);`
	`843`	`+ _process_segmentation(piece, ivoid, ovoid, roi_in, roi_out, d, vmode, tmp);`
`844`	`844`	`dt_free_align(tmp);`
`845`	`845`	`break;`
`846`	`846`	`}`
`@@ -853,7 +853,7 @@ void process(struct dt_iop_module_t *self,`
`853`	`853`
`854`	`854`	`case DT_IOP_HIGHLIGHTS_LAPLACIAN:`
`855`	`855`	`{`
`856`		`- const float clipper = data->clip * highlights_clip_magics[DT_IOP_HIGHLIGHTS_LAPLACIAN];`
	`856`	`+ const float clipper = d->clip * highlights_clip_magics[DT_IOP_HIGHLIGHTS_LAPLACIAN];`
`857`	`857`	`const dt_aligned_pixel_t clips = { clipper * piece->pipe->dsc.processed_maximum[0],`
`858`	`858`	`clipper * piece->pipe->dsc.processed_maximum[1],`
`859`	`859`	`clipper * piece->pipe->dsc.processed_maximum[2], clip };`
`@@ -869,7 +869,7 @@ void process(struct dt_iop_module_t *self,`
`869`	`869`	`}`
`870`	`870`
`871`	`871`	`// update processed maximum`
`872`		`- if((data->mode != DT_IOP_HIGHLIGHTS_LAPLACIAN) && (data->mode != DT_IOP_HIGHLIGHTS_SEGMENTS) && (data->mode != DT_IOP_HIGHLIGHTS_OPPOSED))`
	`872`	`+ if((d->mode != DT_IOP_HIGHLIGHTS_LAPLACIAN) && (d->mode != DT_IOP_HIGHLIGHTS_SEGMENTS) && (d->mode != DT_IOP_HIGHLIGHTS_OPPOSED))`
`873`	`873`	`{`
`874`	`874`	`// The guided laplacian, inpaint opposed and segmentation modes keep signal scene-referred and don't clip highlights to 1`
`875`	`875`	`// For the other modes, we need to notify the pipeline that white point has changed`
`@@ -878,7 +878,7 @@ void process(struct dt_iop_module_t *self,`
`878`	`878`	`}`
`879`	`879`	`}`
`880`	`880`
`881`		`-void commit_params(struct dt_iop_module_t *self,`
	`881`	`+void commit_params(dt_iop_module_t *self,`
`882`	`882`	`dt_iop_params_t *p1,`
`883`	`883`	`dt_dev_pixelpipe_t *pipe,`
`884`	`884`	`dt_dev_pixelpipe_iop_t *piece)`
`@@ -919,8 +919,7 @@ void commit_params(struct dt_iop_module_t *self,`
`919`	`919`	`void init_global(dt_iop_module_so_t *module)`
`920`	`920`	`{`
`921`	`921`	`const int program = 2; // basic.cl, from programs.conf`
`922`		`- dt_iop_highlights_global_data_t *gd`
`923`		`- = (dt_iop_highlights_global_data_t *)malloc(sizeof(dt_iop_highlights_global_data_t));`
	`922`	`+ dt_iop_highlights_global_data_t *gd = malloc(sizeof(dt_iop_highlights_global_data_t));`
`924`	`923`	`module->data = gd;`
`925`	`924`	`gd->kernel_highlights_1f_clip = dt_opencl_create_kernel(program, "highlights_1f_clip");`
`926`	`925`	`gd->kernel_highlights_1f_lch_bayer = dt_opencl_create_kernel(program, "highlights_1f_lch_bayer");`
`@@ -1050,7 +1049,7 @@ void gui_changed(dt_iop_module_t self, GtkWidget w, void *previous)`
`1050`	`1049`	`}`
`1051`	`1050`	`}`
`1052`	`1051`
`1053`		`-void gui_update(struct dt_iop_module_t *self)`
	`1052`	`+void gui_update(dt_iop_module_t *self)`
`1054`	`1053`	`{`
`1055`	`1054`	`dt_iop_highlights_gui_data_t *g = self->gui_data;`
`1056`	`1055`	`const dt_image_t *img = &self->dev->image_storage;`
`@@ -1124,6 +1123,7 @@ void reload_defaults(dt_iop_module_t *self)`
`1124`	`1123`	`dt_bauhaus_widget_set_quad_active(g->strength, FALSE);`
`1125`	`1124`	`g->hlr_mask_mode = DT_HIGHLIGHTS_MASK_OFF;`
`1126`	`1125`	`}`
	`1126`	`+ d->clip = MIN(d->clip, img->linear_response_limit);`
`1127`	`1127`	`}`
`1128`	`1128`
`1129`	`1129`	`static void _visualize_callback(GtkWidget quad, dt_iop_module_t self)`