Redefine dt_control_running()

It's now implemented as an inline function checking for darktable.control == NULL, if so
write caller, file and position to the logs.

control-last_expose_time was not used at all so it got removed.

Author: jenshannoschwalm

src/control/control.c

@@ -220,7 +220,6 @@ void dt_control_init(const gboolean withgui)
   // same thread as init
   s->gui_thread = pthread_self();
 
-  // s->last_expose_time = dt_get_wtime();
   s->log_pos = s->log_ack = 0;
   s->busy = 0;
   s->log_message_timeout_id = 0;
@@ -283,11 +282,6 @@ void dt_control_change_cursor(dt_cursor_t curs)
     via DT_CONTROL_STATE_CLEANUP before doing so.
 */
 
-gboolean dt_control_running()
-{
-  return darktable.control && dt_atomic_get_int(&darktable.control->running) == DT_CONTROL_STATE_RUNNING;
-}
-
 void dt_control_quit()
 {
   // Make sure we proceed further only if control is running

src/control/control.h

@@ -175,7 +175,6 @@ typedef struct dt_control_t
 
   // gui settings
   dt_pthread_mutex_t global_mutex, image_mutex;
-  double last_expose_time;
 
   // job management
   dt_atomic_int running;
@@ -248,7 +247,20 @@ void dt_control_cleanup(const gboolean withgui);
 void dt_control_quit(void);
 
 /** get threadsafe running state. */
-gboolean dt_control_running(void);
+#define dt_control_running() _control_running_with_caller(__FILE__, __LINE__, __FUNCTION__)
+static inline gboolean _control_running_with_caller(const char *file,
+                                                    const int line,
+                                                    const char *function)
+{
+  dt_control_t *c = darktable.control;
+  if(!c)
+  {
+    dt_print(DT_DEBUG_ALWAYS, "undefined control in '%s': `%s:%d`", function, file, line);
+    return FALSE;
+  }
+  else
+    return dt_atomic_get_int(&c->running) == DT_CONTROL_STATE_RUNNING;
+}
 
 // thread-safe interface between core and gui.
 // is the locking really needed?