Skip to content

Commit fdb9e2f

Browse files
committed
denoiseprofile: disable highlight preservation if not applicable
The defaults now initialize the highlight preservation compensation mode to FALSE if the image does not support it. While there is, at any given point in time, no difference between setting it to FALSE and setting it to TRUE if the image does not have applicable metadata, we might break edits on "refresh EXIF" in future updates. If a newer darktable version adds support e.g. for the Sony metadata, edits which had been made before that would suddenly get a different denoise profile selected. By disabling the highlight compensation mode if the image was not shot with highlight preservation (or at least we *think* it wasn't shot with it), we avoid this.
1 parent 052f56c commit fdb9e2f

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

src/iop/denoiseprofile.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2856,7 +2856,9 @@ void reload_defaults(dt_iop_module_t *self)
28562856
d->fix_anscombe_and_nlmeans_norm = TRUE;
28572857
d->use_new_vst = TRUE;
28582858
d->wavelet_color_mode = MODE_Y0U0V0;
2859-
d->compensate_hilite_pres = TRUE;
2859+
2860+
const int iso_shift = _get_iso_highlight_preservation_shift(&self->dev->image_storage);
2861+
d->compensate_hilite_pres = iso_shift > 0;
28602862

28612863
GList *profiles = dt_noiseprofile_get_matching(&self->dev->image_storage);
28622864
char name[512];

0 commit comments

Comments
 (0)