static analyzer

Author: maruncz

test/librawspeed/metadata/CameraSensorInfoTest.cpp

@@ -269,7 +269,7 @@ class CameraSensorInfoTest : public ::testing::TestWithParam<IsoExpectationsT> {
             std::rand(), // NOLINT do not need crypto-level randomness
             std::rand()  // NOLINT do not need crypto-level randomness
         }) {}
-  virtual void SetUp() override { data = GetParam(); }
+  void SetUp() override { data = GetParam(); }
 
   IsoExpectationsT data;
 

test/librawspeed/metadata/CameraTest.cpp

@@ -139,7 +139,7 @@ TEST(BoolHintTest, HintsBoolTrue) {
 
 class BoolHintTest : public ::testing::TestWithParam<std::tuple<string>> {
 protected:
-  virtual void SetUp() override { notTrue = std::get<0>(GetParam()); }
+  void SetUp() override { notTrue = std::get<0>(GetParam()); }
   string notTrue;
 };
 INSTANTIATE_TEST_CASE_P(NotTrue, BoolHintTest,

test/librawspeed/metadata/ColorFilterArrayTest.cpp

@@ -140,7 +140,7 @@ TEST(ColorFilterArrayTestBasic, HandlesOutOfBounds) {
 class ColorFilterArrayTest : public ::testing::TestWithParam<Bayer2x2> {
 protected:
   ColorFilterArrayTest() = default;
-  virtual void SetUp() { param = GetParam(); }
+  void SetUp() override { param = GetParam(); }
 
   Bayer2x2 param;
 };
@@ -234,7 +234,7 @@ class ColorFilterArrayShiftTest
           std::tuple<CFAColor, CFAColor, CFAColor, CFAColor, int, int>> {
 protected:
   ColorFilterArrayShiftTest() = default;
-  virtual void SetUp() {
+  void SetUp() override {
     auto param = GetParam();
     mat = std::make_tuple(std::get<0>(param), std::get<1>(param),
                           std::get<2>(param), std::get<3>(param));