Skip to content

Commit b05db5b

Browse files
committed
shift by 32 is UB
1 parent 1a1b723 commit b05db5b

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

src/librawspeed/metadata/ColorFilterArray.cpp

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,9 @@ uint32_t ColorFilterArray::shiftDcrawFilter(uint32_t filter, int x, int y) {
153153
// A shift in y direction means rotating the whole int by 4 bits.
154154
y *= 4;
155155
y = y >= 0 ? y % 32 : 32 - ((-y) % 32);
156-
filter = (filter >> y) | (filter << (32 - y));
156+
if (y != 0) {
157+
filter = (filter >> y) | (filter << (32 - y));
158+
}
157159

158160
return filter;
159161
}

0 commit comments

Comments
 (0)