Skip to content

Commit 444cc77

Browse files
zanbaldwinzanbaldwin
committed
test(types): 🚨 remove tests that assert invalid types
1 parent 03159d0 commit 444cc77

File tree

9 files changed

+11
-70
lines changed

9 files changed

+11
-70
lines changed

‎tests/DataProvider/Formatter/ConsistentFormatter.php‎

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ public static function getValidBinarySequences()
3434
];
3535
}
3636

37-
/** @return list<array{mixed}> */
37+
/** @return list<array{string}> */
3838
public static function getInvalidBinarySequences()
3939
{
4040
return [
@@ -43,13 +43,6 @@ public static function getInvalidBinarySequences()
4343
['123456789012345'],
4444
['12345678901234567'],
4545
['This one is completely wrong.'],
46-
// 5 bytes instead of 4.
47-
[123],
48-
[1.3],
49-
[array()],
50-
[(object) array()],
51-
[null],
52-
[true],
5346
];
5447
}
5548
}

‎tests/DataProvider/Formatter/NativeFormatter.php‎

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ public static function getValidBinarySequences()
3333
];
3434
}
3535

36-
/** @return list<array{mixed}> */
36+
/** @return list<array{string}> */
3737
public static function getInvalidBinarySequences()
3838
{
3939
return [
@@ -42,13 +42,6 @@ public static function getInvalidBinarySequences()
4242
['123456789012345'],
4343
['12345678901234567'],
4444
['This one is completely wrong.'],
45-
// 5 bytes instead of 4.
46-
[123],
47-
[1.3],
48-
[array()],
49-
[(object) array()],
50-
[null],
51-
[true],
5245
];
5346
}
5447
}

‎tests/DataProvider/IPv4.php‎

Lines changed: 2 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ public static function getValidIpAddresses()
4949
return array_merge(self::getValidBinarySequences(), self::getValidProtocolIpAddresses());
5050
}
5151

52-
/** @return list<array{mixed}> */
52+
/** @return list<array{string}> */
5353
public static function getInvalidIpAddresses()
5454
{
5555
return [
@@ -60,12 +60,6 @@ public static function getInvalidIpAddresses()
6060
['This one is completely wrong.'],
6161
// 5 bytes instead of 4.
6262
[pack('H*', '20010db80')],
63-
[123],
64-
[1.3],
65-
[array()],
66-
[(object) array()],
67-
[null],
68-
[true],
6963
['12345'],
7064
['123'],
7165
];
@@ -87,19 +81,12 @@ public static function getValidCidrValues()
8781
];
8882
}
8983

90-
/** @return list<array{mixed}> */
84+
/** @return list<array{int}> */
9185
public static function getInvalidCidrValues()
9286
{
9387
return [
9488
[-1],
9589
[33],
96-
['0'],
97-
['128'],
98-
[12.3],
99-
[true],
100-
[null],
101-
[[]],
102-
[(object) []],
10390
];
10491
}
10592

‎tests/DataProvider/IPv6.php‎

Lines changed: 2 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ public static function getValidIpAddresses()
4848
return array_merge(self::getValidBinarySequences(), self::getValidProtocolIpAddresses());
4949
}
5050

51-
/** @return list<array{mixed}> */
51+
/** @return list<array{string}> */
5252
public static function getInvalidIpAddresses()
5353
{
5454
return [
@@ -60,12 +60,6 @@ public static function getInvalidIpAddresses()
6060
['This one is completely wrong.'],
6161
// 15 bytes instead of 16.
6262
[pack('H*', '20010db8000000000a608a2e037073')],
63-
[123],
64-
[1.3],
65-
[array()],
66-
[(object) array()],
67-
[null],
68-
[true],
6963
['12345678901234567'],
7064
['123456789012345'],
7165
];
@@ -86,19 +80,12 @@ public static function getValidCidrValues()
8680
];
8781
}
8882

89-
/** @return list<array{mixed}> */
83+
/** @return list<array{int}> */
9084
public static function getInvalidCidrValues()
9185
{
9286
return [
9387
[-1],
9488
[129],
95-
['0'],
96-
['128'],
97-
[12.3],
98-
[true],
99-
[null],
100-
[[]],
101-
[(object) []],
10289
];
10390
}
10491

‎tests/DataProvider/Multi.php‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -90,12 +90,6 @@ public static function getInvalidIpAddresses()
9090
['This one is completely wrong.'],
9191
// 15 bytes instead of 16.
9292
[pack('H*', '20010db8000000000a608a2e037073')],
93-
[123],
94-
[1.3],
95-
[array()],
96-
[(object) array()],
97-
[null],
98-
[true],
9993
['12345678901234567'],
10094
['123456789012345'],
10195
];

‎tests/DataProvider/Strategy/Compatible.php‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,12 @@ public static function getValidIpAddresses()
1818
return array_merge($valid, $invalid);
1919
}
2020

21-
/** @return array<array{mixed}> */
21+
/** @return array<array{string}> */
2222
public static function getInvalidIpAddresses()
2323
{
2424
return [
2525
[pack('H*', '20010db8000000000a608a2e037073')],
2626
[pack('H*', '20010db8000000000a608a2e0370734556')],
27-
[123],
2827
['12345678901234567'],
2928
['123456789012345'],
3029
];

‎tests/DataProvider/Strategy/Derived.php‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,12 @@ public static function getValidIpAddresses()
1818
return array_merge($valid, $invalid);
1919
}
2020

21-
/** @return list<array{mixed}> */
21+
/** @return list<array{string}> */
2222
public static function getInvalidIpAddresses()
2323
{
2424
return [
2525
[pack('H*', '20010db8000000000a608a2e037073')],
2626
[pack('H*', '20010db8000000000a608a2e0370734556')],
27-
[123],
2827
['12345678901234567'],
2928
['123456789012345'],
3029
];

‎tests/DataProvider/Strategy/Mapped.php‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,12 @@ public static function getValidIpAddresses()
1818
return array_merge($valid, $invalid);
1919
}
2020

21-
/** @return list<array{mixed}> */
21+
/** @return list<array{string}> */
2222
public static function getInvalidIpAddresses()
2323
{
2424
return [
2525
[pack('H*', '20010db8000000000a608a2e037073')],
2626
[pack('H*', '20010db8000000000a608a2e0370734556')],
27-
[123],
2827
['12345678901234567'],
2928
['123456789012345'],
3029
];

‎tests/DataProvider/Util/Binary.php‎

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -32,31 +32,21 @@ public static function getBinaryData()
3232
];
3333
}
3434

35-
/** @return list<array{mixed}> */
35+
/** @return list<array{string}> */
3636
public static function getInvalidHex()
3737
{
3838
return [
39-
[1],
40-
[1.2],
41-
[null],
42-
[[]],
43-
[new \stdClass],
4439
['1'],
4540
['123'],
4641
['abcdeg'],
4742
['29C 6E'],
4843
];
4944
}
5045

51-
/** @return list<array{mixed}> */
46+
/** @return list<array{string}> */
5247
public static function getInvalidHumanReadable()
5348
{
5449
return [
55-
[1],
56-
[1.2],
57-
[null],
58-
[[]],
59-
[new \stdClass],
6050
['1'],
6151
['010'],
6252
['101210'],

0 commit comments

Comments
 (0)