Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

Commit 1078ca5

Browse files
winstonewertrkirov
authored andcommitted
fix(template_cache): Fixes an issue with the generated_template_cache.
Given the code ng.applicationFactory().addModule(myModule).run(), this is rewritten into ng.staticApplicationFactory(...)..addModule(generated_template_cache).addModule(myModule).run(). The original expression evaluates to an Injector, but the rewritten expression evaluates to to the StaticApplication object. Since addModule already returns this, its not needed to use .., so I've removed it, restoring the correct evaluated object.
1 parent 09797f0 commit 1078ca5

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

lib/tools/transformer/static_angular_generator.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ class _NgDynamicToStaticVisitor extends GeneralizingAstVisitor {
102102
transaction.edit(
103103
m.end,
104104
m.end,
105-
'..addModule(generated_template_cache.templateCacheModule)');
105+
'.addModule(generated_template_cache.templateCacheModule)');
106106
}
107107
}
108108
super.visitMethodInvocation(m);

test/tools/transformer/static_angular_generator_spec.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ import 'main_generated_template_cache.dart' as generated_template_cache;
7979
class MyModule extends Module {}
8080
8181
main() {
82-
var app = staticApplicationFactory(generated_static_metadata.typeAnnotations, generated_static_expressions.getters, generated_static_expressions.setters, generated_static_expressions.symbols, generated_static_type_to_uri_mapper.typeToUriMapper)..addModule(generated_template_cache.templateCacheModule)
82+
var app = staticApplicationFactory(generated_static_metadata.typeAnnotations, generated_static_expressions.getters, generated_static_expressions.setters, generated_static_expressions.symbols, generated_static_type_to_uri_mapper.typeToUriMapper).addModule(generated_template_cache.templateCacheModule)
8383
.addModule(new MyModule())
8484
.run();
8585
}
@@ -117,7 +117,7 @@ import 'main_generated_template_cache.dart' as generated_template_cache;
117117
class MyModule extends Module {}
118118
119119
main() {
120-
var app = ng.staticApplicationFactory(generated_static_metadata.typeAnnotations, generated_static_expressions.getters, generated_static_expressions.setters, generated_static_expressions.symbols, generated_static_type_to_uri_mapper.typeToUriMapper)..addModule(generated_template_cache.templateCacheModule)
120+
var app = ng.staticApplicationFactory(generated_static_metadata.typeAnnotations, generated_static_expressions.getters, generated_static_expressions.setters, generated_static_expressions.symbols, generated_static_type_to_uri_mapper.typeToUriMapper).addModule(generated_template_cache.templateCacheModule)
121121
.addModule(new MyModule())
122122
.run();
123123
}

0 commit comments

Comments
 (0)