fix(view): change ViewPort to remove the view that got inserted in the same VM turn

See issue #1630

Author: vsavkin

lib/core_dom/view.dart

@@ -82,8 +82,25 @@ class ViewPort {
   /// The associated scope is destroyed immediately.
   View remove(View view) {
     view.scope.destroy();
+
+    // The view removal is sync, and the corresponding DOM operation is async.
     views.remove(view);
     scope.rootScope.domWrite(() {
+
+      /**
+       * We have to call `views.remove` one more time to handle the case when a view gets
+       * inserted and removed in the VM turn.
+       *
+       *     viewPort.insert(a);
+       *     viewPort.remove(a);
+       *
+       * Another option of making the view insertion synchronous does not work because of:
+       * https://github.com/angular/angular.dart/issues/1630
+       *
+       * Remove this once Issue 1630 is fixed.
+       */
+      views.remove(view);
+
       _animate.remove(view.nodes);
       _notifyLightDom();
     });

test/core_dom/view_spec.dart

@@ -131,21 +131,29 @@ main() {
 
 
       describe('remove', () {
-        beforeEach((RootScope scope) {
+        it("should remove newly added view", (RootScope scope) {
           viewPort.insert(a);
-          viewPort.insert(b, insertAfter: a);
+          viewPort.remove(a);
           scope.flush();
 
-          expect(rootElement.text).toEqual('AaBb');
+          expect(viewPort.views).toEqual([]);
         });
 
         it('should remove the last view', (RootScope scope) {
+          viewPort.insert(a);
+          viewPort.insert(b, insertAfter: a);
+          scope.flush();
+
           viewPort.remove(b);
           scope.flush();
           expect(rootElement).toHaveHtml('<!-- anchor --><span>A</span>a');
         });
 
         it('should remove child views from parent pseudo black', (RootScope scope) {
+          viewPort.insert(a);
+          viewPort.insert(b, insertAfter: a);
+          scope.flush();
+
           viewPort.remove(a);
           scope.flush();
           expect(rootElement).toHaveHtml('<!-- anchor --><span>B</span>b');