Enable the avoid_dynamic_calls lint (#112)

devoncarew · web-flow · commit dfbe88b890c3 · 2022-02-15T16:19:30.000-08:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 1.0.3-dev
+
+* Enable the `avoid_dynamic_calls` lint.
+
 ## 1.0.2
 
 * Update description.
diff --git a/analysis_options.yaml b/analysis_options.yaml
@@ -1,11 +1,13 @@
 include: package:lints/recommended.yaml
+
 analyzer:
   strong-mode:
     implicit-casts: false
 
 linter:
   rules:
     - annotate_overrides
+    - avoid_dynamic_calls
     - avoid_function_literals_in_foreach_calls
     - avoid_init_to_null
     - avoid_null_checks_in_equality_operators
diff --git a/lib/src/logger.dart b/lib/src/logger.dart
@@ -174,7 +174,7 @@ class Logger {
     Object? object;
     if (isLoggable(logLevel)) {
       if (message is Function) {
-        message = message();
+        message = (message as Object? Function())();
       }
 
       String msg;
diff --git a/pubspec.yaml b/pubspec.yaml
@@ -1,5 +1,5 @@
 name: logging
-version: 1.0.2
+version: 1.0.3-dev
 
 description: >-
   Provides APIs for debugging and error logging, similar to loggers in other

Original file line number	Diff line number	Diff line change
`@@ -174,7 +174,7 @@ class Logger {`
`174`	`174`	`Object? object;`
`175`	`175`	`if (isLoggable(logLevel)) {`
`176`	`176`	`if (message is Function) {`
`177`		`- message = message();`
	`177`	`+ message = (message as Object? Function())();`
`178`	`178`	`}`
`179`	`179`
`180`	`180`	`String msg;`