fix(dart_frog_gen): do not report rogue route if index.dart already exists (#264)

Author: felangel

packages/dart_frog_gen/lib/src/build_route_configuration.dart

@@ -225,9 +225,12 @@ List<RouteFile> _getRouteFiles({
     onRoute(route);
     files.add(route);
 
-    if (subDirectories.contains(path.basenameWithoutExtension(filePath))) {
-      onRogueRoute(route);
-    }
+    final fileBasename = path.basenameWithoutExtension(filePath);
+    final isRogueRoute = subDirectories.contains(fileBasename) &&
+        !File(path.join(directory.path, fileBasename, 'index.dart'))
+            .existsSync();
+
+    if (isRogueRoute) onRogueRoute(route);
   });
   return files;
 }

packages/dart_frog_gen/test/src/build_route_configuration_test.dart

@@ -805,5 +805,67 @@ void main() {
         ]),
       );
     });
+
+    test('does not report rogue route when index.dart already exists', () {
+      const expected = [
+        {
+          'name': '_',
+          'route': '/',
+          'middleware': false,
+          'files': [
+            {'name': 'api', 'path': '../routes/api.dart', 'route': '/api'}
+          ]
+        },
+        {
+          'name': '_api',
+          'route': '/api',
+          'middleware': false,
+          'files': [
+            {
+              'name': 'api_index',
+              'path': '../routes/api/index.dart',
+              'route': '/'
+            }
+          ]
+        }
+      ];
+      final directory = Directory(
+        path.join(
+          Directory.current.path,
+          'test',
+          '.fixtures',
+          'rogue_routes_with_conflict',
+        ),
+      )..createSync(recursive: true);
+      final routes = Directory(path.join(directory.path, 'routes'))
+        ..createSync();
+      File(path.join(routes.path, 'api.dart')).createSync();
+      final apiDirectory = Directory(path.join(routes.path, 'api'))
+        ..createSync();
+      File(path.join(apiDirectory.path, 'index.dart')).createSync();
+      final configuration = buildRouteConfiguration(directory);
+      expect(
+        configuration.directories.map((d) => d.toJson()).toList(),
+        equals(expected),
+      );
+      expect(
+        configuration.endpoints,
+        equals({
+          '/api': [
+            isA<RouteFile>().having(
+              (r) => r.path,
+              'path',
+              '../routes/api.dart',
+            ),
+            isA<RouteFile>().having(
+              (r) => r.path,
+              'path',
+              '../routes/api/index.dart',
+            ),
+          ],
+        }),
+      );
+      expect(configuration.rogueRoutes, isEmpty);
+    });
   });
 }