refactor(bricks): update hook dependencies (#1813)

Author: felangel

bricks/create_dart_frog/hooks/analysis_options.yaml

@@ -1 +1 @@
-include: package:very_good_analysis/analysis_options.6.0.0.yaml
+include: package:very_good_analysis/analysis_options.yaml

bricks/create_dart_frog/hooks/pubspec.yaml

@@ -4,10 +4,10 @@ environment:
   sdk: ">=3.0.0 <4.0.0"
 
 dependencies:
-  mason: ^0.1.0-dev.39
+  mason: ^0.1.0
   path: ^1.8.1
 
 dev_dependencies:
   mocktail: ^1.0.0
   test: ^1.25.0
-  very_good_analysis: ^6.0.0
+  very_good_analysis: ^9.0.0

bricks/dart_frog_dev_server/hooks/analysis_options.yaml

@@ -1 +1,5 @@
-include: package:very_good_analysis/analysis_options.7.0.0.yaml
+include: package:very_good_analysis/analysis_options.yaml
+linter:
+  rules:
+    # Experimental and there are lots of false positives
+    specify_nonobvious_property_types: false

bricks/dart_frog_dev_server/hooks/pubspec.yaml

@@ -6,11 +6,11 @@ environment:
 
 dependencies:
   dart_frog_gen: ^2.0.0
-  mason: ^0.1.0-dev.39
+  mason: ^0.1.0
   pubspec_parse: ^1.2.0
 
 dev_dependencies:
   mocktail: ^1.0.0
   path: ^1.8.2
   test: ^1.25.0
-  very_good_analysis: ^7.0.0
+  very_good_analysis: ^9.0.0

bricks/dart_frog_new/hooks/analysis_options.yaml

@@ -1,5 +1,7 @@
-include: package:very_good_analysis/analysis_options.7.0.0.yaml
+include: package:very_good_analysis/analysis_options.yaml
 
 linter:
   rules:
     public_member_api_docs: false
+    # Experimental and there are lots of false positives
+    specify_nonobvious_property_types: false

bricks/dart_frog_new/hooks/pubspec.yaml

@@ -6,10 +6,10 @@ environment:
 
 dependencies:
   dart_frog_gen: ^2.0.0
-  mason: ^0.1.0-dev.49
+  mason: ^0.1.0
   path: ^1.8.0
 
 dev_dependencies:
   mocktail: ^1.0.0
   test: ^1.19.2
-  very_good_analysis: ^7.0.0
+  very_good_analysis: ^9.0.0

bricks/dart_frog_prod_server/hooks/analysis_options.yaml

@@ -1,4 +1,6 @@
-include: package:very_good_analysis/analysis_options.6.0.0.yaml
+include: package:very_good_analysis/analysis_options.yaml
 linter:
   rules:
-    public_member_api_docs: false
+    public_member_api_docs: false  
+    # Experimental and there are lots of false positives
+    specify_nonobvious_property_types: false

bricks/dart_frog_prod_server/hooks/lib/src/create_bundle.dart

@@ -29,7 +29,7 @@ Future<void> createBundle({
       '${tempDirectory.path}${path.separator}',
     );
     bundlingProgress.complete();
-  } catch (error) {
+  } on Exception catch (error) {
     bundlingProgress.fail();
     context.logger.err('$error');
     return exit(1);

bricks/dart_frog_prod_server/hooks/lib/src/pubspec_lock/pubspec_lock.dart

@@ -1,10 +1,3 @@
-/// A simple parser for pubspec.lock files.
-///
-/// This is used by the bundling process to check for those dependencies that
-/// are external path dependencies. Hence, it is not a complete parser, it only
-/// parses the information that is needed for the bundling process.
-library pubspec_lock;
-
 import 'dart:collection';
 
 import 'package:equatable/equatable.dart';
@@ -35,6 +28,8 @@ class PubspecLock {
     late final YamlMap yaml;
     try {
       yaml = loadYaml(content) as YamlMap;
+      // ignoring for backward compatibility
+      // ignore: avoid_catches_without_on_clauses
     } catch (_) {
       throw const PubspecLockParseException();
     }
@@ -53,6 +48,8 @@ class PubspecLock {
           data: entry.value as YamlMap,
         );
         parsedPackages.add(package);
+        // ignoring for backward compatibility
+        // ignore: avoid_catches_without_on_clauses
       } catch (_) {
         // Ignore those packages that for some reason cannot be parsed.
       }

bricks/dart_frog_prod_server/hooks/pre_gen.dart

@@ -48,7 +48,7 @@ Future<void> preGen(
   final RouteConfiguration configuration;
   try {
     configuration = buildConfiguration(projectDirectory);
-  } catch (error) {
+  } on Exception catch (error) {
     context.logger.err('$error');
     return exit(1);
   }