Skip to content

Commit 3f15b30

Browse files
authored
feat: adding option to customize the dart version on the build brick (#670)
1 parent 94e4c85 commit 3f15b30

File tree

4 files changed

+17
-5
lines changed

4 files changed

+17
-5
lines changed

bricks/dart_frog_prod_server/__brick__/build/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Official Dart image: https://hub.docker.com/_/dart
22
# Specify the Dart SDK base image version using dart:<version> (ex: dart:2.17)
3-
FROM dart:stable AS build
3+
FROM dart:{{dartVersion}} AS build
44

55
WORKDIR /app
66

@@ -28,4 +28,4 @@ COPY --from=build /app/bin/server /app/bin/
2828
{{#serveStaticFiles}}COPY --from=build /app/public /public/{{/serveStaticFiles}}
2929

3030
# Start server.
31-
CMD ["/app/bin/server"]
31+
CMD ["/app/bin/server"]

bricks/dart_frog_prod_server/brick.yaml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,3 +4,10 @@ version: 0.1.0+1
44

55
environment:
66
mason: ">=0.1.0-dev <0.1.0"
7+
8+
vars:
9+
dartVersion:
10+
type: string
11+
description: Dart version to be used in the generated Dockerfile.
12+
default: stable
13+
prompt: Dart version?

bricks/dart_frog_prod_server/hooks/pre_gen.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,5 +93,6 @@ Future<void> preGen(
9393
'invokeCustomEntrypoint': configuration.invokeCustomEntrypoint,
9494
'invokeCustomInit': configuration.invokeCustomInit,
9595
'pathDependencies': await getPathDependencies(projectDirectory),
96+
'dartVersion': context.vars['dartVersion'],
9697
};
9798
}

bricks/dart_frog_prod_server/hooks/test/pre_gen_test.dart

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,8 @@ void main() {
3838

3939
setUp(() {
4040
logger = _MockLogger();
41-
context = _FakeHookContext(logger: logger);
41+
context = _FakeHookContext(logger: logger)
42+
..vars['dartVersion'] = 'stable';
4243

4344
when(() => logger.progress(any())).thenReturn(_MockProgress());
4445
});
@@ -217,7 +218,8 @@ dev_dependencies:
217218
'serveStaticFiles': false,
218219
'invokeCustomEntrypoint': true,
219220
'invokeCustomInit': false,
220-
'pathDependencies': <String>[]
221+
'pathDependencies': <String>[],
222+
'dartVersion': 'stable',
221223
}),
222224
);
223225
});
@@ -249,7 +251,8 @@ dev_dependencies:
249251
'serveStaticFiles': false,
250252
'invokeCustomEntrypoint': false,
251253
'invokeCustomInit': true,
252-
'pathDependencies': <String>[]
254+
'pathDependencies': <String>[],
255+
'dartVersion': 'stable',
253256
}),
254257
);
255258
});
@@ -383,6 +386,7 @@ dev_dependencies:
383386
'invokeCustomEntrypoint': false,
384387
'invokeCustomInit': false,
385388
'pathDependencies': <String>[],
389+
'dartVersion': 'stable',
386390
}),
387391
);
388392
},

0 commit comments

Comments
 (0)