refactor(vscode): defined isDartFrogCliInstalled (#748)

Author: alestiago

extensions/vscode/src/commands/install-cli.ts

@@ -1,12 +1,13 @@
 const cp = require("child_process");
 
 import { window, ProgressOptions } from "vscode";
+import { isDartFrogCliInstalled } from "../utils/utils";
 
 /**
  * Installs Dart Frog CLI in the user's system if not already installed.
  */
 export const installCLI = async (): Promise<void> => {
-  if (!hasDartFrogCliInstalled()) {
+  if (!isDartFrogCliInstalled()) {
     const options: ProgressOptions = {
       location: 15,
       title: "Installing Dart Frog CLI...",
@@ -15,21 +16,6 @@ export const installCLI = async (): Promise<void> => {
   }
 };
 
-/**
- * Whether the user has Dart Frog CLI installed in their system.
- *
- * @returns {boolean} True if the user has Dart Frog CLI installed in their
- * system, false otherwise.
- */
-function hasDartFrogCliInstalled(): boolean {
-  try {
-    cp.execSync(`dart_frog --version`);
-    return true;
-  } catch (error) {
-    return false;
-  }
-}
-
 /**
  * Installs Dart Frog CLI from pub.dev.
  *

extensions/vscode/src/test/suite/commands/install-cli.test.ts

@@ -10,6 +10,7 @@ suite("install-cli command", () => {
   let vscodeStub: any;
   let childProcessStub: any;
   let command: any;
+  let utilsStub: any;
 
   beforeEach(() => {
     vscodeStub = {
@@ -22,11 +23,16 @@ suite("install-cli command", () => {
       exec: sinon.stub(),
       execSync: sinon.stub(),
     };
+    utilsStub = {
+      isDartFrogCliInstalled: sinon.stub(),
+    };
 
     command = proxyquire("../../../commands/install-cli", {
       vscode: vscodeStub,
       // eslint-disable-next-line @typescript-eslint/naming-convention
       child_process: childProcessStub,
+      // eslint-disable-next-line @typescript-eslint/naming-convention
+      "../utils/utils": utilsStub,
     });
   });
 
@@ -35,7 +41,7 @@ suite("install-cli command", () => {
   });
 
   test("does not install if Dart Frog CLI is already installed", async () => {
-    childProcessStub.execSync.withArgs("dart_frog --version").returns("0.0.0");
+    utilsStub.isDartFrogCliInstalled.returns(true);
 
     await command.installCLI();
 
@@ -47,9 +53,7 @@ suite("install-cli command", () => {
 
   suite("installs Dart Frog CLI", () => {
     beforeEach(() => {
-      childProcessStub.execSync
-        .withArgs("dart_frog --version")
-        .throws("Command failed");
+      utilsStub.isDartFrogCliInstalled.returns(false);
     });
 
     test("when not already installed", async () => {

extensions/vscode/src/utils/cli-version.ts

@@ -34,3 +34,13 @@ export function readDartFrogVersion(): String | undefined {
 export function isCompatibleCLIVersion(version: String): Boolean {
   return semver.satisfies(version, compatibleCLIVersion);
 }
+
+/**
+ * Whether the user has Dart Frog CLI installed in their system.
+ *
+ * @returns {boolean} True if the user has Dart Frog CLI installed in their
+ * system, false otherwise.
+ */
+export function isDartFrogCliInstalled(): boolean {
+  return readDartFrogVersion() !== undefined;
+}

extensions/vscode/src/utils/utils.ts

@@ -0,0 +1 @@
+export * from "./cli-version";