refactor(dart_frog): upgrade to Dart 2.19 and Very Good Analysis 4.0.0 (#535)

Author: felangel

packages/dart_frog/analysis_options.yaml

@@ -1 +1 @@
-include: package:very_good_analysis/analysis_options.3.1.0.yaml
+include: package:very_good_analysis/analysis_options.4.0.0.yaml

packages/dart_frog/lib/dart_frog.dart

@@ -17,5 +17,5 @@ export 'src/create_static_file_handler.dart' show createStaticFileHandler;
 export 'src/handler.dart' show Handler;
 export 'src/hot_reload.dart' show hotReload;
 export 'src/http_method.dart' show HttpMethod;
-export 'src/middleware.dart' show Middleware, HandlerUse;
+export 'src/middleware.dart' show HandlerUse, Middleware;
 export 'src/provider.dart' show provider;

packages/dart_frog/lib/src/hot_reload.dart

@@ -1,7 +1,7 @@
 import 'dart:async';
 import 'dart:io';
 
-import 'package:shelf_hotreload/shelf_hotreload.dart' show withHotreload, Level;
+import 'package:shelf_hotreload/shelf_hotreload.dart' show Level, withHotreload;
 
 /// Hot reload support for the server returned by the [initializer].
 void hotReload(FutureOr<HttpServer> Function() initializer) {

packages/dart_frog/pubspec.yaml

@@ -7,7 +7,7 @@ issue_tracker: https://github.com/VeryGoodOpenSource/dart_frog/issues
 documentation: https://dartfrog.vgv.dev/docs/overview
 
 environment:
-  sdk: ">=2.18.0 <3.0.0"
+  sdk: ">=2.19.0 <3.0.0"
 
 dependencies:
   http_methods: ^1.1.0
@@ -20,4 +20,4 @@ dev_dependencies:
   mocktail: ^0.3.0
   path: ^1.8.2
   test: ^1.19.2
-  very_good_analysis: ^3.1.0
+  very_good_analysis: ^4.0.0

packages/dart_frog/test/src/router_test.dart

@@ -14,6 +14,8 @@
 // limitations under the License.
 
 @TestOn('vm')
+library;
+
 import 'dart:convert';
 import 'dart:io';
 
@@ -291,7 +293,7 @@ void main() {
 
     final app = Router()
       ..all('/hello', (RequestContext context) => Response(body: 'hello-world'))
-      ..mount('/api/', api)
+      ..mount('/api/', api.call)
       ..all(
         '/<_|[^]*>',
         (RequestContext context) => Response(body: 'catch-all-handler'),
@@ -339,7 +341,7 @@ void main() {
     final app = Router()
       ..mount(
         '/api/',
-        const Pipeline().addMiddleware(middleware).addHandler(api),
+        const Pipeline().addMiddleware(middleware).addHandler(api.call),
       );
 
     server.mount((request) async {
@@ -370,7 +372,7 @@ void main() {
       ..all('/hello', (RequestContext context) {
         return Response(body: 'hello-world');
       })
-      ..mount('/api', api)
+      ..mount('/api', api.call)
       ..all('/<_|[^]*>', (RequestContext context) {
         return Response(body: 'catch-all-handler');
       });
@@ -491,7 +493,7 @@ void main() {
           return Response(body: '$user to $other: $action');
         });
 
-      return router;
+      return router.call;
     }
 
     // Routes for a specific <user>.
@@ -508,7 +510,7 @@ void main() {
         ..get('/', (RequestContext context) {
           return Response(body: '$user root');
         });
-      return router;
+      return router.call;
     }
 
     final app = Router()

packages/dart_frog/test/src/serve_test.dart

@@ -15,7 +15,7 @@ void main() {
     });
 
     test('can return multiple 404s', () async {
-      final server = await serve(Router(), 'localhost', 3001);
+      final server = await serve(Router().call, 'localhost', 3001);
       final client = HttpClient();
       var request = await client.getUrl(Uri.parse('http://localhost:3001'));
       var response = await request.close();