Skip to content

Commit 6394ecf

Browse files
committed
feat(vscode): use showErroMessage over progress when failed to start
1 parent 38975e2 commit 6394ecf

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

extensions/vscode/src/commands/start-dev-server.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ export const startDevServer = async (): Promise<
117117

118118
const startDaemonResponse = await daemon.send(startDaemonRequest);
119119
if (startDaemonResponse.error) {
120-
progress.report({ message: startDaemonResponse.error.message });
120+
window.showErrorMessage(startDaemonResponse.error.message);
121121
return;
122122
}
123123

extensions/vscode/src/test/suite/commands/start-dev-server.test.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1017,11 +1017,11 @@ suite("start-dev-server command", () => {
10171017
progress.report = sinon.stub();
10181018
await progressFunction(progress);
10191019

1020-
sinon.assert.calledOnce(
1021-
progress.report.withArgs({
1022-
message: startResponse.error.message,
1023-
})
1020+
sinon.assert.calledWith(
1021+
vscodeStub.window.showErrorMessage,
1022+
startResponse.error.message
10241023
);
1024+
sinon.assert.calledOnce(progress.report);
10251025
});
10261026

10271027
test("returns application when complete", async () => {

0 commit comments

Comments
 (0)