refactor(dart_frog_prod_server): use "lib" and package imports (#1245)

alestiago · web-flow · commit 9e3b3541210c · 2024-01-17T10:12:58.000Z
diff --git a/bricks/dart_frog_prod_server/hooks/analysis_options.yaml b/bricks/dart_frog_prod_server/hooks/analysis_options.yaml
@@ -1 +1,4 @@
 include: package:very_good_analysis/analysis_options.5.1.0.yaml
+linter:
+  rules:
+    public_member_api_docs: false
diff --git a/bricks/dart_frog_prod_server/hooks/lib/dart_frog_prod_server_hooks.dart b/bricks/dart_frog_prod_server/hooks/lib/dart_frog_prod_server_hooks.dart
@@ -0,0 +1,6 @@
+export 'src/create_bundle.dart';
+export 'src/create_external_packages_folder.dart';
+export 'src/dart_pub_get.dart';
+export 'src/exit_overrides.dart';
+export 'src/get_internal_path_dependencies.dart';
+export 'src/get_pubspec_lock.dart';
diff --git a/bricks/dart_frog_prod_server/hooks/lib/src/create_bundle.dart b/bricks/dart_frog_prod_server/hooks/lib/src/create_bundle.dart
diff --git a/bricks/dart_frog_prod_server/hooks/lib/src/create_external_packages_folder.dart b/bricks/dart_frog_prod_server/hooks/lib/src/create_external_packages_folder.dart
@@ -1,10 +1,9 @@
 import 'dart:io';
 
+import 'package:dart_frog_prod_server_hooks/dart_frog_prod_server_hooks.dart';
 import 'package:io/io.dart' as io;
 import 'package:path/path.dart' as path;
 
-import 'get_pubspec_lock.dart';
-
 Future<List<String>> createExternalPackagesFolder(
   Directory directory, {
   path.Context? pathContext,
diff --git a/bricks/dart_frog_prod_server/hooks/lib/src/dart_pub_get.dart b/bricks/dart_frog_prod_server/hooks/lib/src/dart_pub_get.dart
diff --git a/bricks/dart_frog_prod_server/hooks/lib/src/exit_overrides.dart b/bricks/dart_frog_prod_server/hooks/lib/src/exit_overrides.dart
diff --git a/bricks/dart_frog_prod_server/hooks/lib/src/get_internal_path_dependencies.dart b/bricks/dart_frog_prod_server/hooks/lib/src/get_internal_path_dependencies.dart
@@ -1,9 +1,8 @@
 import 'dart:io' as io;
 
+import 'package:dart_frog_prod_server_hooks/dart_frog_prod_server_hooks.dart';
 import 'package:path/path.dart' as path;
 
-import 'get_pubspec_lock.dart';
-
 Future<List<String>> getInternalPathDependencies(io.Directory directory) async {
   final pubspecLock = await getPubspecLock(directory.path);
   return pubspecLock.packages
diff --git a/bricks/dart_frog_prod_server/hooks/lib/src/get_pubspec_lock.dart b/bricks/dart_frog_prod_server/hooks/lib/src/get_pubspec_lock.dart
diff --git a/bricks/dart_frog_prod_server/hooks/post_gen.dart b/bricks/dart_frog_prod_server/hooks/post_gen.dart
@@ -1,12 +1,10 @@
 import 'dart:async';
 import 'dart:io' as io;
 
+import 'package:dart_frog_prod_server_hooks/dart_frog_prod_server_hooks.dart';
 import 'package:mason/mason.dart' show HookContext, lightCyan;
 import 'package:path/path.dart' as path;
 
-import 'src/dart_pub_get.dart';
-import 'src/exit_overrides.dart';
-
 void _defaultExit(int code) => ExitOverrides.current?.exit ?? io.exit;
 
 Future<void> run(HookContext context) => postGen(context);
diff --git a/bricks/dart_frog_prod_server/hooks/pre_gen.dart b/bricks/dart_frog_prod_server/hooks/pre_gen.dart
@@ -2,17 +2,12 @@ import 'dart:async';
 import 'dart:io' as io;
 
 import 'package:dart_frog_gen/dart_frog_gen.dart';
+import 'package:dart_frog_prod_server_hooks/dart_frog_prod_server_hooks.dart';
 import 'package:io/io.dart' as io_expanded;
 import 'package:mason/mason.dart'
     show HookContext, defaultForeground, lightCyan;
 import 'package:path/path.dart' as path;
 
-import 'src/create_bundle.dart';
-import 'src/create_external_packages_folder.dart';
-import 'src/dart_pub_get.dart';
-import 'src/exit_overrides.dart';
-import 'src/get_internal_path_dependencies.dart';
-
 typedef RouteConfigurationBuilder = RouteConfiguration Function(
   io.Directory directory,
 );
diff --git a/bricks/dart_frog_prod_server/hooks/test/post_gen_test.dart b/bricks/dart_frog_prod_server/hooks/test/post_gen_test.dart
@@ -1,13 +1,13 @@
 import 'dart:io';
 
+import 'package:dart_frog_prod_server_hooks/dart_frog_prod_server_hooks.dart';
 import 'package:mason/mason.dart'
     show ExitCode, HookContext, Logger, Progress, lightCyan;
 import 'package:mocktail/mocktail.dart';
 import 'package:path/path.dart' as path;
 import 'package:test/test.dart';
 
-import '../post_gen.dart';
-import '../src/exit_overrides.dart';
+import '../post_gen.dart' as post_gen;
 
 class _FakeHookContext extends Fake implements HookContext {
   _FakeHookContext({Logger? logger}) : _logger = logger ?? _MockLogger();
@@ -53,7 +53,7 @@ void main() {
     test('run completes', () {
       expect(
         ExitOverrides.runZoned(
-          () => run(_FakeHookContext(logger: logger)),
+          () => post_gen.run(_FakeHookContext(logger: logger)),
           exit: (_) {},
         ),
         completes,
@@ -64,7 +64,7 @@ void main() {
       var processRunnerCallCount = 0;
       final exitCalls = <int>[];
 
-      await postGen(
+      await post_gen.postGen(
         context,
         runProcess: (
           executable,
diff --git a/bricks/dart_frog_prod_server/hooks/test/pre_gen_test.dart b/bricks/dart_frog_prod_server/hooks/test/pre_gen_test.dart
@@ -1,15 +1,15 @@
 import 'dart:io';
 
 import 'package:dart_frog_gen/dart_frog_gen.dart';
+import 'package:dart_frog_prod_server_hooks/dart_frog_prod_server_hooks.dart';
 import 'package:mason/mason.dart'
     show HookContext, Logger, Progress, defaultForeground, lightCyan;
 import 'package:mocktail/mocktail.dart';
 import 'package:path/path.dart' as path;
 import 'package:test/test.dart';
 
-import '../pre_gen.dart';
-import '../src/exit_overrides.dart';
-import 'pubspeck_locks.dart';
+import '../pre_gen.dart' as pre_gen;
+import 'pubspec_locks.dart';
 
 class _FakeHookContext extends Fake implements HookContext {
   _FakeHookContext({Logger? logger}) : _logger = logger ?? _MockLogger();
@@ -56,7 +56,7 @@ void main() {
     test('run completes', () {
       expect(
         ExitOverrides.runZoned(
-          () => run(_FakeHookContext(logger: logger)),
+          () => pre_gen.run(_FakeHookContext(logger: logger)),
           exit: (_) {},
         ),
         completes,
@@ -66,7 +66,7 @@ void main() {
     test('exit(1) if buildRouteConfiguration throws', () async {
       final exitCalls = <int>[];
       final exception = Exception('oops');
-      await preGen(
+      await pre_gen.preGen(
         context,
         buildConfiguration: (_) => throw exception,
         exit: exitCalls.add,
@@ -112,7 +112,7 @@ void main() {
       );
 
       final exitCalls = <int>[];
-      await preGen(
+      await pre_gen.preGen(
         context,
         buildConfiguration: (_) => configuration,
         exit: exitCalls.add,
@@ -146,7 +146,7 @@ void main() {
       );
 
       final exitCalls = <int>[];
-      await preGen(
+      await pre_gen.preGen(
         context,
         buildConfiguration: (_) => configuration,
         exit: exitCalls.add,
@@ -191,7 +191,7 @@ dev_dependencies:
           fooPath,
         );
         final exitCalls = <int>[];
-        await preGen(
+        await pre_gen.preGen(
           context,
           buildConfiguration: (_) => configuration,
           exit: exitCalls.add,
@@ -215,7 +215,7 @@ dev_dependencies:
         invokeCustomEntrypoint: true,
       );
       final exitCalls = <int>[];
-      await preGen(
+      await pre_gen.preGen(
         context,
         buildConfiguration: (_) => configuration,
         exit: exitCalls.add,
@@ -273,7 +273,7 @@ dependencies:
       );
 
       final exitCalls = <int>[];
-      await preGen(
+      await pre_gen.preGen(
         context,
         buildConfiguration: (_) => configuration,
         exit: exitCalls.add,
@@ -311,7 +311,7 @@ dependencies:
         invokeCustomInit: true,
       );
       final exitCalls = <int>[];
-      await preGen(
+      await pre_gen.preGen(
         context,
         buildConfiguration: (_) => configuration,
         exit: exitCalls.add,
@@ -416,7 +416,7 @@ dependencies:
           serveStaticFiles: true,
         );
         final exitCalls = <int>[];
-        await preGen(
+        await pre_gen.preGen(
           context,
           buildConfiguration: (_) => configuration,
           exit: exitCalls.add,
diff --git a/bricks/dart_frog_prod_server/hooks/test/pubspec_locks.dart b/bricks/dart_frog_prod_server/hooks/test/pubspec_locks.dart
diff --git a/bricks/dart_frog_prod_server/hooks/test/src/create_bundle_test.dart b/bricks/dart_frog_prod_server/hooks/test/src/create_bundle_test.dart
@@ -1,12 +1,11 @@
 import 'dart:io';
 
+import 'package:dart_frog_prod_server_hooks/dart_frog_prod_server_hooks.dart';
 import 'package:mason/mason.dart' hide createBundle;
 import 'package:mocktail/mocktail.dart';
 import 'package:path/path.dart' as path;
 import 'package:test/test.dart';
 
-import '../../src/create_bundle.dart';
-
 class _MockLogger extends Mock implements Logger {}
 
 class _MockProgress extends Mock implements Progress {}
diff --git a/bricks/dart_frog_prod_server/hooks/test/src/create_external_packages_folder_test.dart b/bricks/dart_frog_prod_server/hooks/test/src/create_external_packages_folder_test.dart
@@ -1,10 +1,10 @@
 import 'dart:io';
 
+import 'package:dart_frog_prod_server_hooks/dart_frog_prod_server_hooks.dart';
 import 'package:path/path.dart' as path;
 import 'package:test/test.dart';
 
-import '../../src/create_external_packages_folder.dart';
-import '../pubspeck_locks.dart';
+import '../pubspec_locks.dart';
 
 void main() {
   group('createExternalPackagesFolder', () {
diff --git a/bricks/dart_frog_prod_server/hooks/test/src/dart_pub_get_test.dart b/bricks/dart_frog_prod_server/hooks/test/src/dart_pub_get_test.dart
@@ -1,11 +1,10 @@
 import 'dart:io';
 
+import 'package:dart_frog_prod_server_hooks/dart_frog_prod_server_hooks.dart';
 import 'package:mason/mason.dart';
 import 'package:mocktail/mocktail.dart';
 import 'package:test/test.dart';
 
-import '../../src/dart_pub_get.dart';
-
 class _FakeHookContext extends Fake implements HookContext {
   _FakeHookContext({Logger? logger}) : _logger = logger ?? _MockLogger();
 
diff --git a/bricks/dart_frog_prod_server/hooks/test/src/exit_overrides_test.dart b/bricks/dart_frog_prod_server/hooks/test/src/exit_overrides_test.dart
@@ -1,9 +1,8 @@
 import 'dart:io';
 
+import 'package:dart_frog_prod_server_hooks/dart_frog_prod_server_hooks.dart';
 import 'package:test/test.dart';
 
-import '../../src/exit_overrides.dart';
-
 void main() {
   group('ExitOverrides', () {
     group('runZoned', () {
diff --git a/bricks/dart_frog_prod_server/hooks/test/src/get_internal_path_dependencies_test.dart b/bricks/dart_frog_prod_server/hooks/test/src/get_internal_path_dependencies_test.dart
@@ -1,10 +1,9 @@
 import 'dart:io';
 
+import 'package:dart_frog_prod_server_hooks/dart_frog_prod_server_hooks.dart';
 import 'package:path/path.dart' as path;
 import 'package:test/test.dart';
 
-import '../../src/get_internal_path_dependencies.dart';
-
 void main() {
   group('getPathDependencies', () {
     test('returns nothing when there are no path dependencies', () {

-Original file line number
+Diff line change
@@ @@ -1 +1,4 @@ @@
 include: package:very_good_analysis/analysis_options.5.1.0.yaml
 +linter:
 +  rules:
 +    public_member_api_docs: false