Skip to content

Commit ca075ab

Browse files
authored
refactor(dart_frog_cli_e2e): use line splitter on e2e (#813)
1 parent 4b9cfac commit ca075ab

File tree

1 file changed

+13
-14
lines changed

1 file changed

+13
-14
lines changed

packages/dart_frog_cli/e2e/test/helpers/dart_frog_daemon.dart

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,10 @@ DaemonMessage _sdtOutLineToMessage(String rawMessage) {
2727
/// via its stdin and stdout.
2828
class DaemonStdioHelper {
2929
DaemonStdioHelper(this.daemonProcess) {
30-
subscription =
31-
daemonProcess.stdout.transform(utf8.decoder).listen(_handleStdoutLine);
30+
subscription = daemonProcess.stdout
31+
.transform(utf8.decoder)
32+
.transform(const LineSplitter())
33+
.listen(_handleStdoutLine);
3234
}
3335

3436
final Process daemonProcess;
@@ -40,22 +42,19 @@ class DaemonStdioHelper {
4042
Matcher? messageMatcher;
4143
Completer<String>? messageCompleter;
4244

43-
void _handleStdoutLine(String lines) {
45+
void _handleStdoutLine(String line) {
4446
final messageMatcher = this.messageMatcher;
4547

46-
final linesSplit = lines.split('\n');
47-
48-
for (final line in linesSplit.where((element) => element.isNotEmpty)) {
49-
stdout.writeln('::debug:: <- $line');
50-
if (messageMatcher != null) {
51-
if (messageMatcher.matches(line, {})) {
52-
messageCompleter?.complete(line);
53-
_pastMessagesCache.clear();
54-
return;
55-
}
48+
stdout.writeln('::debug:: <- $line');
49+
if (messageMatcher != null) {
50+
if (messageMatcher.matches(line, {})) {
51+
messageCompleter?.complete(line);
52+
_pastMessagesCache.clear();
53+
return;
5654
}
57-
_pastMessagesCache.add(line);
5855
}
56+
57+
_pastMessagesCache.add(line);
5958
}
6059

6160
void _clean() {

0 commit comments

Comments
 (0)