fix(vscode): avoid recommending to upgrade when version is above constraints (#864)

Author: alestiago

extensions/vscode/src/extension.ts

@@ -112,11 +112,15 @@ export async function ensureCompatibleDartFrogCLI(): Promise<void> {
     return;
   }
 
+  const options = ["Update Dart Frog CLI", "Changelog", "Ignore"];
+  const shouldUpdate = isCompatibleDartFrogCLIVersion(latestVersion);
+  if (!shouldUpdate) {
+    options.shift();
+  }
+
   const selection = await vscode.window.showWarningMessage(
     `Dart Frog CLI version ${version} is not compatible with this extension.`,
-    "Update Dart Frog CLI",
-    "Changelog",
-    "Ignore"
+    ...options
   );
   switch (selection) {
     case "Update Dart Frog CLI":

extensions/vscode/src/test/suite/extension.test.ts

@@ -279,11 +279,15 @@ suite("ensureCompatibleDartFrogCLI", () => {
 
   suite("incompatible CLI", () => {
     const version = "0.0.0";
+    const latestVersion = "2.0.0";
 
     beforeEach(() => {
       utilsStub.readDartFrogCLIVersion.returns(version);
-      utilsStub.isCompatibleDartFrogCLIVersion.returns(false);
-      utilsStub.readLatestDartFrogCLIVersion.returns(version);
+      utilsStub.readLatestDartFrogCLIVersion.returns(latestVersion);
+      utilsStub.isCompatibleDartFrogCLIVersion.withArgs(version).returns(false);
+      utilsStub.isCompatibleDartFrogCLIVersion
+        .withArgs(latestVersion)
+        .returns(true);
     });
 
     afterEach(() => {
@@ -302,6 +306,21 @@ suite("ensureCompatibleDartFrogCLI", () => {
       );
     });
 
+    test("shows warning without update action when latest version is not compatible", async () => {
+      utilsStub.isCompatibleDartFrogCLIVersion
+        .withArgs(latestVersion)
+        .returns(false);
+
+      await extension.ensureCompatibleDartFrogCLI();
+
+      sinon.assert.calledOnceWithExactly(
+        vscodeStub.window.showWarningMessage,
+        `Dart Frog CLI version ${version} is not compatible with this extension.`,
+        "Changelog",
+        "Ignore"
+      );
+    });
+
     test("updates CLI when selected", async () => {
       vscodeStub.window.showWarningMessage.returns("Update Dart Frog CLI");
 
@@ -315,7 +334,10 @@ suite("ensureCompatibleDartFrogCLI", () => {
 
       await extension.ensureCompatibleDartFrogCLI();
 
-      sinon.assert.calledOnceWithExactly(utilsStub.openChangelog, version);
+      sinon.assert.calledOnceWithExactly(
+        utilsStub.openChangelog,
+        latestVersion
+      );
       sinon.assert.notCalled(commandsStub.updateCLI);
     });