Skip to content

Commit d7efe88

Browse files
authored
fix(vscode): ensure daemon spawns in shell for Windows compatibility (#1065)
1 parent afc6d8e commit d7efe88

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

extensions/vscode/src/daemon/dart-frog-daemon.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,7 @@ export class DartFrogDaemon {
142142

143143
this.process = spawn("dart_frog", ["daemon"], {
144144
cwd: workingDirectory,
145+
shell: true,
145146
});
146147
this.process.stdout.on("data", this.stdoutDataListener.bind(this));
147148

extensions/vscode/src/test/suite/daemon/dart-frog-daemon.test.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ suite("DartFrogDaemon", () => {
4949
childProcessStub.spawn
5050
.withArgs("dart_frog", ["daemon"], {
5151
cwd: workingDirectory,
52+
shell: true,
5253
})
5354
.returns(daemonProcess);
5455

@@ -73,6 +74,7 @@ suite("DartFrogDaemon", () => {
7374
childProcessStub.spawn
7475
.withArgs("dart_frog", ["daemon"], {
7576
cwd: workingDirectory,
77+
shell: true,
7678
})
7779
.returns(daemonProcess);
7880

@@ -94,6 +96,7 @@ suite("DartFrogDaemon", () => {
9496
childProcessStub.spawn
9597
.withArgs("dart_frog", ["daemon"], {
9698
cwd: workingDirectory,
99+
shell: true,
97100
})
98101
.returns(daemonProcess);
99102

@@ -125,6 +128,7 @@ suite("DartFrogDaemon", () => {
125128
childProcessStub.spawn
126129
.withArgs("dart_frog", ["daemon"], {
127130
cwd: workingDirectory,
131+
shell: true,
128132
})
129133
.returns(daemonProcess);
130134

@@ -235,6 +239,7 @@ suite("DartFrogDaemon", () => {
235239
childProcessStub.spawn
236240
.withArgs("dart_frog", ["daemon"], {
237241
cwd: workingDirectory,
242+
shell: true,
238243
})
239244
.returns(daemonProcess);
240245

@@ -318,6 +323,7 @@ suite("DartFrogDaemon", () => {
318323
childProcessStub.spawn
319324
.withArgs("dart_frog", ["daemon"], {
320325
cwd: workingDirectory,
326+
shell: true,
321327
})
322328
.returns(daemonProcess);
323329

@@ -351,6 +357,7 @@ suite("DartFrogDaemon", () => {
351357
childProcessStub.spawn
352358
.withArgs("dart_frog", ["daemon"], {
353359
cwd: workingDirectory,
360+
shell: true,
354361
})
355362
.returns(daemonProcess);
356363

0 commit comments

Comments
 (0)