Skip to content

Commit dcd08e6

Browse files
renancaraujohericles-koelhererickzanardo
authored
feat: enable asserts when running dart_frog dev (#766)
Co-authored-by: Bruno <[email protected]> Co-authored-by: Erick <[email protected]>
1 parent d9ac84d commit dcd08e6

File tree

2 files changed

+65
-5
lines changed

2 files changed

+65
-5
lines changed

packages/dart_frog_cli/lib/src/dev_server_runner/dev_server_runner.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ class DevServerRunner {
225225

226226
final process = _serverProcess = await _startProcess(
227227
'dart',
228-
[enableVmServiceFlag, serverDartFilePath],
228+
[enableVmServiceFlag, '--enable-asserts', serverDartFilePath],
229229
runInShell: true,
230230
);
231231

packages/dart_frog_cli/test/src/commands/dev_server_runner/dev_server_runner_test.dart

Lines changed: 64 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -212,10 +212,7 @@ void main() {
212212

213213
expect(
214214
receivedArgs,
215-
equals([
216-
'--enable-vm-service=4343',
217-
endsWith('.dart_frog/server.dart'),
218-
]),
215+
contains('--enable-vm-service=4343'),
219216
);
220217
verify(
221218
() => generatorHooks.preGen(
@@ -359,6 +356,69 @@ void main() {
359356
);
360357
});
361358

359+
test('enable asserts', () async {
360+
final generatorHooks = _MockGeneratorHooks();
361+
when(
362+
() => generatorHooks.preGen(
363+
vars: any(named: 'vars'),
364+
workingDirectory: any(named: 'workingDirectory'),
365+
onVarsChanged: any(named: 'onVarsChanged'),
366+
),
367+
).thenAnswer((invocation) async {
368+
(invocation.namedArguments[const Symbol('onVarsChanged')] as void
369+
Function(Map<String, dynamic> vars))
370+
.call(<String, dynamic>{});
371+
});
372+
when(
373+
() => generator.generate(
374+
any(),
375+
vars: any(named: 'vars'),
376+
fileConflictResolution: FileConflictResolution.overwrite,
377+
),
378+
).thenAnswer((_) async => []);
379+
when(() => generator.hooks).thenReturn(generatorHooks);
380+
when(() => process.stdout).thenAnswer((_) => const Stream.empty());
381+
when(() => process.stderr).thenAnswer((_) => const Stream.empty());
382+
when(
383+
() => directoryWatcher.events,
384+
).thenAnswer(
385+
(_) => Stream.value(WatchEvent(ChangeType.MODIFY, 'README.md')),
386+
);
387+
388+
late List<String> receivedArgs;
389+
devServerRunner = DevServerRunner(
390+
logger: logger,
391+
port: '4242',
392+
devServerBundleGenerator: generator,
393+
dartVmServicePort: '4343',
394+
workingDirectory: Directory.current,
395+
directoryWatcher: (_) => directoryWatcher,
396+
generatorTarget: (
397+
_, {
398+
CreateFile? createFile,
399+
Logger? logger,
400+
}) =>
401+
generatorTarget,
402+
isWindows: isWindows,
403+
startProcess: (
404+
String executable,
405+
List<String> arguments, {
406+
bool runInShell = false,
407+
}) async {
408+
receivedArgs = arguments;
409+
return process;
410+
},
411+
sigint: sigint,
412+
runProcess: (_, __) async => processResult,
413+
);
414+
await expectLater(devServerRunner.start(), completes);
415+
416+
expect(
417+
receivedArgs,
418+
contains('--enable-asserts'),
419+
);
420+
});
421+
362422
test('does not reload when reloading ', () async {
363423
await expectLater(devServerRunner.start(), completes);
364424

0 commit comments

Comments
 (0)