fix(ci): unblock pipeline for windows (#1453)

Author: Jochum van der Ploeg

packages/dart_frog_cli/e2e/test/daemon/daemon_domain_test.dart

@@ -63,7 +63,7 @@ void main() {
         );
       });
 
-      test('daemon process responds to unkown message type', () async {
+      test('daemon process responds to unknown message type', () async {
         await daemonStdio.sendStringMessage('[{}]');
         final protocolError = await daemonStdio.awaitForDaemonEvent(
           'daemon.protocolError',
@@ -74,7 +74,7 @@ void main() {
         );
       });
 
-      test('daemon process responds to unkown message type', () async {
+      test('daemon process responds to unknown message type', () async {
         await daemonStdio.sendStringMessage('[{"id": 0, "method": "foo.bar"}]');
         final protocolError = await daemonStdio.awaitForDaemonEvent(
           'daemon.protocolError',

packages/dart_frog_cli/e2e/test/dev_test.dart

@@ -85,12 +85,16 @@ void main() {
 
           fail('exception not thrown');
         } catch (e) {
+          expect(e.toString(), contains('Could not start the VM service:'));
+
           expect(
-            e,
+            e.toString(),
             contains(
-              '''Could not start the VM service: localhost:8181 is already in use.''',
+              'DartDevelopmentServiceException: Failed to create server socket',
             ),
           );
+
+          expect(e.toString(), contains('127.0.0.1:8181'));
         }
       },
     );

packages/dart_frog_cli/e2e/test/helpers/dart_frog_daemon.dart

@@ -66,7 +66,7 @@ class DaemonStdioHelper {
   /// Awaits for a daemon event with the given [methodKey].
   Future<DaemonEvent> awaitForDaemonEvent(
     String methodKey, {
-    Duration timeout = const Duration(seconds: 1),
+    Duration timeout = _defaultTimeout,
     Matcher? withParamsThat,
   }) async {
     var wrappedMatcher = isA<DaemonEvent>()
@@ -91,7 +91,7 @@ class DaemonStdioHelper {
   /// Awaits for a daemon message that matches the given [messageMatcher].
   Future<DaemonMessage> awaitForDaemonMessage(
     Matcher messageMatcher, {
-    Duration timeout = const Duration(seconds: 1),
+    Duration timeout = _defaultTimeout,
   }) async {
     final wrappedMatcher = _MatchMessageToStdoutLine(messageMatcher);
 
@@ -106,7 +106,7 @@ class DaemonStdioHelper {
   /// Awaits for a string message that matches the given [messageMatcher].
   Future<String> awaitForStringMessage(
     Matcher messageMatcher, {
-    Duration timeout = const Duration(seconds: 1),
+    Duration timeout = _defaultTimeout,
   }) async {
     messageMatchers.add(messageMatcher);
 
@@ -116,15 +116,15 @@ class DaemonStdioHelper {
     }).firstOrNull;
 
     if (existingItem case (final int itemIndex, final String itemValue)) {
-      // if there is a matching message in the cache,
+      // If there is a matching message in the cache,
       // remove all the previous messages from the cache and
       // return the matching message.
       _pastMessagesCache = _pastMessagesCache.skip(itemIndex + 1).toList();
       _clean(messageMatcher, null);
       return itemValue;
     }
 
-    // if there is no matching message in the cache,
+    // If there is no matching message in the cache,
     // create a completer and wait for the message to be received
     // or for the timeout to expire.
 
@@ -157,7 +157,7 @@ class DaemonStdioHelper {
   /// [TimeoutException] if the timeout expires.
   Future<DaemonResponse> sendDaemonRequest(
     DaemonRequest request, {
-    Duration timeout = const Duration(seconds: 10),
+    Duration timeout = _defaultTimeout,
   }) async {
     final json = jsonEncode(request.toJson());
 
@@ -183,7 +183,7 @@ class DaemonStdioHelper {
   /// [TimeoutException] if the timeout expires.
   Future<(DaemonResponse, DaemonResponse)> sendStaggeredDaemonRequest(
     (DaemonRequest, DaemonRequest) requests, {
-    Duration timeout = const Duration(seconds: 10),
+    Duration timeout = _defaultTimeout,
   }) async {
     final request1 = requests.$1;
     final request2 = requests.$2;
@@ -230,6 +230,8 @@ class DaemonStdioHelper {
   void dispose() {
     subscription.cancel();
   }
+
+  static const _defaultTimeout = Duration(seconds: 10);
 }
 
 /// A matcher that matches a [DaemonMessage] to a daemon stdout line.

packages/dart_frog_cli/e2e/test/helpers/run_process.dart

@@ -17,7 +17,7 @@ Future<ProcessResult> runProcess(
     runInShell: runInShell,
   );
 
-  if (result.exitCode != 0) {
+  if (result.exitCode != 0 || _isNotEmpty(result.stderr)) {
     final commandLine = [executable, ...arguments].join(' ');
 
     throw RunProcessException(
@@ -29,6 +29,12 @@ Future<ProcessResult> runProcess(
   return result;
 }
 
+bool _isNotEmpty(dynamic data) {
+  if (data is String) return data.isNotEmpty;
+  if (data is List) return data.isNotEmpty;
+  return false;
+}
+
 class RunProcessException implements Exception {
   RunProcessException(
     this.message, {