test(dart_frog_cli): run e2e tests on os matrix (#72)

Author: felangel

.github/workflows/dart_frog_cli.yaml

@@ -29,7 +29,12 @@ jobs:
       run:
         working-directory: packages/dart_frog_cli/e2e
 
-    runs-on: ubuntu-latest
+    runs-on: ${{ matrix.os }}
+
+    strategy:
+      fail-fast: false
+      matrix:
+        os: [macos-latest, windows-latest, ubuntu-latest]
 
     steps:
       - name: 📚 Git Checkout

packages/dart_frog_cli/e2e/test/dev_smoke_test.dart

@@ -16,15 +16,17 @@ void main() {
     const projectName = 'example';
     final tempDirectory = Directory.systemTemp.createTempSync();
 
+    late Process process;
+
     setUpAll(() async {
       await dartFrogCreate(projectName: projectName, directory: tempDirectory);
-      await dartFrogDev(
+      process = await dartFrogDev(
         directory: Directory(path.join(tempDirectory.path, projectName)),
       );
     });
 
     tearDownAll(() async {
-      await killDartFrogServer();
+      await killDartFrogServer(process.pid);
       await tempDirectory.delete(recursive: true);
     });
 

packages/dart_frog_cli/e2e/test/helpers/dart_frog_create.dart

@@ -8,6 +8,7 @@ Future<void> dartFrogCreate({
     'dart_frog',
     ['create', projectName],
     workingDirectory: directory.path,
+    runInShell: true,
   );
   if (result.exitCode != 0) {
     throw Exception('dart_frog create exited with code $exitCode');

packages/dart_frog_cli/e2e/test/helpers/dart_frog_dev.dart

@@ -2,13 +2,14 @@ import 'dart:async';
 import 'dart:convert';
 import 'dart:io';
 
-Future<void> dartFrogDev({required Directory directory}) async {
-  final completer = Completer<void>();
+Future<Process> dartFrogDev({required Directory directory}) async {
+  final completer = Completer<Process>();
 
   final process = await Process.start(
     'dart_frog',
     ['dev'],
     workingDirectory: directory.path,
+    runInShell: true,
   );
 
   late StreamSubscription stdoutSubscription;
@@ -19,7 +20,7 @@ Future<void> dartFrogDev({required Directory directory}) async {
     if (message.contains('Hot reload is enabled.')) {
       stdoutSubscription.cancel();
       stderrSubscription.cancel();
-      completer.complete();
+      completer.complete(process);
     }
   });
 
@@ -31,5 +32,5 @@ Future<void> dartFrogDev({required Directory directory}) async {
     exit(1);
   });
 
-  await completer.future;
+  return completer.future;
 }

packages/dart_frog_cli/e2e/test/helpers/kill_dart_frog_server.dart

@@ -1,8 +1,23 @@
 import 'dart:io';
 
-Future<void> killDartFrogServer() async {
-  final result = await Process.run('pkill', ['-f', 'dart_frog']);
-  if (result.exitCode != 0) {
-    throw Exception('pkill -f dart_frog exited with code $exitCode');
+Future<void> killDartFrogServer(int pid) async {
+  if (Platform.isWindows) {
+    final result = await Process.run(
+      'taskkill',
+      ['/F', '/T', '/PID', '$pid'],
+      runInShell: true,
+    );
+    if (result.exitCode != 0) {
+      throw Exception('taskkill /F /T /PID $pid exited with code $exitCode');
+    }
+    return;
+  }
+
+  if (Platform.isLinux || Platform.isMacOS) {
+    final result = await Process.run('pkill', ['-f', 'dart_frog']);
+    if (result.exitCode != 0) {
+      throw Exception('pkill -f dart_frog exited with code $exitCode');
+    }
+    return;
   }
 }