fix(mason_cli): update silently fails when the sdk is incompatible (#480)

Author: renancaraujo

packages/dart_frog_cli/lib/src/commands/update/update.dart

@@ -1,3 +1,5 @@
+import 'dart:io';
+
 import 'package:args/command_runner.dart';
 import 'package:dart_frog_cli/src/command_runner.dart';
 import 'package:dart_frog_cli/src/version.dart';
@@ -44,13 +46,22 @@ class UpdateCommand extends Command<int> {
     }
 
     final updateProgress = _logger.progress('Updating to $latestVersion');
+    late ProcessResult result;
     try {
-      await _pubUpdater.update(packageName: packageName);
+      result = await _pubUpdater.update(
+        packageName: packageName,
+        versionConstraint: latestVersion,
+      );
     } catch (error) {
       updateProgress.fail();
       _logger.err('$error');
       return ExitCode.software.code;
     }
+    if (result.exitCode != ExitCode.success.code) {
+      updateProgress.fail();
+      _logger.err('Error updating Dart Frog CLI: ${result.stderr}');
+      return ExitCode.software.code;
+    }
     updateProgress.complete('Updated to $latestVersion');
 
     return ExitCode.success.code;

packages/dart_frog_cli/pubspec.yaml

@@ -14,7 +14,7 @@ dependencies:
   mason: ^0.1.0-dev.39
   meta: ^1.7.0
   path: ^1.8.1
-  pub_updater: ^0.2.2
+  pub_updater: ^0.2.4
   pubspec_parse: ^1.2.0
   stream_transform: ^2.0.0
   watcher: ^1.0.1

packages/dart_frog_cli/test/src/commands/update/update_test.dart

@@ -12,7 +12,7 @@ class MockLogger extends Mock implements Logger {}
 
 class MockPubUpdater extends Mock implements PubUpdater {}
 
-class FakeProcessResult extends Fake implements ProcessResult {}
+class MockProcessResult extends Mock implements ProcessResult {}
 
 class MockProgress extends Mock implements Progress {}
 
@@ -23,18 +23,23 @@ void main() {
     late Logger logger;
     late PubUpdater pubUpdater;
     late UpdateCommand command;
+    late ProcessResult processResult;
 
     setUp(() {
       logger = MockLogger();
       pubUpdater = MockPubUpdater();
+      processResult = MockProcessResult();
 
       when(() => logger.progress(any())).thenReturn(MockProgress());
       when(
         () => pubUpdater.getLatestVersion(any()),
       ).thenAnswer((_) async => packageVersion);
       when(
-        () => pubUpdater.update(packageName: packageName),
-      ).thenAnswer((_) => Future.value(FakeProcessResult()));
+        () => pubUpdater.update(
+          packageName: packageName,
+          versionConstraint: any(named: 'versionConstraint'),
+        ),
+      ).thenAnswer((_) => Future.value(processResult));
 
       command = UpdateCommand(logger: logger, pubUpdater: pubUpdater);
     });
@@ -48,7 +53,10 @@ void main() {
       verify(() => logger.progress('Checking for updates')).called(1);
       verify(() => logger.err('Exception: oops'));
       verifyNever(
-        () => pubUpdater.update(packageName: any(named: 'packageName')),
+        () => pubUpdater.update(
+          packageName: any(named: 'packageName'),
+          versionConstraint: any(named: 'versionConstraint'),
+        ),
       );
     });
 
@@ -57,27 +65,71 @@ void main() {
         () => pubUpdater.getLatestVersion(any()),
       ).thenAnswer((_) async => latestVersion);
       when(
-        () => pubUpdater.update(packageName: any(named: 'packageName')),
+        () => pubUpdater.update(
+          packageName: any(named: 'packageName'),
+          versionConstraint: any(named: 'versionConstraint'),
+        ),
       ).thenThrow(Exception('oops'));
       final result = await command.run();
       expect(result, equals(ExitCode.software.code));
       verify(() => logger.progress('Checking for updates')).called(1);
       verify(() => logger.err('Exception: oops'));
       verify(
-        () => pubUpdater.update(packageName: any(named: 'packageName')),
+        () => pubUpdater.update(
+          packageName: any(named: 'packageName'),
+          versionConstraint: any(named: 'versionConstraint'),
+        ),
+      ).called(1);
+    });
+
+    test('handles pub update process errors', () async {
+      const error = 'Oh no! Installing this is not possible right now!';
+      when(() => processResult.exitCode).thenReturn(1);
+      when<dynamic>(() => processResult.stderr).thenReturn(error);
+      when(
+        () => pubUpdater.getLatestVersion(any()),
+      ).thenAnswer((_) async => latestVersion);
+      when(
+        () => pubUpdater.update(
+          packageName: any(named: 'packageName'),
+          versionConstraint: any(named: 'versionConstraint'),
+        ),
+      ).thenAnswer((_) => Future.value(processResult));
+
+      final result = await command.run();
+      expect(result, equals(ExitCode.software.code));
+      verify(() => logger.progress('Checking for updates')).called(1);
+      verify(() => logger.err('Error updating Dart Frog CLI: $error'));
+      verify(
+        () => pubUpdater.update(
+          packageName: any(named: 'packageName'),
+          versionConstraint: any(named: 'versionConstraint'),
+        ),
       ).called(1);
     });
 
     test('updates when newer version exists', () async {
       when(
         () => pubUpdater.getLatestVersion(any()),
       ).thenAnswer((_) async => latestVersion);
+      when(
+        () => pubUpdater.update(
+          packageName: any(named: 'packageName'),
+          versionConstraint: any(named: 'versionConstraint'),
+        ),
+      ).thenAnswer((_) => Future.value(processResult));
+      when(() => processResult.exitCode).thenReturn(0);
       when(() => logger.progress(any())).thenReturn(MockProgress());
       final result = await command.run();
       expect(result, equals(ExitCode.success.code));
       verify(() => logger.progress('Checking for updates')).called(1);
       verify(() => logger.progress('Updating to $latestVersion')).called(1);
-      verify(() => pubUpdater.update(packageName: packageName)).called(1);
+      verify(
+        () => pubUpdater.update(
+          packageName: packageName,
+          versionConstraint: latestVersion,
+        ),
+      ).called(1);
     });
 
     test('does not update when already on latest version', () async {
@@ -91,7 +143,12 @@ void main() {
         () => logger.info('$packageName is already at the latest version.'),
       ).called(1);
       verifyNever(() => logger.progress('Updating to $latestVersion'));
-      verifyNever(() => pubUpdater.update(packageName: packageName));
+      verifyNever(
+        () => pubUpdater.update(
+          packageName: any(named: 'packageName'),
+          versionConstraint: any(named: 'versionConstraint'),
+        ),
+      );
     });
   });
 }