run tests on windows, fix executable paths for dart/flutter (#149)

Closes #32

I believe this should just work now that we are using headless flutter

Initially also added macos tests but those bots tend to wait queued for a long time, so I have removed them.

Author: jakemac53

.github/workflows/dart_mcp.yaml

@@ -21,11 +21,16 @@ defaults:
 
 jobs:
   build:
-    runs-on: ubuntu-latest
+    runs-on: ${{ matrix.os }}
     strategy:
       fail-fast: false
       matrix:
-        sdk: [stable, dev]
+        sdk:
+          - stable
+          - dev
+        os:
+          - ubuntu-latest
+          - windows-latest
     steps:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
       - uses: dart-lang/setup-dart@e51d8e571e22473a2ddebf0ef8a2123f0ab2c02c

.github/workflows/dart_mcp_server.yaml

@@ -23,11 +23,16 @@ defaults:
 
 jobs:
   build:
-    runs-on: ubuntu-latest
+    runs-on: ${{ matrix.os }}
     strategy:
       fail-fast: false
       matrix:
-        flutterSdk: [stable, master]
+        flutterSdk:
+          - stable
+          - master
+        os:
+          - ubuntu-latest
+          - windows-latest
     steps:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
       # We need the flutter SDK in order to run the counter app for integration

pkgs/dart_mcp_server/lib/src/utils/sdk.dart

@@ -47,7 +47,9 @@ class Sdk {
     if (dartSdkPath.parent case final cacheDir
         when cacheDir.basename == 'cache' && flutterSdkPath == null) {
       if (cacheDir.parent case final binDir when binDir.basename == 'bin') {
-        final flutterExecutable = binDir.child('flutter');
+        final flutterExecutable = binDir.child(
+          'flutter${Platform.isWindows ? '.bat' : ''}',
+        );
         if (File(flutterExecutable).existsSync()) {
           flutterSdkPath = binDir.parent;
         }
@@ -61,7 +63,9 @@ class Sdk {
   ///
   /// Throws an [ArgumentError] if [dartSdkPath] is `null`.
   String get dartExecutablePath =>
-      dartSdkPath?.child('bin').child('dart') ??
+      dartSdkPath
+          ?.child('bin')
+          .child('dart${Platform.isWindows ? '.exe' : ''}') ??
       (throw ArgumentError(
         'Dart SDK location unknown, try setting the DART_SDK environment '
         'variable.',
@@ -71,7 +75,9 @@ class Sdk {
   ///
   /// Throws an [ArgumentError] if [flutterSdkPath] is `null`.
   String get flutterExecutablePath =>
-      flutterSdkPath?.child('bin').child('flutter') ??
+      flutterSdkPath
+          ?.child('bin')
+          .child('flutter${Platform.isWindows ? '.bat' : ''}') ??
       (throw ArgumentError(
         'Flutter SDK location unknown. To work on flutter projects, you must '
         'spawn the server using `dart` from the flutter SDK and not a Dart '

pkgs/dart_mcp_server/test/test_harness.dart

@@ -4,7 +4,8 @@
 
 import 'dart:async';
 import 'dart:convert';
-import 'dart:io';
+import 'dart:io' hide File;
+import 'dart:io' as io show File;
 
 import 'package:async/async.dart';
 import 'package:dart_mcp/client.dart';
@@ -256,7 +257,7 @@ final class AppDebugSession {
       await process.shouldExit(0);
     } else {
       unawaited(process.kill());
-      await process.shouldExit(anyOf(0, -9));
+      await process.shouldExit(anyOf(0, Platform.isWindows ? -1 : -9));
     }
   }
 
@@ -497,5 +498,6 @@ class _CommandMatcher extends Matcher {
 }
 
 extension RootPath on Root {
-  String get path => Uri.parse(uri).path;
+  /// Get the OS specific file path for this root.
+  String get path => io.File.fromUri(Uri.parse(uri)).path;
 }

pkgs/dart_mcp_server/test/tools/analyzer_test.dart

@@ -2,8 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-import 'dart:io';
-
 import 'package:dart_mcp/server.dart';
 import 'package:dart_mcp_server/src/mixins/analyzer.dart';
 import 'package:dart_mcp_server/src/utils/constants.dart';
@@ -75,14 +73,18 @@ void main() {
     });
 
     test('can look up symbols in a workspace', () async {
-      final currentRoot = testHarness.rootForPath(Directory.current.path);
-      testHarness.mcpClient.addRoot(currentRoot);
+      final example = d.dir('lib', [
+        d.file('awesome_class.dart', 'class MyAwesomeClass {}'),
+      ]);
+      await example.create();
+      final exampleRoot = testHarness.rootForPath(example.io.path);
+      testHarness.mcpClient.addRoot(exampleRoot);
       await pumpEventQueue();
 
       final result = await testHarness.callToolWithRetry(
         CallToolRequest(
           name: DartAnalyzerSupport.resolveWorkspaceSymbolTool.name,
-          arguments: {ParameterNames.query: 'DartAnalyzerSupport'},
+          arguments: {ParameterNames.query: 'MyAwesomeClass'},
         ),
       );
       expect(result.isError, isNot(true));
@@ -92,7 +94,7 @@ void main() {
         isA<TextContent>().having(
           (t) => t.text,
           'text',
-          contains('analyzer.dart'),
+          contains('awesome_class.dart'),
         ),
       );
     });

pkgs/dart_mcp_server/test/tools/dart_cli_test.dart

@@ -2,6 +2,8 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+import 'dart:io';
+
 import 'package:dart_mcp/server.dart';
 import 'package:dart_mcp_server/src/mixins/dash_cli.dart';
 import 'package:dart_mcp_server/src/utils/constants.dart';
@@ -15,6 +17,8 @@ void main() {
   late TestProcessManager testProcessManager;
   late Root exampleFlutterAppRoot;
   late Root dartCliAppRoot;
+  final dartExecutableName = 'dart${Platform.isWindows ? '.exe' : ''}';
+  final flutterExecutableName = 'flutter${Platform.isWindows ? '.bat' : ''}';
 
   // TODO: Use setUpAll, currently this fails due to an apparent TestProcess
   // issue.
@@ -76,7 +80,7 @@ dependencies:
       expect(result.isError, isNot(true));
       expect(testProcessManager.commandsRan, [
         equalsCommand((
-          command: [endsWith('dart'), 'fix', '--apply'],
+          command: [endsWith(dartExecutableName), 'fix', '--apply'],
           workingDirectory: exampleFlutterAppRoot.path,
         )),
       ]);
@@ -98,7 +102,7 @@ dependencies:
       expect(result.isError, isNot(true));
       expect(testProcessManager.commandsRan, [
         equalsCommand((
-          command: [endsWith('dart'), 'format', '.'],
+          command: [endsWith(dartExecutableName), 'format', '.'],
           workingDirectory: exampleFlutterAppRoot.path,
         )),
       ]);
@@ -123,7 +127,12 @@ dependencies:
       expect(result.isError, isNot(true));
       expect(testProcessManager.commandsRan, [
         equalsCommand((
-          command: [endsWith('dart'), 'format', 'foo.dart', 'bar.dart'],
+          command: [
+            endsWith(dartExecutableName),
+            'format',
+            'foo.dart',
+            'bar.dart',
+          ],
           workingDirectory: exampleFlutterAppRoot.path,
         )),
       ]);
@@ -155,15 +164,15 @@ dependencies:
       expect(testProcessManager.commandsRan, [
         equalsCommand((
           command: [
-            endsWith('flutter'),
+            endsWith(flutterExecutableName),
             'test',
             'foo_test.dart',
             'bar_test.dart',
           ],
           workingDirectory: exampleFlutterAppRoot.path,
         )),
         equalsCommand((
-          command: [endsWith('dart'), 'test', 'zip_test.dart'],
+          command: [endsWith(dartExecutableName), 'test', 'zip_test.dart'],
           workingDirectory: dartCliAppRoot.path,
         )),
       ]);
@@ -186,7 +195,7 @@ dependencies:
         expect(testProcessManager.commandsRan, [
           equalsCommand((
             command: [
-              endsWith('dart'),
+              endsWith(dartExecutableName),
               'create',
               '--template',
               'cli',
@@ -213,7 +222,7 @@ dependencies:
         expect(testProcessManager.commandsRan, [
           equalsCommand((
             command: [
-              endsWith('flutter'),
+              endsWith(flutterExecutableName),
               'create',
               '--template',
               'app',
@@ -243,7 +252,7 @@ dependencies:
         expect(testProcessManager.commandsRan, [
           equalsCommand((
             command: [
-              endsWith('flutter'),
+              endsWith(flutterExecutableName),
               'create',
               '--template',
               'app',