Remove interactive prompts, delete files as if -d was passed. (#4121)

Author: davidmorgan

_test_common/lib/test_phases.dart

@@ -145,7 +145,6 @@ Future<TestBuildersResult> testPhases(
   var options = await BuildOptions.create(
     packageGraph: packageGraph,
     reader: environment.reader,
-    deleteFilesByDefault: deleteFilesByDefault,
     skipBuildScriptCheck: true,
     enableLowResourcesMode: enableLowResourcesMode,
     logPerformanceDir: logPerformanceDir,

build/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 3.0.2-wip
+
+- Use `build_runner_core` 9.3.0.
+
 ## 3.0.1
 
 - Small improvements to RAM usage.

build/pubspec.yaml

@@ -1,5 +1,5 @@
 name: build
-version: 3.0.1
+version: 3.0.2-wip
 description: A package for authoring build_runner compatible code generators.
 repository: https://github.com/dart-lang/build/tree/master/build
 resolution: workspace
@@ -10,7 +10,7 @@ environment:
 dependencies:
   analyzer: '>=7.4.0 <9.0.0'
   async: ^2.5.0
-  build_runner_core: '9.2.1'
+  build_runner_core: '9.3.0-wip'
   built_collection: ^5.1.1
   built_value: ^8.9.5
   convert: ^3.0.0

build_resolvers/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 3.0.2-wip
+
+- Use `build` 3.0.2.
+
 ## 3.0.1
 
 - Use `build` 3.0.1.

build_resolvers/pubspec.yaml

@@ -1,5 +1,5 @@
 name: build_resolvers
-version: 3.0.1
+version: 3.0.2-wip
 description: Resolve Dart code in a Builder
 repository: https://github.com/dart-lang/build/tree/master/build_resolvers
 resolution: workspace
@@ -10,8 +10,8 @@ environment:
 dependencies:
   analyzer: '>=7.4.0 <9.0.0'
   async: ^2.5.0
-  build: '3.0.1'
-  build_runner_core: '9.2.1'
+  build: '3.0.2-wip'
+  build_runner_core: '9.3.0-wip'
   collection: ^1.17.0
   convert: ^3.1.1
   crypto: ^3.0.0

build_runner/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 2.7.0-wip
+
+- Remove interactive prompts for whether to delete files.
+- Ignore `-d` flag: always delete files as if `-d` was passed.
+
 ## 2.6.1
 
 - Use `build` 3.0.1.

build_runner/lib/src/daemon/daemon_builder.dart

@@ -258,7 +258,6 @@ class BuildRunnerDaemonBuilder implements DaemonBuilder {
     var buildOptions = await BuildOptions.create(
       packageGraph: packageGraph,
       reader: daemonEnvironment.reader,
-      deleteFilesByDefault: daemonOptions.deleteFilesByDefault,
       overrideBuildConfig: overrideBuildConfig,
       skipBuildScriptCheck: daemonOptions.skipBuildScriptCheck,
       enableLowResourcesMode: daemonOptions.enableLowResourcesMode,

build_runner/lib/src/entrypoint/base_command.dart

@@ -28,18 +28,12 @@ abstract class BuildRunnerCommand extends Command<int> {
 
   void _addBaseFlags(bool symlinksDefault) {
     argParser
+      // No longer does anything, but accept so old usage does not fail.
       ..addFlag(
         deleteFilesByDefaultOption,
-        help:
-            'By default, the user will be prompted to delete any files which '
-            'already exist but were not known to be generated by this '
-            'specific build script.\n\n'
-            'Enabling this option skips the prompt and deletes the files. '
-            'This should typically be used in continues integration servers '
-            'and tests, but not otherwise.',
+        hide: true,
         abbr: 'd',
         negatable: false,
-        defaultsTo: false,
       )
       ..addFlag(
         lowResourcesModeOption,

build_runner/lib/src/entrypoint/build.dart

@@ -44,7 +44,6 @@ class BuildCommand extends BuildRunnerCommand {
     var result = await build(
       builderApplications,
       buildFilters: options.buildFilters,
-      deleteFilesByDefault: options.deleteFilesByDefault,
       enableLowResourcesMode: options.enableLowResourcesMode,
       configKey: options.configKey,
       buildDirs: options.buildDirs,

build_runner/lib/src/entrypoint/options.dart

@@ -46,12 +46,6 @@ class SharedOptions {
   /// unless they are an input to something matching a filter.
   final Set<BuildFilter> buildFilters;
 
-  /// By default, the user will be prompted to delete any files which already
-  /// exist but were not generated by this specific build script.
-  ///
-  /// This option can be set to `true` to skip this prompt.
-  final bool deleteFilesByDefault;
-
   final bool enableLowResourcesMode;
 
   /// Read `build.$configKey.yaml` instead of `build.yaml`.
@@ -88,7 +82,6 @@ class SharedOptions {
 
   SharedOptions._({
     required this.buildFilters,
-    required this.deleteFilesByDefault,
     required this.enableLowResourcesMode,
     required this.configKey,
     required this.buildDirs,
@@ -109,7 +102,6 @@ class SharedOptions {
     Command command,
   ) : this._(
         buildFilters: _parseBuildFilters(argResults, rootPackage),
-        deleteFilesByDefault: argResults[deleteFilesByDefaultOption] as bool,
         enableLowResourcesMode: argResults[lowResourcesModeOption] as bool,
         configKey: argResults[configOption] as String?,
         buildDirs: {
@@ -139,7 +131,6 @@ class DaemonOptions extends WatchOptions {
     required super.buildFilters,
     required this.buildMode,
     required this.logRequests,
-    required super.deleteFilesByDefault,
     required super.enableLowResourcesMode,
     required super.configKey,
     required super.buildDirs,
@@ -183,7 +174,6 @@ class DaemonOptions extends WatchOptions {
       buildFilters: buildFilters,
       buildMode: buildMode,
       logRequests: argResults[logRequestsOption] as bool,
-      deleteFilesByDefault: argResults[deleteFilesByDefaultOption] as bool,
       enableLowResourcesMode: argResults[lowResourcesModeOption] as bool,
       configKey: argResults[configOption] as String?,
       buildDirs: buildDirs,
@@ -214,7 +204,6 @@ class WatchOptions extends SharedOptions {
   WatchOptions._({
     required this.usePollingWatcher,
     required super.buildFilters,
-    required super.deleteFilesByDefault,
     required super.enableLowResourcesMode,
     required super.configKey,
     required super.buildDirs,
@@ -235,7 +224,6 @@ class WatchOptions extends SharedOptions {
     Command command,
   ) : this._(
         buildFilters: _parseBuildFilters(argResults, rootPackage),
-        deleteFilesByDefault: argResults[deleteFilesByDefaultOption] as bool,
         enableLowResourcesMode: argResults[lowResourcesModeOption] as bool,
         configKey: argResults[configOption] as String?,
         buildDirs: {
@@ -270,7 +258,6 @@ class ServeOptions extends WatchOptions {
     required this.logRequests,
     required this.serveTargets,
     required super.buildFilters,
-    required super.deleteFilesByDefault,
     required super.enableLowResourcesMode,
     required super.configKey,
     required super.buildDirs,
@@ -349,7 +336,6 @@ class ServeOptions extends WatchOptions {
       buildUpdates: buildUpdates,
       logRequests: argResults[logRequestsOption] as bool,
       serveTargets: serveTargets,
-      deleteFilesByDefault: argResults[deleteFilesByDefaultOption] as bool,
       enableLowResourcesMode: argResults[lowResourcesModeOption] as bool,
       configKey: argResults[configOption] as String?,
       buildDirs: buildDirs,