move shared analysis to subdir, enable dart_flutter_team_lints (#3497)

* Adds a new `analysis` package, with the shared analysis_options.yaml file
* Add an analysis_options.yaml file that imports that one to each package
* Use the dart_flutter_team_lints package for lints
* Fix up all the new lint violations

Author: jakemac53

.github/workflows/dart.yml

@@ -0,0 +1 @@
+include: ../analysis/analysis_options.yaml

_test/analysis_options.yaml

@@ -9,11 +9,11 @@ dev_dependencies:
   build: any
   build_config: any
   build_modules: any
-  build_web_compilers: any
   build_runner: any
   build_runner_core: any
   build_test: any
-  lints: '>=1.0.0 <3.0.0'
+  build_web_compilers: any
+  dart_flutter_team_lints: ^1.0.0
   io: ^1.0.0
   path: ^1.8.0
   provides_builder:

_test/pubspec.yaml

@@ -91,8 +91,8 @@ void main() {
     });
 
     test(
-        'Restores previously deleted outputs if they are not deleted in subsequent builds',
-        () async {
+        'Restores previously deleted outputs if they are not deleted in '
+        'subsequent builds', () async {
       final dartSource =
           File(p.join('build', 'web', 'packages', '_test', 'app.dart'));
       await runBuild(trailingArgs: [
@@ -112,11 +112,12 @@ void main() {
 
       var nextBuild = await runBuild();
       expect(
-          nextBuild.stdout.split('\n'),
+          (nextBuild.stdout as String).split('\n'),
           containsAllInOrder([
             contains('Generating build script'),
             contains(
-                'Invalidated precompiled build script due to missing asset graph.'),
+                'Invalidated precompiled build script due to missing asset '
+                'graph.'),
             contains('Precompiling build script'),
             contains('Building new asset graph.'),
             contains('Succeeded after'),

_test/test/build_integration_test.dart

@@ -0,0 +1 @@
+include: ../analysis/analysis_options.yaml

_test_common/analysis_options.yaml

@@ -34,7 +34,8 @@ Future<d.FileDescriptor> pubspec(
     ..writeln('  sdk: "$sdkEnvironment"')
     ..writeln('dependencies:');
 
-  // Add all deps as `any` deps, real versions are set in dependency_overrides below.
+  // Add all deps as `any` deps, real versions are set in dependency_overrides
+  // below.
   var allPackages = [
     ...currentIsolateDependencies,
     ...pathDependencies.keys,

_test_common/lib/descriptors.dart

@@ -196,10 +196,13 @@ class _AssetGraphMatcher extends Matcher {
       description.addDescriptionOf(_expected);
 
   @override
-  Description describeMismatch(
-      item, Description mismatchDescription, Map matchState, bool verbose) {
-    matchState.forEach((k, v) =>
-        mismatchDescription.add('$k: got ${v[0]} but expected ${v[1]}'));
+  Description describeMismatch(dynamic item, Description mismatchDescription,
+      Map matchState, bool verbose) {
+    matchState.forEach((k, v) {
+      v = v as List;
+      mismatchDescription.add('$k: got ${v[0]} but expected ${v[1]}');
+    });
+
     return mismatchDescription;
   }
 }

_test_common/lib/matchers.dart

@@ -20,7 +20,7 @@ dependencies:
   watcher: ^1.0.0
 
 dev_dependencies:
-  lints: '>=1.0.0 <3.0.0'
+  dart_flutter_team_lints: ^1.0.0
 
 dependency_overrides:
   build:

_test_common/pubspec.yaml

@@ -0,0 +1,23 @@
+include: package:dart_flutter_team_lints/analysis_options.yaml
+analyzer:
+  language:
+    strict-casts: true
+  errors:
+    unused_import: error
+    unused_local_variable: error
+    dead_code: error
+    todo: ignore
+    deprecated_member_use_from_same_package: ignore
+  exclude:
+    # Prevents extra work during some e2e test runs.
+    - "dart2js_test/**"
+    # Common top level directories containing generated files in any package.
+    - "build/**"
+    - ".dart_tool/**"
+
+linter:
+  rules:
+    # TODO: Remove this once we can use unnamed libraries.
+    library_annotations: false
+    # TODO: https://github.com/google/json_serializable.dart/issues/1313
+    use_string_in_part_of_directives: false

analysis/analysis_options.yaml

@@ -5,4 +5,4 @@ publish_to: none
 environment:
   sdk: ">=2.12.0 <4.0.0"
 dev_dependencies:
-  lints: ^2.0.0
+  dart_flutter_team_lints: any