lots of lints

Author: kevmoo

.analysis_options

@@ -1,2 +1,27 @@
 analyzer:
  strong-mode: true
+linter:
+  rules:
+    - always_declare_return_types
+    - annotate_overrides
+    - avoid_empty_else
+    - avoid_init_to_null
+    - avoid_return_types_on_setters
+    - camel_case_types
+    # - constant_identifier_names # https://github.com/dart-lang/build/issues/94
+    - empty_constructor_bodies
+    - hash_and_equals
+    - library_names
+    - library_prefixes
+    - non_constant_identifier_names
+    - package_api_docs
+    - package_names
+    - package_prefixed_library_names
+    - prefer_is_not_empty
+    - slash_for_doc_comments
+    - sort_unnamed_constructors_first
+    - super_goes_last
+    - type_annotate_public_apis
+    - type_init_formals
+    - unnecessary_brace_in_string_interp
+    - unnecessary_getters_setters

lib/src/asset/asset.dart

@@ -13,5 +13,6 @@ class Asset {
 
   Asset(this.id, this.stringContents);
 
+  @override
   String toString() => 'Asset: $id';
 }

lib/src/asset/file_based.dart

@@ -20,7 +20,7 @@ import 'exceptions.dart';
 /// files from disk.
 class FileBasedAssetReader implements AssetReader {
   final PackageGraph packageGraph;
-  final ignoredDirs;
+  final List<String> ignoredDirs;
 
   FileBasedAssetReader(this.packageGraph,
       {this.ignoredDirs: const ['build', 'packages', '.pub']});
@@ -40,6 +40,7 @@ class FileBasedAssetReader implements AssetReader {
   }
 
   /// Searches for all [AssetId]s matching [inputSet]s.
+  @override
   Stream<AssetId> listAssetIds(Iterable<InputSet> inputSets) async* {
     var seenAssets = new Set<AssetId>();
     for (var inputSet in inputSets) {
@@ -57,6 +58,7 @@ class FileBasedAssetReader implements AssetReader {
     }
   }
 
+  @override
   Future<DateTime> lastModified(AssetId id) async {
     var file = await _fileFor(id, packageGraph);
     if (!await file.exists()) {
@@ -92,7 +94,7 @@ class FileBasedAssetWriter implements AssetWriter {
   }
 
   @override
-  delete(AssetId id) async {
+  Future delete(AssetId id) async {
     assert(id.package == packageGraph.root.name);
 
     var file = _fileFor(id, packageGraph);

lib/src/asset/id.dart

@@ -65,11 +65,14 @@ class AssetId implements Comparable<AssetId> {
         path = data[1];
 
   /// Returns `true` of [other] is an [AssetId] with the same package and path.
-  operator ==(other) =>
+  @override
+  bool operator ==(Object other) =>
       other is AssetId && package == other.package && path == other.path;
 
+  @override
   int get hashCode => package.hashCode ^ path.hashCode;
 
+  @override
   int compareTo(AssetId other) {
     var packageComp = package.compareTo(other.package);
     if (packageComp != 0) return packageComp;
@@ -86,11 +89,12 @@ class AssetId implements Comparable<AssetId> {
   AssetId changeExtension(String newExtension) =>
       new AssetId(package, pathos.withoutExtension(path) + newExtension);
 
+  @override
   String toString() => "$package|$path";
 
   /// Serializes this [AssetId] to an object that can be sent across isolates
   /// and passed to [deserialize].
-  serialize() => [package, path];
+  Object serialize() => [package, path];
 }
 
 String _normalizePath(String path) {

lib/src/asset_graph/graph.dart

@@ -77,5 +77,5 @@ class AssetGraph {
   Iterable<AssetNode> get allNodes => _nodesById.values;
 
   @override
-  toString() => 'validAsOf: $validAsOf\n${_nodesById.values.toList()}';
+  String toString() => 'validAsOf: $validAsOf\n${_nodesById.values.toList()}';
 }

lib/src/asset_graph/node.dart

@@ -11,7 +11,7 @@ class AssetNode {
   final AssetId id;
 
   /// The [AssetId]s of all generated assets which depend on this node.
-  final outputs = new Set<AssetId>();
+  final Set<AssetId> outputs = new Set<AssetId>();
 
   AssetNode(this.id);
 
@@ -66,5 +66,6 @@ class GeneratedAssetNode extends AssetNode {
       super.serialize()..addAll([primaryInput.serialize(), wasOutput]);
 
   @override
-  toString() => 'GeneratedAssetNode: $id generated from input $primaryInput.';
+  String toString() =>
+      'GeneratedAssetNode: $id generated from input $primaryInput.';
 }

lib/src/builder/build_step_impl.dart

@@ -35,6 +35,7 @@ class BuildStepImpl implements BuildStep {
   final List<AssetId> expectedOutputs;
 
   /// The [Logger] for this [BuildStep].
+  @override
   Logger get logger {
     _logger ??= new Logger(input.id.toString());
     return _logger;
@@ -71,6 +72,7 @@ class BuildStepImpl implements BuildStep {
   }
 
   /// Checks if an [Asset] by [id] exists as an input for this [BuildStep].
+  @override
   Future<bool> hasInput(AssetId id) {
     _checkInput(id);
     _dependencies.add(id);

lib/src/generate/build_impl.dart

@@ -172,6 +172,7 @@ class BuildImpl {
       }
       var exceptionString =
           result.exception != null ? '\n${result.exception}' : '';
+
       /// For a [FatalBuildException], the message is more important than the
       /// stack trace so we hide it (at least for now).
       var stackTraceString =

lib/src/generate/build_result.dart

@@ -31,16 +31,16 @@ class BuildResult {
       return '''
 
 Build Succeeded!
-Type: ${buildType}
+Type: $buildType
 ''';
     } else {
       return '''
 
 Build Failed :(
-Type: ${buildType}
-Exception: ${exception}
+Type: $buildType
+Exception: $exception
 Stack Trace:
-${stackTrace}
+$stackTrace
 ''';
     }
   }

lib/src/generate/input_set.dart

@@ -20,6 +20,7 @@ class InputSet {
       : this.globs =
             new List.unmodifiable(globs.map((pattern) => new Glob(pattern)));
 
+  @override
   String toString() {
     var buffer = new StringBuffer()
       ..write('InputSet: package `$package` with globs');