move .build to .dart_tool/build

Author: jakemac53

.gitignore

@@ -4,8 +4,8 @@ build/
 .pub/
 pubspec.lock
 
-# Files generated by build runs
-.build
+# Files generated by dart tools
+.dart_tool
 
 # Generated by tool/create_all_test.dart
 tool/test_all.dart

README.md

@@ -103,9 +103,9 @@ Outputs from previous builds will not be treated as inputs to later ones.
 
 ### Source control
 
-This package creates a top level `.build` folder in your package, which should
-not be submitted to your source control repo (likely this just means adding
-'.build' to your '.gitignore' file).
+This package creates a top level `.dart_tool` folder in your package, which
+should not be submitted to your source control repo (likely this just means
+adding '.dart_tool' to your '.gitignore' file).
 
 When it comes to generated files it is generally best to not submit them to
 source control, but a specific `Builder` may provide a recommendation otherwise.

lib/src/generate/build_impl.dart

@@ -168,7 +168,7 @@ class BuildImpl {
 
   /// Asset containing previous asset dependency graph.
   AssetId get _assetGraphId =>
-      new AssetId(_packageGraph.root.name, '.build/asset_graph.json');
+      new AssetId(_packageGraph.root.name, '.dart_tool/build/asset_graph.json');
 
   /// Reads in the [assetGraph] from disk.
   Future<AssetGraph> _readAssetGraph() async {
@@ -359,9 +359,9 @@ class BuildImpl {
     if (conflictingOutputs.isEmpty) return;
 
     stdout.writeln('\n\nFound ${conflictingOutputs.length} declared outputs '
-        'which already exist on disk. This is likely because the `.build` '
-        'folder was deleted, or you are submitting generated files to your '
-        'source repository.');
+        'which already exist on disk. This is likely because the'
+        '`.dart_tool/build` folder was deleted, or you are submitting generated '
+        'files to your source repository.');
     var done = false;
     while (!done) {
       stdout.write('\nDelete these files (y/n) (or list them (l))?: ');

lib/src/generate/watch_impl.dart

@@ -228,7 +228,7 @@ class WatchImpl {
 
   /// Checks if we should skip a watch event for this [id].
   bool _shouldSkipInput(AssetId id, ChangeType type) {
-    if (id.path.contains('.build/')) return true;
+    if (id.path.contains('.dart_tool/build/')) return true;
     var node = _assetGraph.get(id);
     return node is GeneratedAssetNode && type != ChangeType.REMOVE;
   }

test/common/common.dart

@@ -24,6 +24,8 @@ export 'matchers.dart';
 export 'stub_reader.dart';
 export 'stub_writer.dart';
 
+final String assetGraphPath = '.dart_tool/build/asset_graph.json';
+
 Future wait(int milliseconds) =>
     new Future.delayed(new Duration(milliseconds: milliseconds));
 

test/generate/build_test.dart

@@ -140,7 +140,8 @@ main() {
           {
             'a|lib/a.txt': 'a',
             'a|lib/a.txt.copy': 'a',
-            'a|.build/asset_graph.json': JSON.encode(emptyGraph.serialize()),
+            'a|$assetGraphPath':
+                JSON.encode(emptyGraph.serialize()),
           },
           status: BuildStatus.Failure,
           exceptionMatcher: invalidOutputException);
@@ -153,7 +154,7 @@ main() {
         outputs: {'a|web/a.txt.copy': 'a', 'a|lib/b.txt.copy': 'b'},
         writer: writer);
 
-    var graphId = makeAssetId('a|.build/asset_graph.json');
+    var graphId = makeAssetId('a|$assetGraphPath');
     expect(writer.assets, contains(graphId));
     var cachedGraph =
         new AssetGraph.deserialize(JSON.decode(writer.assets[graphId].value));
@@ -194,7 +195,7 @@ main() {
     await testPhases(copyAPhaseGroup, inputs, outputs: outputs, writer: writer);
 
     // Delete the `asset_graph.json` file!
-    var outputId = makeAssetId('a|.build/asset_graph.json');
+    var outputId = makeAssetId('a|$assetGraphPath');
     await writer.delete(outputId);
 
     // Second run, should have no extra outputs.
@@ -223,7 +224,7 @@ main() {
         'a|web/a.txt': 'a',
         'a|lib/b.txt.copy': 'b',
         'a|lib/c.txt': 'c',
-        'a|.build/asset_graph.json': JSON.encode(graph.serialize()),
+        'a|$assetGraphPath': JSON.encode(graph.serialize()),
       }, outputs: {
         'a|web/a.txt.copy': 'a',
         'a|lib/c.txt.copy': 'c',
@@ -268,7 +269,8 @@ main() {
             'a|lib/a.txt.copy.clone': 'a',
             'a|lib/b.txt.copy': 'b',
             'a|lib/b.txt.copy.clone': 'b',
-            'a|.build/asset_graph.json': JSON.encode(graph.serialize()),
+            'a|$assetGraphPath':
+                JSON.encode(graph.serialize()),
           },
           outputs: {'a|lib/a.txt.copy': 'b', 'a|lib/a.txt.copy.clone': 'b',},
           writer: writer);
@@ -297,14 +299,15 @@ main() {
           {
             'a|lib/a.txt.copy': 'a',
             'a|lib/a.txt.copy.clone': 'a',
-            'a|.build/asset_graph.json': JSON.encode(graph.serialize()),
+            'a|$assetGraphPath':
+                JSON.encode(graph.serialize()),
           },
           outputs: {},
           writer: writer);
 
       /// Should be deleted using the writer, and removed from the new graph.
-      var newGraph = new AssetGraph.deserialize(JSON.decode(
-          writer.assets[makeAssetId('a|.build/asset_graph.json')].value));
+      var newGraph = new AssetGraph.deserialize(JSON.decode(writer
+          .assets[makeAssetId('a|$assetGraphPath')].value));
       expect(newGraph.contains(aNode.id), isFalse);
       expect(newGraph.contains(aCopyNode.id), isFalse);
       expect(newGraph.contains(aCloneNode.id), isFalse);
@@ -331,7 +334,7 @@ main() {
       await testPhases(copyAPhaseGroup, {
         'a|web/a.txt': 'a',
         'a|web/a.txt.copy': 'a',
-        'a|.build/asset_graph.json': JSON.encode(graph.serialize()),
+        'a|$assetGraphPath': JSON.encode(graph.serialize()),
       }, outputs: {
         'a|web/a.txt.copy': 'a',
       });

test/generate/watch_test.dart

@@ -114,8 +114,8 @@ main() {
         result = await nextResult(results);
         checkOutputs({'a|web/c.txt.copy': 'c'}, result, writer.assets);
 
-        var cachedGraph = new AssetGraph.deserialize(JSON.decode(
-            writer.assets[makeAssetId('a|.build/asset_graph.json')].value));
+        var cachedGraph = new AssetGraph.deserialize(JSON.decode(writer
+            .assets[makeAssetId('a|$assetGraphPath')].value));
 
         var expectedGraph = new AssetGraph();
         var bCopyNode = makeAssetNode('a|web/b.txt.copy');