Fix missing resolved import handling. (#4065)

Author: davidmorgan

build/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 2.5.4
+
+- Use `build_runner_core` 9.1.2.
+
 ## 2.5.3
 
 - Use `build_runner_core` 9.1.1.

build/pubspec.yaml

@@ -1,5 +1,5 @@
 name: build
-version: 2.5.3
+version: 2.5.4
 description: A package for authoring build_runner compatible code generators.
 repository: https://github.com/dart-lang/build/tree/master/build
 resolution: workspace
@@ -10,7 +10,7 @@ environment:
 dependencies:
   analyzer: '>=6.9.0 <8.0.0'
   async: ^2.5.0
-  build_runner_core: '9.1.1'
+  build_runner_core: '9.1.2'
   built_collection: ^5.1.1
   built_value: ^8.9.5
   convert: ^3.0.0
@@ -24,7 +24,7 @@ dependencies:
   pool: ^1.5.0
 
 dev_dependencies:
-  build_resolvers: '2.5.3'
+  build_resolvers: '2.5.4'
   build_test: ^3.1.0
   built_value_generator: ^8.9.5
   dart_flutter_team_lints: ^3.1.0

build_resolvers/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 2.5.4
+
+- Use `build_runner_core` 9.1.2.
+
 ## 2.5.3
 
 - Use `build_runner_core` 9.1.1.

build_resolvers/pubspec.yaml

@@ -1,5 +1,5 @@
 name: build_resolvers
-version: 2.5.3
+version: 2.5.4
 description: Resolve Dart code in a Builder
 repository: https://github.com/dart-lang/build/tree/master/build_resolvers
 resolution: workspace
@@ -10,8 +10,8 @@ environment:
 dependencies:
   analyzer: '>=6.9.0 <8.0.0'
   async: ^2.5.0
-  build: '2.5.3'
-  build_runner_core: '9.1.1'
+  build: '2.5.4'
+  build_runner_core: '9.1.2'
   collection: ^1.17.0
   convert: ^3.1.1
   crypto: ^3.0.0

build_runner/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 2.5.4
+
+- Bug fix: fix incremental build when previous build had `package:` import of
+  a missing dep or a missing file.
+
 ## 2.5.3
 
 - Bug fix: fix corner case with checked in generated output that could cause

build_runner/pubspec.yaml

@@ -1,5 +1,5 @@
 name: build_runner
-version: 2.5.3
+version: 2.5.4
 description: A build system for Dart code generation and modular compilation.
 repository: https://github.com/dart-lang/build/tree/master/build_runner
 resolution: workspace
@@ -16,11 +16,11 @@ dependencies:
   analyzer: '>=4.4.0 <8.0.0'
   args: ^2.0.0
   async: ^2.5.0
-  build: '2.5.3'
+  build: '2.5.4'
   build_config: ">=1.1.0 <1.2.0"
   build_daemon: ^4.0.0
-  build_resolvers: '2.5.3'
-  build_runner_core: '9.1.1'
+  build_resolvers: '2.5.4'
+  build_runner_core: '9.1.2'
   code_builder: ^4.2.0
   collection: ^1.15.0
   crypto: ^3.0.0

build_runner_core/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 9.1.2
+
+- Bug fix: fix incremental build when previous build had `package:` import of
+  a missing dep or a missing file.
+
 ## 9.1.1
 
 - Bug fix: fix corner case with checked in generated output that could cause

build_runner_core/lib/src/generate/single_step_reader_writer.dart

@@ -451,6 +451,8 @@ class SingleStepReaderWriter extends AssetReader
 
     var node = _runningBuild.assetGraph.get(id);
     if (node == null) {
+      // Add to the graph for input tracking.
+      _runningBuild.assetGraph.add(AssetNode.missingSource(id));
       return PhasedValue.fixed('');
     }
 

build_runner_core/pubspec.yaml

@@ -1,5 +1,5 @@
 name: build_runner_core
-version: 9.1.1
+version: 9.1.2
 description: Core tools to organize the structure of a build and run Builders.
 repository: https://github.com/dart-lang/build/tree/master/build_runner_core
 resolution: workspace
@@ -15,10 +15,10 @@ platforms:
 dependencies:
   analyzer: '>=6.9.0 <8.0.0'
   async: ^2.5.0
-  build: '2.5.3'
+  build: '2.5.4'
   build_config: ^1.0.0
-  build_resolvers: '2.5.3'
-  build_runner: '2.5.3'
+  build_resolvers: '2.5.4'
+  build_runner: '2.5.4'
   built_collection: ^5.1.1
   built_value: ^8.10.1
   collection: ^1.15.0

build_runner_core/test/invalidation/resolved_input_invalidation_test.dart

@@ -557,4 +557,26 @@ void main() {
       );
     });
   });
+
+  group('a.1 <== a.2, a.2 resolves: a.1 -> missing', () {
+    setUp(() {
+      tester.sources(['a.1', 'b']);
+      tester.importGraph({
+        'a.1': ['package:missing/missing'],
+      });
+      tester.builder(from: '.1', to: '.2')
+        ..reads('.1')
+        ..resolvesOther('a.1')
+        ..writes('.2');
+    });
+
+    test('a.2 is built', () async {
+      expect(await tester.build(), Result(written: ['a.2']));
+    });
+
+    test('no-op rebuild succeeds', () async {
+      await tester.build();
+      expect(await tester.build(), Result());
+    });
+  });
 }