Simplify outdated analyzer warnings. Use buildLog instead of log. (#4050)

Author: davidmorgan

build_resolvers/CHANGELOG.md

@@ -1,5 +1,7 @@
 ## 2.5.2-wip
 
+- Simplify warnings for outdated `analyzer`.
+
 ## 2.5.1
 
 - Use `build_runner_core` 2.5.1.

build_resolvers/lib/src/resolver.dart

@@ -6,8 +6,6 @@
 
 import 'dart:async';
 import 'dart:collection';
-import 'dart:convert';
-import 'dart:io';
 import 'dart:isolate';
 
 import 'package:analyzer/dart/analysis/features.dart';
@@ -26,7 +24,6 @@ import 'package:collection/collection.dart' show IterableExtension;
 import 'package:package_config/package_config.dart';
 import 'package:path/path.dart' as p;
 import 'package:pool/pool.dart';
-import 'package:yaml/yaml.dart';
 
 import 'analysis_driver.dart';
 import 'analysis_driver_filesystem.dart';
@@ -553,84 +550,21 @@ class AnalyzerResolvers implements Resolvers {
 void _warnOnLanguageVersionMismatch() async {
   if (sdkLanguageVersion <= ExperimentStatus.currentVersion) return;
 
-  HttpClient? client;
-  try {
-    client = HttpClient();
-    var request = await client.getUrl(
-      Uri.https('pub.dartlang.org', 'api/packages/analyzer'),
-    );
-    var response = await request.close();
-    var content = StringBuffer();
-    await response
-        .transform(utf8.decoder)
-        .listen(content.write)
-        .asFuture<void>();
-    var json = jsonDecode(content.toString()) as Map<String, Object?>;
-    var latestAnalyzer = (json['latest'] as Map<String, Object?>)['version'];
-    var analyzerPubspecPath = p.join(
-      await packagePath('analyzer'),
-      'pubspec.yaml',
-    );
-    var currentAnalyzer =
-        (loadYaml(await File(analyzerPubspecPath).readAsString())
-            as YamlMap)['version'];
-
-    if (latestAnalyzer == currentAnalyzer) {
-      log.warning('''
-The latest `analyzer` version may not fully support your current SDK version.
-
-Analyzer language version: ${ExperimentStatus.currentVersion}
-SDK language version: $sdkLanguageVersion
-
-Check for an open issue at:
-https://github.com/dart-lang/sdk/issues?q=is%3Aissue+is%3Aopen+No+published+analyzer+$sdkLanguageVersion
-and thumbs up and/or subscribe to the existing issue, or file a new issue at
-https://github.com/dart-lang/sdk/issues/new with the title
-"No published analyzer available for language version $sdkLanguageVersion".
-    ''');
-    } else {
-      var upgradeCommand =
-          isFlutter ? 'flutter packages upgrade' : 'dart pub upgrade';
-      log.warning('''
-Your current `analyzer` version may not fully support your current SDK version.
-
-Analyzer language version: ${ExperimentStatus.currentVersion}
-SDK language version: $sdkLanguageVersion
-
-Please update to the latest `analyzer` version ($latestAnalyzer) by running
-`$upgradeCommand`.
-
-If you are not getting the latest version by running the above command, you
-can try adding a constraint like the following to your pubspec to start
-diagnosing why you can't get the latest version:
-
-dev_dependencies:
-  analyzer: ^$latestAnalyzer
-''');
-    }
-  } catch (_) {
-    // Fall back on a basic message if we fail to detect the latest version for
-    // any reason.
-    log.warning('''
-Your current `analyzer` version may not fully support your current SDK version.
-
-Analyzer language version: ${ExperimentStatus.currentVersion}
-SDK language version: $sdkLanguageVersion
-
-Please ensure you are on the latest `analyzer` version, which can be seen at
-https://pub.dev/packages/analyzer.
-''');
-  } finally {
-    client?.close();
-  }
+  final upgradeCommand =
+      isFlutter ? 'flutter packages upgrade' : 'dart pub upgrade';
+  buildLog.warning(
+    'SDK language version $sdkLanguageVersion is newer than `analyzer` '
+    'language version ${ExperimentStatus.currentVersion}. '
+    'Run `$upgradeCommand`.',
+  );
 }
 
 /// The current feature set based on the current sdk version and enabled
 /// experiments.
 FeatureSet _featureSet({List<String> enableExperiments = const []}) {
   if (enableExperiments.isNotEmpty &&
       sdkLanguageVersion > ExperimentStatus.currentVersion) {
-    log.warning('''
+    buildLog.warning('''
 Attempting to enable experiments `$enableExperiments`, but the current SDK
 language version does not match your `analyzer` package language version:
 

build_resolvers/pubspec.yaml

@@ -22,7 +22,6 @@ dependencies:
   pool: ^1.5.0
   pub_semver: ^2.0.0
   stream_transform: ^2.0.0
-  yaml: ^3.0.0
 
 dev_dependencies:
   build_test: ^3.0.0

build_runner/CHANGELOG.md

@@ -1,5 +1,7 @@
 ## 2.5.2-wip
 
+- Simplify warnings for outdated `analyzer`.
+
 ## 2.5.1
 
 - Don't log stack traces for subclasses of `Exception`.

build_runner_core/lib/src/generate/build_definition.dart

@@ -157,7 +157,7 @@ class _Loader {
               .where(inputSources.contains)
               .toSet();
       if (conflictsInDeps.isNotEmpty) {
-        log.severe(
+        buildLog.error(
           'There are existing files in dependencies which conflict '
           'with files that a Builder may produce. These must be removed or '
           'the Builders disabled before a build can continue: '

build_runner_core/lib/src/package_graph/target_graph.dart

@@ -10,6 +10,7 @@ import 'package:glob/glob.dart';
 
 import '../generate/input_matcher.dart';
 import '../generate/options.dart' show defaultNonRootVisibleAssets;
+import '../logging/build_log.dart';
 import 'package_graph.dart';
 
 /// Like a [PackageGraph] but packages are further broken down into modules
@@ -105,7 +106,7 @@ class TargetGraph {
         );
         var missing = _missingSources(nodes, requiredIds);
         if (missing.isNotEmpty) {
-          log.warning(
+          buildLog.warning(
             'The package `${package.name}` does not include some required '
             'sources in any of its targets (see their build.yaml file).\n'
             'The missing sources are:\n'