Use lints prefer_final_locals, prefer_final_in_for_each. (#4191)

Author: davidmorgan

_benchmark/lib/config.dart

@@ -36,7 +36,7 @@ class Config {
     allowFailures: argResults['allow-failures'] as bool,
     buildRepoPath: argResults['build-repo-path'] as String?,
     dependencyOverridePaths: {
-      for (var s in argResults['dependency-override-path'] as List<String>)
+      for (final s in argResults['dependency-override-path'] as List<String>)
         s.split('=')[0]: s.split('=')[1],
     },
     generator: Generator.values.singleWhere(

_test/lib/app.dart

@@ -7,6 +7,6 @@ import 'package:web/web.dart';
 void startApp({String? text}) {
   text ??= 'Hello World!';
   // ignore: deprecated_member_use
-  var component = HTMLDivElement()..text = text;
+  final component = HTMLDivElement()..text = text;
   document.body!.append(component);
 }

_test/pkgs/provides_builder/lib/builders.dart

@@ -49,7 +49,7 @@ class _SomePostProcessBuilder extends PostProcessBuilder {
 
   @override
   Future<void> build(PostProcessBuildStep buildStep) async {
-    var content = defaultContent ?? await buildStep.readInputAsString();
+    final content = defaultContent ?? await buildStep.readInputAsString();
     await buildStep.writeAsString(
       buildStep.inputId.changeExtension('.txt.post'),
       content,

_test/test/build_integration_test.dart

@@ -22,30 +22,30 @@ void main() {
 
   group('PostProcessBuilder', () {
     test('creates expected outputs', () async {
-      var generated = await readGeneratedFileAsString(
+      final generated = await readGeneratedFileAsString(
         '_test/lib/hello.txt.post',
       );
-      var original = await File('lib/hello.txt').readAsString();
+      final original = await File('lib/hello.txt').readAsString();
       expect(generated, equals(original));
     });
 
     test('can be configured with build.yaml', () async {
       await runBuild(trailingArgs: ['--config', 'post_process']);
-      var generated = await readGeneratedFileAsString(
+      final generated = await readGeneratedFileAsString(
         '_test/lib/hello.txt.post',
       );
       expect(generated, equals('goodbye'));
     });
 
     test('can be configured with --define', () async {
-      var content = 'cool';
+      final content = 'cool';
       await runBuild(
         trailingArgs: [
           '--define',
           'provides_builder:some_post_process_builder=default_content=$content',
         ],
       );
-      var generated = await readGeneratedFileAsString(
+      final generated = await readGeneratedFileAsString(
         '_test/lib/hello.txt.post',
       );
       expect(generated, equals(content));
@@ -57,14 +57,16 @@ void main() {
       await replaceAllInFile('lib/hello.txt', 'hello', 'goodbye');
       result = await runBuild();
       expect(result.stdout, contains('wrote 1 output'));
-      var content = await readGeneratedFileAsString('_test/lib/hello.txt.post');
+      final content = await readGeneratedFileAsString(
+        '_test/lib/hello.txt.post',
+      );
       expect(content, contains('goodbye'));
     });
   });
 
   group('experiments', () {
     test('can serve a single app with experiments enabled', () async {
-      var result = await runBuild(
+      final result = await runBuild(
         trailingArgs: ['--enable-experiment=fake-experiment'],
       );
 
@@ -126,10 +128,10 @@ void main() {
     });
 
     test('Re-snapshots if there is no asset graph', () async {
-      var assetGraph = assetGraphPathFor(scriptKernelLocation);
+      final assetGraph = assetGraphPathFor(scriptKernelLocation);
       await File(assetGraph).delete();
 
-      var nextBuild = await runBuild();
+      final nextBuild = await runBuild();
       expect(
         (nextBuild.stdout as String).split('\n'),
         containsAllInOrder([

_test/test/common/utils.dart

@@ -86,7 +86,7 @@ Future<void> _startServer(
               .transform(const LineSplitter())
               .asBroadcastStream();
 
-  var stdErrLines =
+  final stdErrLines =
       proc.stderr
           .transform(utf8.decoder)
           .transform(const LineSplitter())
@@ -106,7 +106,7 @@ Future<void> stopServer({bool? cleanUp}) async {
   final process = _process;
   if (process != null) {
     expect(process.kill(), true);
-    var exitCode = process.exitCode;
+    final exitCode = process.exitCode;
     _process = null;
     await exitCode;
   }
@@ -120,7 +120,7 @@ Future<void> stopServer({bool? cleanUp}) async {
 /// Checks whether the current git client is "clean" (no pending changes) for
 /// this package directory.
 bool _gitIsClean() {
-  var gitStatus =
+  final gitStatus =
       Process.runSync('git', ['status', '.', '--porcelain']).stdout as String;
   return gitStatus.isEmpty;
 }
@@ -131,7 +131,7 @@ bool _gitIsClean() {
 /// This also calls `addTearDown` with a method that will reset the current git
 /// state for this directory after running the test.
 void ensureCleanGitClient() {
-  var gitWasClean = _gitIsClean();
+  final gitWasClean = _gitIsClean();
   expect(
     gitWasClean,
     isTrue,
@@ -194,7 +194,7 @@ Future<TestProcess> _runTests(
 }) async {
   usePrecompiled ??= true;
   if (usePrecompiled) {
-    var args =
+    final args =
         scriptArgs.toList()
           ..add('test')
           ..add('--verbose')
@@ -203,7 +203,7 @@ Future<TestProcess> _runTests(
           ..addAll([...?testArgs, '-p', 'chrome', '-r', 'expanded']);
     return TestProcess.start(executable, args);
   } else {
-    var args = ['run', 'test', '--pub-serve', '8081', ...?testArgs];
+    final args = ['run', 'test', '--pub-serve', '8081', ...?testArgs];
     return TestProcess.start('dart', args);
   }
 }
@@ -215,7 +215,7 @@ Future<void> expectTestsFail({
 }) async {
   // Skip on Windows due to Chrome test flakiness, see
   // https://github.com/dart-lang/build/issues/4123.
-  var result = await runTests(
+  final result = await runTests(
     usePrecompiled: usePrecompiled,
     buildArgs: buildArgs,
     testArgs: testArgs,
@@ -233,12 +233,12 @@ Future<void> expectTestsPass({
   // Skip on Windows due to Chrome test flakiness, see
   // https://github.com/dart-lang/build/issues/4123.
   if (Platform.isWindows) return;
-  var result = await runTests(
+  final result = await runTests(
     usePrecompiled: usePrecompiled,
     buildArgs: buildArgs,
     testArgs: testArgs,
   );
-  var allLines = await result.stdout.rest.toList();
+  final allLines = await result.stdout.rest.toList();
   expect(allLines, contains(contains('All tests passed!')));
   if (expectedNumRan != null) {
     expect(allLines, contains(contains('+$expectedNumRan')));
@@ -248,27 +248,27 @@ Future<void> expectTestsPass({
 }
 
 Future<void> createFile(String path, String contents) async {
-  var file = File(path);
+  final file = File(path);
   expect(await file.exists(), isFalse);
   await file.create(recursive: true);
   await file.writeAsString(contents);
 }
 
 Future<void> deleteFile(String path) async {
-  var file = File(path);
+  final file = File(path);
   expect(await file.exists(), isTrue);
   await file.delete();
 }
 
 Future<String> readGeneratedFileAsString(String path) async {
-  var file = File(p.join(_generatedDir.path, path));
+  final file = File(p.join(_generatedDir.path, path));
   expect(await file.exists(), isTrue);
   return file.readAsString();
 }
 
 Future<void> replaceAllInFile(String path, Pattern from, String replace) async {
-  var file = File(path);
+  final file = File(path);
   expect(await file.exists(), isTrue);
-  var content = await file.readAsString();
+  final content = await file.readAsString();
   await file.writeAsString(content.replaceAll(from, replace));
 }

_test/test/dart2js_integration_test.dart

@@ -18,7 +18,7 @@ const _outputDir = 'dart2js_test';
 void main() {
   group('Can run tests using dart2js', () {
     tearDown(() async {
-      var dir = Directory(_outputDir);
+      final dir = Directory(_outputDir);
       if (await dir.exists()) {
         await dir.delete(recursive: true);
       }
@@ -81,20 +81,20 @@ void main() {
 }
 
 Future<void> _expectWasCompiledWithDart2JS({bool minified = false}) async {
-  var jsFile = File(
+  final jsFile = File(
     '$_outputDir/test/hello_world_deferred_test.dart.browser_test.dart.js',
   );
   expect(await jsFile.exists(), isTrue);
   // sanity check that it was indeed compiled with dart2js
-  var content = await jsFile.readAsString();
+  final content = await jsFile.readAsString();
   if (minified) {
     expect(content, isNot(startsWith('//')));
     expect(content, contains('typeof dartMainRunner==="function"'));
   } else {
     expect(content, startsWith('// Generated by dart2js'));
   }
 
-  var jsDeferredPartFile = File(
+  final jsDeferredPartFile = File(
     '$_outputDir/test/hello_world_deferred_test.dart.browser_test.dart.js'
     '_1.part.js',
   );

_test/test/exception_handling_test.dart

@@ -11,15 +11,15 @@ import 'common/utils.dart';
 
 void main() {
   test('Exceptions from the isolate are handled properly', () async {
-    var asyncResult = runBuild(trailingArgs: ['--config', 'throws']);
+    final asyncResult = runBuild(trailingArgs: ['--config', 'throws']);
     expect(
       asyncResult,
       completes,
       reason:
           'Wrapper script should not hang if the isolate has an unhandled '
           'error.',
     );
-    var result = await asyncResult;
+    final result = await asyncResult;
     expect(
       result.stdout,
       contains('Throwing on purpose cause you asked for it!'),

_test/test/generated_script_integration_test.dart

@@ -17,9 +17,9 @@ void main() {
   });
 
   test('Generates a build script matching the golden', () {
-    var generatedScript =
+    final generatedScript =
         File('.dart_tool/build/entrypoint/build.dart').readAsStringSync();
-    var expected = File(
+    final expected = File(
       'test/goldens/generated_build_script.dart',
     ).readAsStringSync().replaceAll('\r', '');
     expect(generatedScript, expected);

_test/test/help_test.dart

@@ -63,13 +63,13 @@ void main() {
 }
 
 Future<void> _testHelpCommand(List<String> args, {String? checkContent}) async {
-  var asyncResult = runCommand(args);
+  final asyncResult = runCommand(args);
   expect(
     asyncResult,
     completes,
     reason: 'should not cause the auto build script to hang',
   );
-  var result = await asyncResult;
+  final result = await asyncResult;
   expect(
     result.exitCode,
     equals(0),