Skip to content

Commit 7b45a4f

Browse files
sgrekhovsgrekhov
authored
#3057. Update assertions according to the spec (#3101)
1 parent c65089a commit 7b45a4f

8 files changed

+20
-28
lines changed

‎TypeSystem/flow-analysis/reachability_A08_t01.dart

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,8 @@
1010
/// - Let `true(N) = after(E2)`.
1111
/// - Let `false(N) = unreachable(after(E2))`.
1212
/// - Otherwise, if `equivalentToNull(T1)` and `T2` is non-nullable, or
13-
/// `equivalentToNull(T2)` and `T1` is non-nullable, then:
14-
/// - Let `true(N) = unreachable(after(E2))`.
15-
/// - Let `false(N) = after(E2)`.
13+
/// `equivalentToNull(T2)` and `T1` is non-nullable, then:
14+
/// - Let `after(N) = after(E2)`.
1615
/// - Otherwise, if `stripParens(E1)` is a `null` literal, then:
1716
/// - Let `true(N) = after(E2)`.
1817
/// - Let `false(N) = promoteToNonNull(E2, after(E2))`.

‎TypeSystem/flow-analysis/reachability_A08_t02.dart

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,8 @@
1010
/// - Let `true(N) = after(E2)`.
1111
/// - Let `false(N) = unreachable(after(E2))`.
1212
/// - Otherwise, if `equivalentToNull(T1)` and `T2` is non-nullable, or
13-
/// `equivalentToNull(T2)` and `T1` is non-nullable, then:
14-
/// - Let `true(N) = unreachable(after(E2))`.
15-
/// - Let `false(N) = after(E2)`.
13+
/// `equivalentToNull(T2)` and `T1` is non-nullable, then:
14+
/// - Let `after(N) = after(E2)`.
1615
/// - Otherwise, if `stripParens(E1)` is a `null` literal, then:
1716
/// - Let `true(N) = after(E2)`.
1817
/// - Let `false(N) = promoteToNonNull(E2, after(E2))`.

‎TypeSystem/flow-analysis/reachability_A08_t03.dart

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,8 @@
1010
/// - Let `true(N) = after(E2)`.
1111
/// - Let `false(N) = unreachable(after(E2))`.
1212
/// - Otherwise, if `equivalentToNull(T1)` and `T2` is non-nullable, or
13-
/// `equivalentToNull(T2)` and `T1` is non-nullable, then:
14-
/// - Let `true(N) = unreachable(after(E2))`.
15-
/// - Let `false(N) = after(E2)`.
13+
/// `equivalentToNull(T2)` and `T1` is non-nullable, then:
14+
/// - Let `after(N) = after(E2)`.
1615
/// - Otherwise, if `stripParens(E1)` is a `null` literal, then:
1716
/// - Let `true(N) = after(E2)`.
1817
/// - Let `false(N) = promoteToNonNull(E2, after(E2))`.
@@ -29,7 +28,7 @@
2928
///
3029
/// @description Checks that if `equivalentToNull(T1)` and `T2` is non-nullable,
3130
/// or `equivalentToNull(T2)` and `T1` is non-nullable then
32-
/// `true(N) = unreachable(after(E2))` and `false(N) = after(E2)`.
31+
/// `after(N) = after(E2)`.
3332
/// @author [email protected]
3433
/// @issue 60114
3534

‎TypeSystem/flow-analysis/reachability_A08_t04.dart

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,8 @@
1010
/// - Let `true(N) = after(E2)`.
1111
/// - Let `false(N) = unreachable(after(E2))`.
1212
/// - Otherwise, if `equivalentToNull(T1)` and `T2` is non-nullable, or
13-
/// `equivalentToNull(T2)` and `T1` is non-nullable, then:
14-
/// - Let `true(N) = unreachable(after(E2))`.
15-
/// - Let `false(N) = after(E2)`.
13+
/// `equivalentToNull(T2)` and `T1` is non-nullable, then:
14+
/// - Let `after(N) = after(E2)`.
1615
/// - Otherwise, if `stripParens(E1)` is a `null` literal, then:
1716
/// - Let `true(N) = after(E2)`.
1817
/// - Let `false(N) = promoteToNonNull(E2, after(E2))`.
@@ -28,7 +27,7 @@
2827
/// `null.isEven` in the event of a non-null input).
2928
///
3029
/// @description Checks that if `equivalentToNull(T2)` and `T1` is non-nullable,
31-
/// then `true(N) = unreachable(after(E2))` and `false(N) = after(E2)`.
30+
/// then `after(N) = after(E2)`.
3231
/// @author [email protected]
3332
/// @issue 41981
3433
/// @issue 60114

‎TypeSystem/flow-analysis/reachability_A08_t05.dart

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,8 @@
1010
/// - Let `true(N) = after(E2)`.
1111
/// - Let `false(N) = unreachable(after(E2))`.
1212
/// - Otherwise, if `equivalentToNull(T1)` and `T2` is non-nullable, or
13-
/// `equivalentToNull(T2)` and `T1` is non-nullable, then:
14-
/// - Let `true(N) = unreachable(after(E2))`.
15-
/// - Let `false(N) = after(E2)`.
13+
/// `equivalentToNull(T2)` and `T1` is non-nullable, then:
14+
/// - Let `after(N) = after(E2)`.
1615
/// - Otherwise, if `stripParens(E1)` is a `null` literal, then:
1716
/// - Let `true(N) = after(E2)`.
1817
/// - Let `false(N) = promoteToNonNull(E2, after(E2))`.
@@ -28,7 +27,7 @@
2827
/// `null.isEven` in the event of a non-null input).
2928
///
3029
/// @description Checks that if `equivalentToNull(T1)` and `T2` is non-nullable,
31-
/// then `true(N) = unreachable(after(E2))` and `false(N) = after(E2)`.
30+
/// then `after(N) = after(E2)`.
3231
/// @author [email protected]
3332
/// @issue 41981
3433
/// @issue 60114

‎TypeSystem/flow-analysis/reachability_A08_t06.dart

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,8 @@
1010
/// - Let `true(N) = after(E2)`.
1111
/// - Let `false(N) = unreachable(after(E2))`.
1212
/// - Otherwise, if `equivalentToNull(T1)` and `T2` is non-nullable, or
13-
/// `equivalentToNull(T2)` and `T1` is non-nullable, then:
14-
/// - Let `true(N) = unreachable(after(E2))`.
15-
/// - Let `false(N) = after(E2)`.
13+
/// `equivalentToNull(T2)` and `T1` is non-nullable, then:
14+
/// - Let `after(N) = after(E2)`.
1615
/// - Otherwise, if `stripParens(E1)` is a `null` literal, then:
1716
/// - Let `true(N) = after(E2)`.
1817
/// - Let `false(N) = promoteToNonNull(E2, after(E2))`.
@@ -29,7 +28,7 @@
2928
///
3029
/// @description Checks that if `equivalentToNull(T1)` and `T2` is non-nullable,
3130
/// or `equivalentToNull(T2)` and `T1` is non-nullable then
32-
/// `true(N) = unreachable(after(E2))` and `false(N) = after(E2)`.
31+
/// `after(N) = after(E2)`.
3332
/// @author [email protected]
3433
/// @issue 60114
3534

‎TypeSystem/flow-analysis/reachability_A08_t07.dart

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,8 @@
1010
/// - Let `true(N) = after(E2)`.
1111
/// - Let `false(N) = unreachable(after(E2))`.
1212
/// - Otherwise, if `equivalentToNull(T1)` and `T2` is non-nullable, or
13-
/// `equivalentToNull(T2)` and `T1` is non-nullable, then:
14-
/// - Let `true(N) = unreachable(after(E2))`.
15-
/// - Let `false(N) = after(E2)`.
13+
/// `equivalentToNull(T2)` and `T1` is non-nullable, then:
14+
/// - Let `after(N) = after(E2)`.
1615
/// - Otherwise, if `stripParens(E1)` is a `null` literal, then:
1716
/// - Let `true(N) = after(E2)`.
1817
/// - Let `false(N) = promoteToNonNull(E2, after(E2))`.

‎TypeSystem/flow-analysis/reachability_A08_t08.dart

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,8 @@
1010
/// - Let `true(N) = after(E2)`.
1111
/// - Let `false(N) = unreachable(after(E2))`.
1212
/// - Otherwise, if `equivalentToNull(T1)` and `T2` is non-nullable, or
13-
/// `equivalentToNull(T2)` and `T1` is non-nullable, then:
14-
/// - Let `true(N) = unreachable(after(E2))`.
15-
/// - Let `false(N) = after(E2)`.
13+
/// `equivalentToNull(T2)` and `T1` is non-nullable, then:
14+
/// - Let `after(N) = after(E2)`.
1615
/// - Otherwise, if `stripParens(E1)` is a `null` literal, then:
1716
/// - Let `true(N) = after(E2)`.
1817
/// - Let `false(N) = promoteToNonNull(E2, after(E2))`.

0 commit comments

Comments
 (0)