Fixes #3119. Fix roll failures (#3120)

sgrekhov · web-flow · commit c05c34e6f882 · 2025-03-28T11:21:50.000+01:00
diff --git a/TypeSystem/flow-analysis/reachability_do_while_A02_t02.dart b/TypeSystem/flow-analysis/reachability_do_while_A02_t02.dart
@@ -14,10 +14,14 @@
 /// @author sgrekhov22@gmail.com
 /// @issue 60361
 
-main() {
+test() {
   late int i;
   do {
     break;
   } while ((i = 42) < 0); // Possibly assigned. https://github.com/dart-lang/sdk/issues/42232#issuecomment-690681385
   i; // Not definitely unassigned
 }
+
+main() {
+  print(test);
+}
diff --git a/TypeSystem/flow-analysis/reachability_for_in_A01_t07.dart b/TypeSystem/flow-analysis/reachability_for_in_A01_t07.dart
@@ -18,10 +18,7 @@ test1() {
   if (2 > 1) {
     for (Never n in <dynamic>[i = 42]) {}
   }
-  i; // Definitely unassigned.
-//^
-// [analyzer] unspecified
-// [cfe] unspecified
+  i; // Possibly assigned. See https://github.com/dart-lang/sdk/issues/60394
 }
 
 test2(Never n) {
diff --git a/TypeSystem/flow-analysis/reachability_for_in_A01_t08.dart b/TypeSystem/flow-analysis/reachability_for_in_A01_t08.dart
@@ -20,10 +20,7 @@ test1() {
       i = 42;
     }
   }
-  i; // Definitely unassigned.
-//^
-// [analyzer] unspecified
-// [cfe] unspecified
+  i; // Possibly assigned. See https://github.com/dart-lang/sdk/issues/60394
 }
 
 test2(Never n) {
diff --git a/TypeSystem/flow-analysis/reachability_for_in_A01_t09.dart b/TypeSystem/flow-analysis/reachability_for_in_A01_t09.dart
@@ -19,10 +19,7 @@ test1() {
     for (Never n in <dynamic>[42]) {}
     i = 42;
   }
-  i; // Definitely unassigned.
-//^
-// [analyzer] unspecified
-// [cfe] unspecified
+  i; // Possibly assigned. See https://github.com/dart-lang/sdk/issues/60394
 }
 
 test2(Never n) {
diff --git a/TypeSystem/flow-analysis/reachability_for_in_A01_t10.dart b/TypeSystem/flow-analysis/reachability_for_in_A01_t10.dart
@@ -19,30 +19,21 @@ Never foo() => throw "Never";
 test1() {
   late int i;
   for (i in foo()) {}
-  i; // Definitely unassigned.
-//^
-// [analyzer] unspecified
-// [cfe] unspecified
+  i; // Possibly assigned. See https://github.com/dart-lang/sdk/issues/60395
 }
 
 test2(Never n) {
   late int i;
   for (var j in n) {
     i = 42;
   }
-  i; // Definitely unassigned.
-//^
-// [analyzer] unspecified
-// [cfe] unspecified
+  i; // Possibly assigned.
 }
 
 test3(Never n) {
   late int i;
   for (i in [n]) {}
-  i; // Definitely unassigned.
-//^
-// [analyzer] unspecified
-// [cfe] unspecified
+  i; // Possibly assigned.
 }
 
 main() {

Original file line number	Diff line number	Diff line change
`@@ -18,10 +18,7 @@ test1() {`
`18`	`18`	`if (2 > 1) {`
`19`	`19`	`for (Never n in <dynamic>[i = 42]) {}`
`20`	`20`	`}`
`21`		`- i; // Definitely unassigned.`
`22`		`-//^`
`23`		`-// [analyzer] unspecified`
`24`		`-// [cfe] unspecified`
	`21`	`+ i; // Possibly assigned. See https://github.com/dart-lang/sdk/issues/60394`
`25`	`22`	`}`
`26`	`23`
`27`	`24`	`test2(Never n) {`
Original file line number	Diff line number	Diff line change
`@@ -20,10 +20,7 @@ test1() {`
`20`	`20`	`i = 42;`
`21`	`21`	`}`
`22`	`22`	`}`
`23`		`- i; // Definitely unassigned.`
`24`		`-//^`
`25`		`-// [analyzer] unspecified`
`26`		`-// [cfe] unspecified`
	`23`	`+ i; // Possibly assigned. See https://github.com/dart-lang/sdk/issues/60394`
`27`	`24`	`}`
`28`	`25`
`29`	`26`	`test2(Never n) {`
Original file line number	Diff line number	Diff line change
`@@ -19,10 +19,7 @@ test1() {`
`19`	`19`	`for (Never n in <dynamic>[42]) {}`
`20`	`20`	`i = 42;`
`21`	`21`	`}`
`22`		`- i; // Definitely unassigned.`
`23`		`-//^`
`24`		`-// [analyzer] unspecified`
`25`		`-// [cfe] unspecified`
	`22`	`+ i; // Possibly assigned. See https://github.com/dart-lang/sdk/issues/60394`
`26`	`23`	`}`
`27`	`24`
`28`	`25`	`test2(Never n) {`