Fix new analysis warnings, move to dart_flutter_team_lints (dart-archive/fake_async#58)

Author: kevmoo

pkgs/fake_async/.github/workflows/test-package.yml

@@ -47,7 +47,7 @@ jobs:
       matrix:
         # Add macos-latest and/or windows-latest if relevant for this package.
         os: [ubuntu-latest]
-        sdk: [2.12.0, dev]
+        sdk: [2.17.0, dev]
     steps:
       - uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c
       - uses: dart-lang/setup-dart@a57a6c04cf7d4840e88432aad6281d1e125f0d46

pkgs/fake_async/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 1.3.2-dev
+
+* Require Dart 2.17.
+
 ## 1.3.1
 
 * Populate the pubspec `repository` field.

pkgs/fake_async/analysis_options.yaml

@@ -1,95 +1,22 @@
-include: package:lints/recommended.yaml
+include: package:dart_flutter_team_lints/analysis_options.yaml
 analyzer:
   language:
     strict-casts: true
 
 linter:
   rules:
-    - always_declare_return_types
-    - annotate_overrides
     - avoid_bool_literals_in_conditional_expressions
     - avoid_classes_with_only_static_members
-    - avoid_empty_else
-    - avoid_function_literals_in_foreach_calls
-    - avoid_init_to_null
-    - avoid_null_checks_in_equality_operators
-    - avoid_relative_lib_imports
-    - avoid_renaming_method_parameters
-    - avoid_return_types_on_setters
-    - avoid_returning_null
-    - avoid_returning_null_for_future
-    - avoid_returning_null_for_void
     - avoid_returning_this
-    - avoid_shadowing_type_parameters
-    - avoid_single_cascade_in_expression_statements
-    - avoid_types_as_parameter_names
     - avoid_unused_constructor_parameters
-    - await_only_futures
-    - camel_case_types
     - cancel_subscriptions
     - cascade_invocations
     - comment_references
-    - constant_identifier_names
-    - control_flow_in_finally
-    - directives_ordering
-    - empty_catches
-    - empty_constructor_bodies
-    - empty_statements
-    - file_names
-    - hash_and_equals
-    - implementation_imports
-    - iterable_contains_unrelated_type
     - join_return_with_assignment
-    - library_names
-    - library_prefixes
-    - lines_longer_than_80_chars
-    - list_remove_unrelated_type
     - literal_only_boolean_expressions
     - no_adjacent_strings_in_list
-    - no_duplicate_case_values
-    - non_constant_identifier_names
-    - null_closures
-    - omit_local_variable_types
-    - only_throw_errors
-    - overridden_fields
     - package_api_docs
-    - package_names
-    - package_prefixed_library_names
-    - prefer_adjacent_string_concatenation
-    # Wait for oldest supported SDK to be 2.2
-    #- prefer_collection_literals
-    - prefer_conditional_assignment
-    #- prefer_const_constructors
-    - prefer_contains
-    - prefer_equal_for_default_values
-    - prefer_final_fields
-    #- prefer_final_locals
-    - prefer_generic_function_type_aliases
-    - prefer_initializing_formals
-    - prefer_interpolation_to_compose_strings
-    - prefer_is_empty
-    - prefer_is_not_empty
-    - prefer_null_aware_operators
-    - prefer_single_quotes
-    - prefer_typing_uninitialized_variables
-    - recursive_getters
-    - slash_for_doc_comments
+    - prefer_const_constructors
+    - prefer_final_locals
     - test_types_in_equals
-    - throw_in_finally
-    - type_init_formals
-    - unawaited_futures
     - unnecessary_await_in_return
-    - unnecessary_brace_in_string_interps
-    - unnecessary_const
-    - unnecessary_getters_setters
-    - unnecessary_lambdas
-    - unnecessary_new
-    - unnecessary_null_aware_assignments
-    - unnecessary_parenthesis
-    - unnecessary_statements
-    - unnecessary_this
-    - unrelated_type_equality_checks
-    - use_function_type_syntax_for_parameters
-    - use_rethrow_when_possible
-    - valid_regexps
-    - void_checks

pkgs/fake_async/lib/fake_async.dart

@@ -103,7 +103,7 @@ class FakeAsync {
   /// Note: it's usually more convenient to use [fakeAsync] rather than creating
   /// a [FakeAsync] object and calling [run] manually.
   FakeAsync({DateTime? initialTime, this.includeTimerStackTrace = true}) {
-    var nonNullInitialTime = initialTime ?? clock.now();
+    final nonNullInitialTime = initialTime ?? clock.now();
     _clock = Clock(() => nonNullInitialTime.add(elapsed));
   }
 
@@ -156,7 +156,7 @@ class FakeAsync {
     }
 
     _elapsed += duration;
-    var elapsingTo = _elapsingTo;
+    final elapsingTo = _elapsingTo;
     if (elapsingTo != null && _elapsed > elapsingTo) _elapsingTo = _elapsed;
   }
 
@@ -169,7 +169,7 @@ class FakeAsync {
   /// The [`clock`][] property will be set to a clock that reports the fake
   /// elapsed time. By default, it starts at the time the [FakeAsync] was
   /// created (according to [`clock.now()`][]), but this can be controlled by
-  /// passing `initialTime` to [new FakeAsync].
+  /// passing `initialTime` to [FakeAsync.new].
   ///
   /// [`clock`]: https://www.dartdocs.org/documentation/clock/latest/clock/clock.html
   /// [`clock.now()`]: https://www.dartdocs.org/documentation/clock/latest/clock/Clock/now.html
@@ -210,7 +210,7 @@ class FakeAsync {
   void flushTimers(
       {Duration timeout = const Duration(hours: 1),
       bool flushPeriodicTimers = true}) {
-    var absoluteTimeout = _elapsed + timeout;
+    final absoluteTimeout = _elapsed + timeout;
     _fireTimersWhile((timer) {
       if (timer._nextCall > absoluteTimeout) {
         // TODO(nweiz): Make this a [TimeoutException].
@@ -237,7 +237,7 @@ class FakeAsync {
     for (;;) {
       if (_timers.isEmpty) break;
 
-      var timer = minBy(_timers, (FakeTimer timer) => timer._nextCall)!;
+      final timer = minBy(_timers, (FakeTimer timer) => timer._nextCall)!;
       if (!predicate(timer)) break;
 
       _elapseTo(timer._nextCall);
@@ -249,7 +249,7 @@ class FakeAsync {
   /// Creates a new timer controlled by `this` that fires [callback] after
   /// [duration] (or every [duration] if [periodic] is `true`).
   Timer _createTimer(Duration duration, Function callback, bool periodic) {
-    var timer = FakeTimer._(duration, callback, periodic, this,
+    final timer = FakeTimer._(duration, callback, periodic, this,
         includeStackTrace: includeTimerStackTrace);
     _timers.add(timer);
     return timer;
@@ -320,10 +320,12 @@ class FakeTimer implements Timer {
     assert(isActive);
     _tick++;
     if (isPeriodic) {
+      // ignore: avoid_dynamic_calls
       _callback(this);
       _nextCall += duration;
     } else {
       cancel();
+      // ignore: avoid_dynamic_calls
       _callback();
     }
   }

pkgs/fake_async/pubspec.yaml

@@ -1,18 +1,18 @@
 name: fake_async
-version: 1.3.1
+version: 1.3.2-dev
 description: >-
   Fake asynchronous events such as timers and microtasks for deterministic
   testing.
 repository: https://github.com/dart-lang/fake_async
 
 environment:
-  sdk: ">=2.12.0 <3.0.0"
+  sdk: ">=2.17.0 <3.0.0"
 
 dependencies:
   clock: ^1.1.0
   collection: ^1.15.0
 
 dev_dependencies:
   async: ^2.5.0
-  lints: ^1.0.0
+  dart_flutter_team_lints: ^0.1.0
   test: ^1.16.0