fix ci, update analysis options (dart-archive/typed_data#61)

Author: kevmoo

pkgs/typed_data/.github/workflows/test-package.yml

@@ -47,7 +47,7 @@ jobs:
       matrix:
         # Add macos-latest and/or windows-latest if relevant for this package.
         os: [ubuntu-latest]
-        sdk: [2.12.0, dev]
+        sdk: [2.17.0, dev]
     steps:
       - uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c
       - uses: dart-lang/setup-dart@a57a6c04cf7d4840e88432aad6281d1e125f0d46

pkgs/typed_data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 1.3.2-dev
+
+* Require Dart 2.17
+
 ## 1.3.1
 
 * Switch to using `package:lints`.
@@ -6,32 +10,9 @@
 ## 1.3.0
 
 * Stable release for null safety.
-
-## 1.3.0-nullsafety.5
-
 * Update SDK constraints to `>=2.12.0-0 <3.0.0` based on beta release
   guidelines.
 
-## 1.3.0-nullsafety.4
-
-* Allow prerelease versions of the `2.12` sdk.
-
-## 1.3.0-nullsafety.3
-
-* Allow 2.10 stable and 2.11.0 dev SDK versions.
-
-## 1.3.0-nullsafety.2
-
-* Update for the 2.10 dev sdk.
-
-## 1.3.0-nullsafety.1
-
-* Allow the <=2.9.10 stable sdks.
-
-## 1.3.0-nullsafety
-
-* Migrate to NNBD
-
 ## 1.2.0
 
 * Add typed queue classes such as `Uint8Queue`. These classes implement both
@@ -45,7 +26,7 @@
 
 ## 1.1.5
 
-* Undo unnessesary SDK version constraint tweak.
+* Undo unnecessary SDK version constraint tweak.
 
 ## 1.1.4
 

pkgs/typed_data/analysis_options.yaml

@@ -1,28 +1,17 @@
-include: package:lints/recommended.yaml
+include: package:dart_flutter_team_lints/analysis_options.yaml
 
 analyzer:
   language:
     strict-casts: true
 
 linter:
   rules:
-    - avoid_dynamic_calls
-    - always_declare_return_types
     - avoid_returning_null
     - avoid_unused_constructor_parameters
     - cancel_subscriptions
     - comment_references
-    - directives_ordering
     - no_adjacent_strings_in_list
-    - omit_local_variable_types
-    - only_throw_errors
     - package_api_docs
     - prefer_const_constructors
-    - prefer_interpolation_to_compose_strings
-    - prefer_single_quotes
     - test_types_in_equals
-    - throw_in_finally
-    - unawaited_futures
-    - unnecessary_lambdas
-    - unnecessary_null_aware_assignments
-    - unnecessary_statements
+    - use_super_parameters

pkgs/typed_data/lib/src/typed_buffer.dart

@@ -308,14 +308,14 @@ abstract class TypedDataBuffer<E> extends ListBase<E> {
 }
 
 abstract class _IntBuffer extends TypedDataBuffer<int> {
-  _IntBuffer(List<int> buffer) : super(buffer);
+  _IntBuffer(super.buffer);
 
   @override
   int get _defaultValue => 0;
 }
 
 abstract class _FloatBuffer extends TypedDataBuffer<double> {
-  _FloatBuffer(List<double> buffer) : super(buffer);
+  _FloatBuffer(super.buffer);
 
   @override
   double get _defaultValue => 0.0;

pkgs/typed_data/lib/src/typed_queue.dart

@@ -223,8 +223,8 @@ abstract class _TypedQueue<E, L extends List<E>> with ListMixin<E> {
         }
       }
     } else if (targetIsContiguous) {
-      // If the range is contiguous within the table, we can set it with a single
-      // underlying [setRange] call.
+      // If the range is contiguous within the table, we can set it with a
+      // single underlying [setRange] call.
       _table.setRange(targetStart, targetEnd, iterable, skipCount);
     } else if (iterable is List<E>) {
       // If the range isn't contiguous and [iterable] is actually a [List] (but
@@ -337,15 +337,15 @@ abstract class _TypedQueue<E, L extends List<E>> with ListMixin<E> {
 }
 
 abstract class _IntQueue<L extends List<int>> extends _TypedQueue<int, L> {
-  _IntQueue(L queue) : super(queue);
+  _IntQueue(super.queue);
 
   @override
   int get _defaultValue => 0;
 }
 
 abstract class _FloatQueue<L extends List<double>>
     extends _TypedQueue<double, L> {
-  _FloatQueue(L queue) : super(queue);
+  _FloatQueue(super.queue);
 
   @override
   double get _defaultValue => 0.0;
@@ -644,12 +644,13 @@ class Int32x4Queue extends _TypedQueue<Int32x4, Int32x4List>
 /// time-efficient than a default [QueueList] implementation.
 class Float32x4Queue extends _TypedQueue<Float32x4, Float32x4List>
     implements QueueList<Float32x4> {
-  /// Creates an empty [Float32x4Queue] with the given initial internal capacity (in
-  /// elements).
+  /// Creates an empty [Float32x4Queue] with the given initial internal capacity
+  /// (in elements).
   Float32x4Queue([int? initialCapacity])
       : super(Float32x4List(_chooseRealInitialCapacity(initialCapacity)));
 
-  /// Creates a [Float32x4Queue] with the same length and contents as [elements].
+  /// Creates a [Float32x4Queue] with the same length and contents as
+  /// [elements].
   factory Float32x4Queue.fromList(List<Float32x4> elements) =>
       Float32x4Queue(elements.length)..addAll(elements);
 

pkgs/typed_data/pubspec.yaml

@@ -1,15 +1,15 @@
 name: typed_data
-version: 1.3.1
+version: 1.3.2-dev
 description: >-
   Utility functions and classes related to the dart:typed_data library.
 repository: https://github.com/dart-lang/typed_data
 
 environment:
-  sdk: ">=2.12.0 <3.0.0"
+  sdk: ">=2.17.0 <3.0.0"
 
 dependencies:
   collection: ^1.15.0
 
 dev_dependencies:
-  lints: ^1.0.0
+  dart_flutter_team_lints: ^0.1.0
   test: ^1.16.0

pkgs/typed_data/test/queue_test.dart

@@ -5,7 +5,6 @@
 // ignore_for_file: avoid_function_literals_in_foreach_calls
 
 import 'package:test/test.dart';
-
 import 'package:typed_data/typed_data.dart';
 
 /// The initial capacity of queues if the user doesn't specify one.
@@ -110,8 +109,8 @@ void main() {
     });
 
     group(
-        'sets a range to a section of the same queue overlapping at the beginning',
-        () {
+        'sets a range to a section of the same queue overlapping at the '
+        'beginning', () {
       forEachInternalRepresentation((queue) {
         queue.setRange(5, 10, queue, 2);
         expect(queue, [1, 2, 3, 4, 5, 3, 4, 5, 6, 7, 11, 12, 13, 14, 15]);

pkgs/typed_data/test/typed_buffers_test.dart

@@ -44,30 +44,29 @@ void main() {
 }
 
 void initTests(List<int> intSamples) {
-  testUint(intSamples, 8, (l) => Uint8Buffer(l));
-  testInt(intSamples, 8, (l) => Int8Buffer(l));
+  testUint(intSamples, 8, Uint8Buffer.new);
+  testInt(intSamples, 8, Int8Buffer.new);
   test('Uint8ClampedBuffer', () {
-    testIntBuffer(
-        intSamples, 8, 0, 255, (l) => Uint8ClampedBuffer(l), clampUint8);
+    testIntBuffer(intSamples, 8, 0, 255, Uint8ClampedBuffer.new, clampUint8);
   });
-  testUint(intSamples, 16, (l) => Uint16Buffer(l));
-  testInt(intSamples, 16, (l) => Int16Buffer(l));
-  testUint(intSamples, 32, (l) => Uint32Buffer(l));
+  testUint(intSamples, 16, Uint16Buffer.new);
+  testInt(intSamples, 16, Int16Buffer.new);
+  testUint(intSamples, 32, Uint32Buffer.new);
 
-  testInt(intSamples, 32, (l) => Int32Buffer(l));
+  testInt(intSamples, 32, Int32Buffer.new);
 
-  testUint(intSamples, 64, (l) => Uint64Buffer(l),
+  testUint(intSamples, 64, Uint64Buffer.new,
       // JS doesn't support 64-bit ints, so only test this on the VM.
       testOn: 'dart-vm');
-  testInt(intSamples, 64, (l) => Int64Buffer(l),
+  testInt(intSamples, 64, Int64Buffer.new,
       // JS doesn't support 64-bit ints, so only test this on the VM.
       testOn: 'dart-vm');
 
   testInt32x4Buffer(intSamples);
 
   var roundedFloatSamples = floatSamples.map(roundToFloat).toList();
-  testFloatBuffer(32, roundedFloatSamples, () => Float32Buffer(), roundToFloat);
-  testFloatBuffer(64, doubleSamples, () => Float64Buffer(), (x) => x);
+  testFloatBuffer(32, roundedFloatSamples, Float32Buffer.new, roundToFloat);
+  testFloatBuffer(64, doubleSamples, Float64Buffer.new, (x) => x);
 
   testFloat32x4Buffer(roundedFloatSamples);
 
@@ -557,7 +556,7 @@ class MatchesInt32x4 extends Matcher {
       description.add('Int32x4.==');
 
   @override
-  bool matches(item, Map matchState) =>
+  bool matches(Object? item, Map matchState) =>
       item is Int32x4 &&
       result.x == item.x &&
       result.y == item.y &&