Use go_router for routing and switch to path-based URLs (#180)

This prepares the app to support the cl/<cl number>/<patchset> route it needs to display the aggregated test results. Switching to path based routing means the app will be able to handle the existing URLs used in Gerrit, which will make it easier to transition to the new UI.

* Use go_router for routing
* Enable use_key_in_widget_constructors lint
* Use IconButton tooltip property instead of widget

Author: athomas

current_results_ui/analysis_options.yaml

@@ -7,8 +7,6 @@ analyzer:
 
 linter:
   rules:
-    # Disabled as there are currently many violations.
-    use_key_in_widget_constructors: false
     # Disabled - currently one violation.
     avoid_print: false
 

current_results_ui/lib/filter.dart

@@ -4,10 +4,10 @@
 
 import 'package:collection/collection.dart';
 import 'package:flutter/material.dart';
+import 'package:go_router/go_router.dart';
 import 'package:provider/provider.dart';
 
 import 'query.dart';
-import 'main.dart';
 
 class Filter {
   final List<String> terms;
@@ -18,12 +18,16 @@ class Filter {
     return List.unmodifiable(termString.split(',').map((s) => s.trim()));
   }
 
-  bool hasSameTerms(Filter other) =>
-      const ListEquality().equals(terms, other.terms);
+  @override
+  bool operator ==(Object other) =>
+      other is Filter && const ListEquality().equals(terms, other.terms);
+
+  @override
+  int get hashCode => const ListEquality().hash(terms);
 }
 
 class FilterUI extends StatefulWidget {
-  const FilterUI();
+  const FilterUI({super.key});
 
   @override
   State<FilterUI> createState() => _FilterUIState();
@@ -38,6 +42,14 @@ class _FilterUIState extends State<FilterUI> {
     super.dispose();
   }
 
+  void _updateFilter(Iterable<String> newTerms) {
+    final uri = GoRouter.of(context).routeInformationProvider.value.uri;
+    final newUri = uri.replace(
+      queryParameters: {...uri.queryParameters, 'filter': newTerms.join(',')},
+    );
+    GoRouter.of(context).go(newUri.toString());
+  }
+
   @override
   Widget build(BuildContext context) {
     return Consumer<QueryResults>(
@@ -62,9 +74,8 @@ class _FilterUIState extends State<FilterUI> {
                           InputChip(
                             label: Text(term),
                             onDeleted: () {
-                              pushRoute(
-                                context,
-                                terms: filter.terms.where((t) => t != term),
+                              _updateFilter(
+                                filter.terms.where((t) => t != term),
                               );
                             },
                             onPressed: () {
@@ -92,9 +103,8 @@ class _FilterUIState extends State<FilterUI> {
                         term.startsWith(newTerm) || newTerm.startsWith(term),
                   );
                   controller.text = '';
-                  pushRoute(
-                    context,
-                    terms: filter.terms
+                  _updateFilter(
+                    filter.terms
                         .where(isNotReplacedByNewTerm)
                         .followedBy(newTerms),
                   );

current_results_ui/lib/instructions.dart

@@ -1,10 +1,13 @@
-// Copyright (c) 2020, the Dart project authors.  Please see the AUTHORS file
+// Copyright (c) 2020, the Dart project authors. Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'package:flutter/material.dart';
+import 'package:go_router/go_router.dart';
 
 class Instructions extends StatelessWidget {
+  const Instructions({super.key});
+
   @override
   Widget build(context) {
     return SingleChildScrollView(
@@ -47,7 +50,12 @@ class Instructions extends StatelessWidget {
             const SizedBox(height: 12),
             InkWell(
               onTap: () {
-                Navigator.pushNamed(context, '/filter=${example['terms']}');
+                GoRouter.of(context).go(
+                  Uri(
+                    path: '/',
+                    queryParameters: {'filter': example['terms']},
+                  ).toString(),
+                );
               },
               child: Text.rich(
                 TextSpan(