Skip to content

Commit f54cb0e

Browse files
committed
Squashed commit of the following:
commit 50d78882baa49482b08ec8083b4c7459624d3de3 Author: Alexander Thomas <[email protected]> Date: Tue Sep 16 12:52:41 2025 +0200 Format commit c602f639127bd369ccb22f3e970ecd097cd9e3d0 Author: Alexander Thomas <[email protected]> Date: Tue Sep 16 12:51:34 2025 +0200 Pre-sort try result to ensure test counts are correct commit b196ece2b33ef6e122bf78b052c02e9eb5b8b9f7 Author: Alexander Thomas <[email protected]> Date: Tue Sep 16 12:40:59 2025 +0200 Improve sorting of result changes commit 47a094e47083cafbca47b9444ad2fad60466ff48 Author: Alexander Thomas <[email protected]> Date: Tue Sep 16 12:40:31 2025 +0200 Formatting commit d4ed80dccfbc5876549141eb6c5f83800c718385 Author: Alexander Thomas <[email protected]> Date: Tue Sep 16 11:19:18 2025 +0200 Remove debug print commit 91d39d6317d0b4c17a9f5fc594592a2f0eddf2f4 Author: Alexander Thomas <[email protected]> Date: Tue Sep 16 11:18:05 2025 +0200 Move no query handling to subclass commit 0e0e2e027f4a32578bb549d5fb440403307d7146 Author: Alexander Thomas <[email protected]> Date: Tue Sep 16 11:09:36 2025 +0200 Fix ChangeInResult for new tests and refactor commit 4bbe46f43b750076250162030591dff8c2bb0c8d Author: Alexander Thomas <[email protected]> Date: Mon Sep 15 13:40:21 2025 +0200 Delete unused changes_list.dart commit cbc573c97fb1d90e1d4b36143167921b5934a633 Author: Alexander Thomas <[email protected]> Date: Wed Sep 10 06:55:25 2025 -0700 Fix copyright headers commit 89de18f13b255d10d6cb131496e945819637aa97 Author: Alexander Thomas <[email protected]> Date: Wed Sep 10 06:43:12 2025 -0700 Upgrade dependencies commit 7b9fbdeca87af7d2e95dcc49cf13671a6ab12ff5 Merge: f8afae5 d2efaee Author: Alexander Thomas <[email protected]> Date: Fri Sep 5 18:39:44 2025 +0200 Merge remote-tracking branch 'origin/main' into try-results-page commit f8afae52af767bf74ad0aba7dfb25434964c4a4b Author: Alexander Thomas <[email protected]> Date: Fri Sep 5 13:55:42 2025 +0200 New implementation of try results page with current results look and feel commit 6e03623b2f17db7fbe8ef9156eb881c5087611af Author: Alexander Thomas <[email protected]> Date: Fri Sep 5 13:54:51 2025 +0200 Add go_router dependency commit e5c1e4a8a9e6b53646b994f4233678c38d703e74 Author: Alexander Thomas <[email protected]> Date: Fri Sep 5 13:52:31 2025 +0200 Fix file header in GEMINI.md commit 2b439b4814a1ecb6c3aa6a1a7a774945f6d3b41e Author: Alexander Thomas <[email protected]> Date: Thu Sep 4 09:11:14 2025 +0200 Add padding left commit f1c614c351575db944c9e1effc7a6736815438dd Author: Alexander Thomas <[email protected]> Date: Wed Sep 3 18:21:45 2025 +0200 Expand rows by default and fix colors commit d02368b58caaa54250d11c817d195bef73a9dffe Author: Alexander Thomas <[email protected]> Date: Wed Sep 3 17:47:55 2025 +0200 Add toolbar and improve header look & feel commit 41df7da8fb2c8e33edea1c54c12dc72859267e22 Author: Alexander Thomas <[email protected]> Date: Wed Sep 3 17:25:47 2025 +0200 Add link to CL and alternate row colors commit b50e95ae79e10851e9cecc82fe90537341c538e5 Author: Alexander Thomas <[email protected]> Date: Wed Sep 3 12:44:39 2025 +0200 Reformat commit 42de59abc70013ef3548fed55438afd2ed771100 Author: Alexander Thomas <[email protected]> Date: Wed Sep 3 12:44:24 2025 +0200 Use conditional import for URL strategy commit b989fe4342ccad7729ad96099314bc8ffe984dd7 Author: Alexander Thomas <[email protected]> Date: Wed Sep 3 12:14:54 2025 +0200 Update README.md and add GEMINI.md commit 891aa19a96a00a1706900b8036be35e05775ad46 Author: Alexander Thomas <[email protected]> Date: Wed Sep 3 12:14:28 2025 +0200 Add missing dependencies commit 1274183a0937ca195c9292406255ba479712eb60 Merge: dee62f5 186e024 Author: Alexander Thomas <[email protected]> Date: Tue Sep 2 16:15:55 2025 +0200 Merge branch 'main' into add-firebase-login commit dee62f5fe53984498aea552659038e61132cd8ee Author: Alexander Thomas <[email protected]> Date: Tue Aug 19 10:11:38 2025 +0200 Add try results page commit 8db60b5 Author: Alexander Thomas <[email protected]> Date: Fri Aug 15 11:28:38 2025 +0200 Format again commit 013e422 Author: Alexander Thomas <[email protected]> Date: Fri Aug 15 11:26:36 2025 +0200 Add copyright headers commit e682745 Author: Alexander Thomas <[email protected]> Date: Fri Aug 15 10:57:46 2025 +0200 Remove extra comments commit ea12229 Author: Alexander Thomas <[email protected]> Date: Fri Aug 15 10:55:02 2025 +0200 dart format commit 9b5b7db Author: Alexander Thomas <[email protected]> Date: Fri Aug 15 10:50:01 2025 +0200 Fix UI and tests commit b2ed2a8 Author: Alexander Thomas <[email protected]> Date: Fri May 9 11:34:52 2025 +0200 WiP to use firebase emulator commit cf6903b Author: Alexander Thomas <[email protected]> Date: Fri May 2 13:08:02 2025 +0200 Remove some redundant comments commit 78c9bb9 Author: Alexander Thomas <[email protected]> Date: Fri May 2 12:22:14 2025 +0200 Make it work commit 97d0a35 Author: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Date: Thu May 1 15:58:09 2025 +0000 fix: Update Firebase config with values from console Updates the Firebase configuration in current_results_ui/web/index.html with the precise values obtained from the Firebase console, including the correct apiKey and appId.
1 parent 6074272 commit f54cb0e

21 files changed

+1037
-421
lines changed

current_results_ui/analysis_options.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@ linter:
99
rules:
1010
# Disabled - currently one violation.
1111
avoid_print: false
12+
directives_ordering: true
13+
prefer_relative_imports: true
1214

1315
# Additional information about this file can be found at
1416
# https://dart.dev/guides/language/analysis-options

current_results_ui/lib/filter.dart

Lines changed: 61 additions & 79 deletions
Original file line numberDiff line numberDiff line change
@@ -26,94 +26,76 @@ class Filter {
2626
int get hashCode => const ListEquality().hash(terms);
2727
}
2828

29-
class FilterUI extends StatefulWidget {
29+
class FilterUI extends StatelessWidget {
3030
const FilterUI({super.key});
3131

3232
@override
33-
State<FilterUI> createState() => _FilterUIState();
34-
}
35-
36-
class _FilterUIState extends State<FilterUI> {
37-
final controller = TextEditingController();
38-
39-
@override
40-
void dispose() {
41-
controller.dispose();
42-
super.dispose();
43-
}
33+
Widget build(BuildContext context) {
34+
final controller = TextEditingController();
35+
final results = context.watch<QueryResultsBase>();
36+
final filter = results.filter;
4437

45-
void _updateFilter(Iterable<String> newTerms) {
46-
final uri = GoRouter.of(context).routeInformationProvider.value.uri;
47-
final newUri = uri.replace(
48-
queryParameters: {...uri.queryParameters, 'filter': newTerms.join(',')},
49-
);
50-
GoRouter.of(context).go(newUri.toString());
51-
}
38+
void updateFilter(Iterable<String> newTerms) {
39+
final uri = GoRouter.of(context).routeInformationProvider.value.uri;
40+
final newUri = uri.replace(
41+
queryParameters: {...uri.queryParameters, 'filter': newTerms.join(',')},
42+
);
43+
GoRouter.of(context).go(newUri.toString());
44+
}
5245

53-
@override
54-
Widget build(BuildContext context) {
55-
return Consumer<QueryResultsBase>(
56-
builder: (context, results, child) {
57-
final filter = results.filter;
58-
return Column(
59-
crossAxisAlignment: CrossAxisAlignment.start,
60-
children: [
61-
ConstrainedBox(
62-
constraints: const BoxConstraints(maxHeight: 100.0),
63-
child: Scrollbar(
64-
child: SingleChildScrollView(
65-
child: Container(
66-
padding: const EdgeInsets.only(top: 16.0),
67-
alignment: Alignment.topLeft,
68-
child: Wrap(
69-
spacing: 8.0,
70-
runSpacing: 8.0,
71-
alignment: WrapAlignment.start,
72-
children: [
73-
for (final term in filter.terms)
74-
InputChip(
75-
label: Text(term),
76-
onDeleted: () {
77-
_updateFilter(
78-
filter.terms.where((t) => t != term),
79-
);
80-
},
81-
onPressed: () {
82-
controller.text = term;
83-
},
84-
),
85-
],
86-
),
87-
),
46+
return Column(
47+
crossAxisAlignment: CrossAxisAlignment.start,
48+
children: [
49+
ConstrainedBox(
50+
constraints: const BoxConstraints(maxHeight: 100.0),
51+
child: Scrollbar(
52+
child: SingleChildScrollView(
53+
child: Container(
54+
padding: const EdgeInsets.only(top: 16.0),
55+
alignment: Alignment.topLeft,
56+
child: Wrap(
57+
spacing: 8.0,
58+
runSpacing: 8.0,
59+
alignment: WrapAlignment.start,
60+
children: [
61+
for (final term in filter.terms)
62+
InputChip(
63+
label: Text(term),
64+
onDeleted: () {
65+
updateFilter(filter.terms.where((t) => t != term));
66+
},
67+
onPressed: () {
68+
controller.text = term;
69+
},
70+
),
71+
],
8872
),
8973
),
9074
),
91-
SizedBox(
92-
width: 300.0,
93-
child: TextField(
94-
controller: controller,
95-
decoration: const InputDecoration(
96-
hintText: 'Test, configuration or experiment prefix',
97-
),
98-
onSubmitted: (value) {
99-
if (value.trim().isEmpty) return;
100-
final newTerms = value.split(',').map((s) => s.trim());
101-
bool isNotReplacedByNewTerm(String term) => !newTerms.any(
102-
(newTerm) =>
103-
term.startsWith(newTerm) || newTerm.startsWith(term),
104-
);
105-
controller.text = '';
106-
_updateFilter(
107-
filter.terms
108-
.where(isNotReplacedByNewTerm)
109-
.followedBy(newTerms),
110-
);
111-
},
112-
),
75+
),
76+
),
77+
SizedBox(
78+
width: 300.0,
79+
child: TextField(
80+
controller: controller,
81+
decoration: const InputDecoration(
82+
hintText: 'Test, configuration or experiment prefix',
11383
),
114-
],
115-
);
116-
},
84+
onSubmitted: (value) {
85+
if (value.trim().isEmpty) return;
86+
final newTerms = value.split(',').map((s) => s.trim());
87+
bool isNotReplacedByNewTerm(String term) => !newTerms.any(
88+
(newTerm) =>
89+
term.startsWith(newTerm) || newTerm.startsWith(term),
90+
);
91+
controller.text = '';
92+
updateFilter(
93+
filter.terms.where(isNotReplacedByNewTerm).followedBy(newTerms),
94+
);
95+
},
96+
),
97+
),
98+
],
11799
);
118100
}
119101
}

0 commit comments

Comments
 (0)