lints (#1061)

* Enable and fix recommended lints

* Enable and fix two more lints

Author: kevmoo

CHANGELOG.md

@@ -1,3 +1,5 @@
+# 2.2.1-dev
+
 # 2.2.0
 
 * Fix analyzer dependency constraint (#1051).

analysis_options.yaml

@@ -1,6 +1,8 @@
-include: package:pedantic/analysis_options.yaml
+include: package:lints/recommended.yaml
 linter:
   rules:
+    - avoid_dynamic_calls
+    - directives_ordering
     - prefer_equal_for_default_values
     - prefer_generic_function_type_aliases
     - slash_for_doc_comments

benchmark/benchmark.dart

@@ -6,12 +6,11 @@ library dart_style.benchmark.benchmark;
 
 import 'dart:io';
 
-import 'package:path/path.dart' as p;
-
 import 'package:dart_style/dart_style.dart';
+import 'package:path/path.dart' as p;
 
-const NUM_TRIALS = 100;
-const FORMATS_PER_TRIAL = 30;
+const _numTrials = 100;
+const _formatsPerTrial = 30;
 
 /// Note, these files use ".txt" because while they can be *parsed* correctly,
 /// they don't resolve without error. That's OK because the formatter doesn't
@@ -24,17 +23,17 @@ void main(List<String> args) {
 
   // Run the benchmark several times. This ensures the VM is warmed up and lets
   // us see how much variance there is.
-  for (var i = 0; i <= NUM_TRIALS; i++) {
+  for (var i = 0; i <= _numTrials; i++) {
     var start = DateTime.now();
 
     // For a single benchmark, format the source multiple times.
-    var result;
-    for (var j = 0; j < FORMATS_PER_TRIAL; j++) {
+    String? result;
+    for (var j = 0; j < _formatsPerTrial; j++) {
       result = formatSource();
     }
 
     var elapsed =
-        DateTime.now().difference(start).inMilliseconds / FORMATS_PER_TRIAL;
+        DateTime.now().difference(start).inMilliseconds / _formatsPerTrial;
 
     // Keep track of the best run so far.
     if (elapsed >= best) continue;

bin/format.dart

@@ -35,7 +35,7 @@ void main(List<String> args) async {
     return;
   }
 
-  if (argResults['verbose'] && !argResults['help']) {
+  if (argResults['verbose'] && !(argResults['help'] as bool)) {
     usageError(parser, 'Can only use --verbose with --help.');
   }
 
@@ -52,7 +52,7 @@ void main(List<String> args) async {
   }
 
   void checkForReporterCollision(String chosen, String other) {
-    if (!argResults[other]) return;
+    if (!(argResults[other] as bool)) return;
 
     usageError(parser, 'Cannot use --$chosen and --$other at the same time.');
   }

example/format.dart

@@ -4,10 +4,9 @@
 import 'dart:io';
 import 'dart:mirrors';
 
-import 'package:path/path.dart' as p;
-
 import 'package:dart_style/dart_style.dart';
 import 'package:dart_style/src/debug.dart' as debug;
+import 'package:path/path.dart' as p;
 
 void main(List<String> args) {
   // Enable debugging so you can see some of the formatter's internal state.
@@ -33,7 +32,7 @@ void runFormatter(String source, int pageWidth,
   try {
     var formatter = DartFormatter(pageWidth: pageWidth);
 
-    var result;
+    String result;
     if (isCompilationUnit) {
       result = formatter.format(source);
     } else {

lib/dart_style.dart

@@ -3,5 +3,5 @@
 // BSD-style license that can be found in the LICENSE file.
 export 'src/dart_formatter.dart';
 export 'src/exceptions.dart';
-export 'src/style_fix.dart';
 export 'src/source_code.dart';
+export 'src/style_fix.dart';

lib/src/argument_list_visitor.dart

@@ -64,8 +64,8 @@ class ArgumentListVisitor {
       Token rightParenthesis,
       List<Expression> arguments) {
     // Look for a single contiguous range of block function arguments.
-    var functionsStart;
-    var functionsEnd;
+    int? functionsStart;
+    int? functionsEnd;
 
     for (var i = 0; i < arguments.length; i++) {
       var argument = arguments[i];
@@ -104,7 +104,7 @@ class ArgumentListVisitor {
     //         another: argument);
     if (functionsStart != null &&
         arguments[0] is NamedExpression &&
-        (functionsStart > 0 || functionsEnd < arguments.length)) {
+        (functionsStart > 0 || functionsEnd! < arguments.length)) {
       functionsStart = null;
     }
 
@@ -125,7 +125,7 @@ class ArgumentListVisitor {
         return false;
       }
 
-      for (var i = 0; i < functionsStart; i++) {
+      for (var i = 0; i < functionsStart!; i++) {
         var argument = arguments[i];
         if (argument is! NamedExpression) continue;
 
@@ -135,7 +135,7 @@ class ArgumentListVisitor {
         }
       }
 
-      for (var i = functionsEnd; i < arguments.length; i++) {
+      for (var i = functionsEnd!; i < arguments.length; i++) {
         if (isArrow(arguments[i] as NamedExpression)) {
           functionsStart = null;
           break;
@@ -153,7 +153,7 @@ class ArgumentListVisitor {
     // functions in the middle.
     var argumentsBefore = arguments.take(functionsStart).toList();
     var functions = arguments.sublist(functionsStart, functionsEnd);
-    var argumentsAfter = arguments.skip(functionsEnd).toList();
+    var argumentsAfter = arguments.skip(functionsEnd!).toList();
 
     return ArgumentListVisitor._(
         visitor,

lib/src/chunk_builder.dart

@@ -312,7 +312,7 @@ class ChunkBuilder {
 
       // Make sure there is at least one newline after a line comment and allow
       // one or two after a block comment that has nothing after it.
-      var linesAfter;
+      int linesAfter;
       if (i < comments.length - 1) {
         linesAfter = comments[i + 1].linesBefore;
       } else {
@@ -432,6 +432,8 @@ class ChunkBuilder {
           _pendingWhitespace = Whitespace.newline;
         }
         break;
+      default:
+        break;
     }
   }
 
@@ -670,8 +672,8 @@ class ChunkBuilder {
     var result = writer.writeLines(_formatter.indent,
         isCompilationUnit: _source.isCompilationUnit);
 
-    var selectionStart;
-    var selectionLength;
+    int? selectionStart;
+    int? selectionLength;
     if (_source.selectionStart != null) {
       selectionStart = result.selectionStart;
       var selectionEnd = result.selectionEnd;
@@ -734,6 +736,8 @@ class ChunkBuilder {
         // We should have pinned these down before getting here.
         assert(false);
         break;
+      default:
+        break;
     }
 
     _pendingWhitespace = Whitespace.none;
@@ -928,7 +932,7 @@ class ChunkBuilder {
   void _hardenRules() {
     if (_hardSplitRules.isEmpty) return;
 
-    void walkConstraints(rule) {
+    void walkConstraints(Rule rule) {
       rule.harden();
 
       // Follow this rule's constraints, recursively.

lib/src/cli/format_command.dart

@@ -78,7 +78,7 @@ class FormatCommand extends Command<int> {
     }
 
     // Can't use --verbose with anything but --help.
-    if (argResults['verbose'] && !argResults['help']) {
+    if (argResults['verbose'] && !(argResults['help'] as bool)) {
       usageException('Can only use --verbose with --help.');
     }
 

lib/src/cli/options.dart

@@ -125,7 +125,7 @@ void defineOptions(ArgParser parser,
 }
 
 List<int>? parseSelection(ArgResults argResults, String optionName) {
-  var option = argResults[optionName];
+  var option = argResults[optionName] as String?;
   if (option == null) return null;
 
   // Can only preserve a selection when parsing from stdin.