Skip to content

Commit 17dc54d

Browse files
authored
Bump updateAnalysisOptions parameter for deprecation (#4109)
When analyzer 8.2.0 was published, with a new deprecation, it started this cascade of issues: 1. We currently run two SDKs in CI: one set of tests uses Dart 3.8.0, and another uses Dart dev (3.10-something). Those dev bots pick up analyzer 8.2.0, which triggers a CI failure due to the deprecated `updateAnalysisOptions3` parameter. 2. In order to stop using that parameter and instead use `updateAnalysisOptions4`, we have to always get analyzer 8.2.0, because analyzer 8.1.1 does not have the new parameter. 3. In order to get analyzer 8.2.0, we need Dart 3.9.0. So this PR changes our CI to use Dart 3.9.0 and Dart dev.
1 parent 4df6dbe commit 17dc54d

File tree

3 files changed

+3
-4
lines changed

3 files changed

+3
-4
lines changed

.github/workflows/test.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jobs:
2222
fail-fast: false
2323
matrix:
2424
os: [ubuntu-latest]
25-
sdk: [3.8.0, dev]
25+
sdk: [3.9.0, dev]
2626
job: [main, flutter, packages, sdk-docs]
2727
include:
2828
- os: macos-latest

lib/src/model/package_builder.dart

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,9 +58,8 @@ class PubPackageBuilder implements PackageBuilder {
5858
// of handling it ourselves?
5959
resourceProvider: packageMetaProvider.resourceProvider,
6060
sdkPath: config.sdkDir,
61-
updateAnalysisOptions3: ({
61+
updateAnalysisOptions4: ({
6262
required AnalysisOptionsImpl analysisOptions,
63-
required DartSdk sdk,
6463
}) =>
6564
analysisOptions
6665
..warning = false

pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ environment:
77
sdk: ^3.6.0
88

99
dependencies:
10-
analyzer: ^8.1.1
10+
analyzer: ^8.2.0
1111
args: ^2.4.1
1212
collection: ^1.17.0
1313
crypto: ^3.0.3

0 commit comments

Comments
 (0)