Change command line flag allow-tools default to false (#1986)

* Change command line flag allow-tools default to false

* update changelog

Author: keertip

CHANGELOG.md

@@ -1,3 +1,6 @@
+## 0.28.4-dev
+* **Breaking change** Change the default for `allow-tools` command line flag to false.
+
 ## 0.28.3+3
 * Fix code highlighting in Dart after string interpolation (#1946, #1948) by
   updating the highlightjs dependency.

dartdoc_options.yaml

@@ -1,4 +1,4 @@
 dartdoc:
   linkToSource:
     root: '.'
-    uriTemplate: 'https://github.com/dart-lang/dartdoc/blob/v0.28.3+3/%f%#L%l%'
+    uriTemplate: 'https://github.com/dart-lang/dartdoc/blob/v0.28.4-dev/%f%#L%l%'

lib/src/dartdoc_options.dart

@@ -1428,7 +1428,7 @@ class DartdocOptionContext extends DartdocOptionContextBase
 /// given command line arguments.
 Future<List<DartdocOption>> createDartdocOptions() async {
   return <DartdocOption>[
-    new DartdocOptionArgOnly<bool>('allowTools', true,
+    new DartdocOptionArgOnly<bool>('allowTools', false,
         help: 'Execute user-defined tools to fill in @tool directives.',
         negatable: true),
     new DartdocOptionArgFile<double>(

lib/src/version.dart

@@ -1,2 +1,2 @@
 // Generated code. Do not modify.
-const packageVersion = '0.28.3+3';
+const packageVersion = '0.28.4-dev';

pubspec.yaml

@@ -1,6 +1,6 @@
 name: dartdoc
 # Run `grind build` after updating.
-version: 0.28.3+3
+version: 0.28.4-dev
 author: Dart Team <[email protected]>
 description: A documentation generator for Dart.
 homepage: https://github.com/dart-lang/dartdoc

test/dartdoc_integration_test.dart

@@ -112,6 +112,7 @@ void main() {
       expect(
           () => subprocessLauncher.runStreamed(Platform.resolvedExecutable, [
                 dartdocPath,
+                '--allow-tools',
                 '--input=${testPackageToolError.path}',
                 '--output=${path.join(tempDir.absolute.path, 'test_package_tool_error')}'
               ]),

test/dartdoc_test.dart

@@ -100,7 +100,7 @@ void main() {
     });
 
     test('errors generate errors even when warnings are off', () async {
-      Dartdoc dartdoc = await buildDartdoc([], testPackageToolError, tempDir);
+      Dartdoc dartdoc = await buildDartdoc(['--allow-tools'], testPackageToolError, tempDir);
       DartdocResults results = await dartdoc.generateDocsBase();
       PackageGraph p = results.packageGraph;
       Iterable<String> unresolvedToolErrors = p

test/src/utils.dart

@@ -114,6 +114,7 @@ Future<PackageGraph> bootBasicPackage(
             sdkDir.path,
             '--exclude',
             excludeLibraries.join(','),
+            '--allow-tools',
           ] +
           additionalArguments))
       .buildPackageGraph();