Generate anchors for headers in markdown (#1749)

* Fix anchors

* dartfmt

* verify id in unit test

* Empty revision to trigger cla/google retry

Author: jcollins-g

lib/src/markdown_processor.dart

@@ -144,10 +144,10 @@ final HtmlEscape htmlEscape = const HtmlEscape(HtmlEscapeMode.element);
 final List<md.InlineSyntax> _markdown_syntaxes = [
   new _InlineCodeSyntax(),
   new _AutolinkWithoutScheme()
-]..addAll(md.ExtensionSet.gitHubFlavored.inlineSyntaxes);
+]..addAll(md.ExtensionSet.gitHubWeb.inlineSyntaxes);
 
 final List<md.BlockSyntax> _markdown_block_syntaxes = []
-  ..addAll(md.ExtensionSet.gitHubFlavored.blockSyntaxes);
+  ..addAll(md.ExtensionSet.gitHubWeb.blockSyntaxes);
 
 // Remove these schemas from the display text for hyperlinks.
 final RegExp _hide_schemes = new RegExp('^(http|https)://');

test/compare_output_test.dart

@@ -23,9 +23,11 @@ Uri get _currentFileUri =>
 
 String get _testPackageDocsPath {
   if (Platform.version.split(' ').first.contains('-')) {
-    return pathLib.fromUri(_currentFileUri.resolve('../testing/test_package_docs_dev'));
+    return pathLib
+        .fromUri(_currentFileUri.resolve('../testing/test_package_docs_dev'));
   } else {
-    return pathLib.fromUri(_currentFileUri.resolve('../testing/test_package_docs'));
+    return pathLib
+        .fromUri(_currentFileUri.resolve('../testing/test_package_docs'));
   }
 }
 

test/model_test.dart

@@ -250,7 +250,7 @@ void main() {
 
       test('documentation can be rendered as HTML', () {
         expect(packageGraph.defaultPackage.documentationAsHtml,
-            contains('<h1>Best Package</h1>'));
+            contains('<h1 id="best-package">Best Package</h1>'));
       });
 
       test('sdk name', () {

testing/test_package/README.md

@@ -1,7 +1,13 @@
 # Best Package
 
+* [Examples](#examples)
+* [Another Section](#another-section)
+
 This is an amazing package.
 
+
+## Examples
+
 For example, it:
 
 * Is very fast
@@ -56,6 +62,8 @@ var f = function(a, b) {
 };
 ```
 
+## Another Section
+
 It sometimes generates warnings in commentRefs like this: [unknownThingy.FromSomewhere]
 
 Be sure to check out other awesome packages on [pub][].

testing/test_package_docs/fake/fake-library.html

@@ -61,19 +61,19 @@ <h5><span class="package-name">test_package</span> <span class="package-kind">pa
     <h1>fake library</h1>
 
     <section class="desc markdown">
-      <h1>WOW FAKE PACKAGE IS <strong>BEST</strong> <a href="http://example.org">PACKAGE</a></h1>
+      <h1 id="wow-fake-package-is-__best__-packagepkg">WOW FAKE PACKAGE IS <strong>BEST</strong> <a href="http://example.org">PACKAGE</a></h1>
 <p>If you don't have this package yet, get it.
 Don't ask questions.</p>
 <p>Testing code <code>true</code> and <code>false</code></p>
 <p>Testing string escaping: <code>var s = 'I am a string'</code></p>
 <p>My favorite class is <a href="fake/Cool-class.html">Cool</a>.</p>
-<h2>I am an h2</h2>
+<h2 id="i-am-an-h2">I am an h2</h2>
 <p>hello there</p>
-<h3>I am an h3</h3>
+<h3 id="i-am-an-h3">I am an h3</h3>
 <p>hello there</p>
-<h4>I am an h4</h4>
+<h4 id="i-am-an-h4">I am an h4</h4>
 <p>hello there</p>
-<h5>I am an h5</h5>
+<h5 id="i-am-an-h5">I am an h5</h5>
 <p>hello</p>
 <p><em>Why should you get this package?</em></p><ul><li>We told you so.</li><li>Everyone is doing it.</li><li>It smells nice.</li></ul>
 <pre class="language-dart"><code>class Foo {

testing/test_package_docs/index.html

@@ -56,8 +56,9 @@ <h5><span class="package-name">test_package</span> <span class="package-kind">pa
 
   <div class="col-xs-12 col-sm-9 col-md-8 main-content">
       <section class="desc markdown">
-        <h1>Best Package</h1>
+        <h1 id="best-package">Best Package</h1><ul><li><a href="#examples">Examples</a></li><li><a href="#another-section">Another Section</a></li></ul>
 <p>This is an amazing package.</p>
+<h2 id="examples">Examples</h2>
 <p>For example, it:</p><ul><li>Is very fast</li><li>Has zero bugs</li><li>Is free</li></ul>
 <p>It also has some awesome code</p>
 <pre class="language-dart"><code class="language-dart">void main() {
@@ -96,6 +97,7 @@ <h1>Best Package</h1>
   return a + b;  
 };
 </code></pre>
+<h2 id="another-section">Another Section</h2>
 <p>It sometimes generates warnings in commentRefs like this: <code>unknownThingy.FromSomewhere</code></p>
 <p>Be sure to check out other awesome packages on <a href="https://pub.dartlang.org">pub</a>.</p>
       </section>

testing/test_package_docs_dev/fake/fake-library.html

@@ -61,19 +61,19 @@ <h5><span class="package-name">test_package</span> <span class="package-kind">pa
     <h1>fake library</h1>
 
     <section class="desc markdown">
-      <h1>WOW FAKE PACKAGE IS <strong>BEST</strong> <a href="http://example.org">PACKAGE</a></h1>
+      <h1 id="wow-fake-package-is-__best__-packagepkg">WOW FAKE PACKAGE IS <strong>BEST</strong> <a href="http://example.org">PACKAGE</a></h1>
 <p>If you don't have this package yet, get it.
 Don't ask questions.</p>
 <p>Testing code <code>true</code> and <code>false</code></p>
 <p>Testing string escaping: <code>var s = 'I am a string'</code></p>
 <p>My favorite class is <a href="fake/Cool-class.html">Cool</a>.</p>
-<h2>I am an h2</h2>
+<h2 id="i-am-an-h2">I am an h2</h2>
 <p>hello there</p>
-<h3>I am an h3</h3>
+<h3 id="i-am-an-h3">I am an h3</h3>
 <p>hello there</p>
-<h4>I am an h4</h4>
+<h4 id="i-am-an-h4">I am an h4</h4>
 <p>hello there</p>
-<h5>I am an h5</h5>
+<h5 id="i-am-an-h5">I am an h5</h5>
 <p>hello</p>
 <p><em>Why should you get this package?</em></p><ul><li>We told you so.</li><li>Everyone is doing it.</li><li>It smells nice.</li></ul>
 <pre class="language-dart"><code>class Foo {

testing/test_package_docs_dev/index.html

@@ -56,8 +56,9 @@ <h5><span class="package-name">test_package</span> <span class="package-kind">pa
 
   <div class="col-xs-12 col-sm-9 col-md-8 main-content">
       <section class="desc markdown">
-        <h1>Best Package</h1>
+        <h1 id="best-package">Best Package</h1><ul><li><a href="#examples">Examples</a></li><li><a href="#another-section">Another Section</a></li></ul>
 <p>This is an amazing package.</p>
+<h2 id="examples">Examples</h2>
 <p>For example, it:</p><ul><li>Is very fast</li><li>Has zero bugs</li><li>Is free</li></ul>
 <p>It also has some awesome code</p>
 <pre class="language-dart"><code class="language-dart">void main() {
@@ -96,6 +97,7 @@ <h1>Best Package</h1>
   return a + b;  
 };
 </code></pre>
+<h2 id="another-section">Another Section</h2>
 <p>It sometimes generates warnings in commentRefs like this: <code>unknownThingy.FromSomewhere</code></p>
 <p>Be sure to check out other awesome packages on <a href="https://pub.dartlang.org">pub</a>.</p>
       </section>

tool/grind.dart

@@ -879,9 +879,11 @@ testDartdocFlutterPlugin() async {
 @Task('update test_package_docs')
 updateTestPackageDocs() async {
   var launcher = new SubprocessLauncher('update-test-package-docs');
-  var testPackageDocs =
-      new Directory(pathLib.join('testing',
-          Platform.version.split(' ').first.contains('-') ? 'test_package_docs_dev' :'test_package_docs'));
+  var testPackageDocs = new Directory(pathLib.join(
+      'testing',
+      Platform.version.split(' ').first.contains('-')
+          ? 'test_package_docs_dev'
+          : 'test_package_docs'));
   var testPackage = new Directory(pathLib.join('testing', 'test_package'));
   await launcher.runStreamed(sdkBin('pub'), ['get'],
       workingDirectory: testPackage.path);