Skip to content

Commit 3b80712

Browse files
committed
Elements. Migrate to Element2
1 parent 75d1fd7 commit 3b80712

29 files changed

+1682
-1744
lines changed

lib/resources/docs.dart.js

Lines changed: 1566 additions & 1558 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/resources/docs.dart.js.map

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/src/element_type.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ abstract class ElementType with CommentReferable, Nameable {
4040
fElement.kind == ElementKind.NEVER) {
4141
return UndefinedElementType._from(type, library, packageGraph);
4242
}
43-
var modelElement = packageGraph.getModelForElement2(fElement);
43+
var modelElement = packageGraph.getModelForElement(fElement);
4444
return DefinedElementType._from(type, modelElement, library, packageGraph);
4545
}
4646

@@ -137,7 +137,7 @@ class FunctionTypeElementType extends UndefinedElementType
137137
: super._();
138138

139139
List<TypeParameter> get typeFormals => type.typeParameters
140-
.map((p) => getModelFor2(p, library) as TypeParameter)
140+
.map((p) => getModelFor(p, library) as TypeParameter)
141141
.toList(growable: false);
142142

143143
@override
@@ -329,7 +329,7 @@ abstract class DefinedElementType extends ElementType {
329329
/// unless it is an alias reference.
330330
mixin Callable on ElementType {
331331
List<Parameter> get parameters => type.formalParameters
332-
.map((p) => getModelFor2(p, library) as Parameter)
332+
.map((p) => getModelFor(p, library) as Parameter)
333333
.toList(growable: false);
334334

335335
late final ElementType returnType = getTypeFor(type.returnType, library);

lib/src/generator/templates.runtime_renderers.dart

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@
88
// ignore_for_file: unused_import
99
// ignore_for_file: use_super_parameters
1010

11-
// ignore_for_file: analyzer_use_new_elements
12-
1311
import 'package:dartdoc/src/element_type.dart';
1412
import 'package:dartdoc/src/generator/template_data.dart';
1513
import 'package:dartdoc/src/model/annotation.dart';

lib/src/model/accessor.dart

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ class Accessor extends ModelElement {
4949

5050
/// The [enclosingCombo] where this element was defined.
5151
late final GetterSetterCombo definingCombo =
52-
getModelForElement2(element2.variable3!) as GetterSetterCombo;
52+
getModelForElement(element2.variable3!) as GetterSetterCombo;
5353

5454
String get _sourceCode {
5555
if (!isSynthetic) {
@@ -119,8 +119,8 @@ class Accessor extends ModelElement {
119119
@override
120120
ModelElement get enclosingElement => switch (element2.enclosingElement2) {
121121
LibraryFragment enclosingCompilationUnit =>
122-
getModelForElement2(enclosingCompilationUnit.element),
123-
_ => getModelFor2(element2.enclosingElement2!, library)
122+
getModelForElement(enclosingCompilationUnit.element),
123+
_ => getModelFor(element2.enclosingElement2!, library)
124124
};
125125

126126
@override
@@ -223,7 +223,7 @@ class ContainerAccessor extends Accessor with ContainerMember, Inheritable {
223223
continue;
224224
}
225225
final parentContainer =
226-
getModelForElement2(supertype.element3) as InheritingContainer;
226+
getModelForElement(supertype.element3) as InheritingContainer;
227227
final possibleFields =
228228
parentContainer.declaredFields.where((f) => !f.isStatic);
229229
final fieldName = accessor.lookupName?.replaceFirst('=', '');

lib/src/model/annotation.dart

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,9 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5-
// ignore_for_file: analyzer_use_new_elements
6-
75
import 'dart:convert';
86

9-
import 'package:analyzer/dart/element/element.dart';
7+
import 'package:analyzer/dart/element/element2.dart';
108
import 'package:dartdoc/src/element_type.dart';
119
import 'package:dartdoc/src/model/attribute.dart';
1210
import 'package:dartdoc/src/model/class.dart';
@@ -24,7 +22,7 @@ final class Annotation extends Attribute {
2422
final PackageGraph _packageGraph;
2523

2624
Annotation(this._annotation, this._library, this._packageGraph)
27-
: super(_annotation.element!.name!);
25+
: super(_annotation.element2!.name3!);
2826

2927
@override
3028
String get linkedNameWithParameters {
@@ -42,19 +40,19 @@ final class Annotation extends Attribute {
4240
}
4341

4442
@override
45-
String get linkedName => _annotation.element is PropertyAccessorElement
46-
? _packageGraph.getModelForElement(_annotation.element!).linkedName
43+
String get linkedName => _annotation.element2 is PropertyAccessorElement2
44+
? _packageGraph.getModelForElement(_annotation.element2!).linkedName
4745
// TODO(jcollins-g): consider linking to constructor instead of type?
4846
: _modelType.linkedName;
4947

50-
late final ElementType _modelType = switch (_annotation.element) {
51-
ConstructorElement(:var returnType) =>
48+
late final ElementType _modelType = switch (_annotation.element2) {
49+
ConstructorElement2(:var returnType) =>
5250
_packageGraph.getTypeFor(returnType, _library),
53-
PropertyAccessorElement(:var variable2?) =>
54-
(_packageGraph.getModelForElement(variable2) as GetterSetterCombo)
51+
PropertyAccessorElement2(:var variable3?) =>
52+
(_packageGraph.getModelForElement(variable3) as GetterSetterCombo)
5553
.modelType,
5654
_ => throw StateError(
57-
'non-callable element used as annotation?: ${_annotation.element}')
55+
'non-callable element used as annotation?: ${_annotation.element2}')
5856
};
5957

6058
bool get isPublic {

lib/src/model/comment_referable.dart

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -132,14 +132,14 @@ mixin CommentReferable implements Nameable {
132132
// First, cache the synthetic variable, so that the
133133
// PropertyAccessorElement getter and/or setter are set (see
134134
// `Field.new` regarding `enclosingCombo`).
135-
packageGraph.getModelForElement2(variable);
135+
packageGraph.getModelForElement(variable);
136136
// Then, use the result for the PropertyAccessorElement.
137-
result = packageGraph.getModelForElement2(resultElement);
137+
result = packageGraph.getModelForElement(resultElement);
138138
} else {
139-
result = packageGraph.getModelForElement2(variable);
139+
result = packageGraph.getModelForElement(variable);
140140
}
141141
} else {
142-
result = packageGraph.getModelForElement2(resultElement);
142+
result = packageGraph.getModelForElement(resultElement);
143143
}
144144
return _recurseChildrenAndFilter(referenceLookup, result, filter: filter);
145145
}

lib/src/model/constructor.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ class Constructor extends ModelElement with ContainerMember, TypeParameters {
6464

6565
@override
6666
Container get enclosingElement =>
67-
getModelFor2(element2.enclosingElement2, library) as Container;
67+
getModelFor(element2.enclosingElement2, library) as Container;
6868

6969
@override
7070
String get fileName =>
@@ -136,7 +136,7 @@ class Constructor extends ModelElement with ContainerMember, TypeParameters {
136136

137137
var parameterElements = parameters.map((parameter) {
138138
var e = dereferenceParameter(parameter.element2);
139-
return e == null ? parameter : getModelForElement2(e);
139+
return e == null ? parameter : getModelForElement(e);
140140
});
141141
return {
142142
for (var e in parameterElements) e.referenceName: e,

lib/src/model/container_member.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ mixin ContainerMember on ModelElement {
2929
@protected
3030
@visibleForTesting
3131
late final Container definingEnclosingContainer =
32-
getModelForElement2(element2.enclosingElement2!) as Container;
32+
getModelForElement(element2.enclosingElement2!) as Container;
3333

3434
@override
3535
Set<Attribute> get attributes => {

lib/src/model/documentation_comment.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ mixin DocumentationComment
5555
if (!hasDocumentationComment && self.overriddenElement != null) {
5656
return self.overriddenElement!.documentationFrom;
5757
} else if (self.isInherited) {
58-
return packageGraph.getModelForElement2(element2).documentationFrom;
58+
return packageGraph.getModelForElement(element2).documentationFrom;
5959
} else {
6060
return [this];
6161
}

0 commit comments

Comments
 (0)