Canonicalization scorer (#1455)

* First stab at disambiguation, but needs to be extracted

* scorer in pretty good shape now

* beginnings of being able to set canonicalization manually

* intermediate state: moving to library-based canonicalFor declaration

* intermediate state -- autoinclude deps broken

* intermediate: tests written and working

* test really works now.

* regen test docs

* Add new test doc directories

* dartfmt

* Comment typo.

* Fix --auto-include-deps

* cleanup

* rebuild docs

* Helper moved with the fix.

* Hide the debug option for the scorer confidence

* Remove unnecessary casts

* Implement review comments and extract namePieces into Nameable

* Regenerate docs

Author: jcollins-g

bin/dartdoc.dart

@@ -152,9 +152,6 @@ main(List<String> arguments) async {
     generator.onFileCreated.listen(_onProgress);
   }
 
-  var addCrossdart = args['add-crossdart'] as bool;
-  var includeSource = args['include-source'] as bool;
-
   DartSdk sdk = new FolderBasedDartSdk(PhysicalResourceProvider.INSTANCE,
       PhysicalResourceProvider.INSTANCE.getFolder(sdkDir.path));
 
@@ -181,14 +178,17 @@ main(List<String> arguments) async {
   }
 
   setConfig(
-      addCrossdart: addCrossdart,
+      addCrossdart: args['add-crossdart'],
       examplePathPrefix: args['example-path-prefix'],
       showWarnings: args['show-warnings'],
-      includeSource: includeSource,
+      includeSource: args['include-source'],
       inputDir: inputDir,
       sdkVersion: sdk.sdkVersion,
       autoIncludeDependencies: args['auto-include-dependencies'],
       categoryOrder: args['category-order'],
+      reexportMinConfidence:
+          double.parse(args['ambiguous-reexport-scorer-min-confidence']),
+      verboseWarnings: args['verbose-warnings'],
       dropTextFrom: dropTextFrom);
 
   DartDoc dartdoc = new DartDoc(inputDir, excludeLibraries, sdkDir, generators,
@@ -289,6 +289,15 @@ ArgParser _createArgsParser() {
           "Generates `index.json` with indentation and newlines. The file is larger, but it's also easier to diff.",
       negatable: false,
       defaultsTo: false);
+  parser.addOption('ambiguous-reexport-scorer-min-confidence',
+      help:
+          'Minimum scorer confidence to suppress warning on ambiguous reexport.',
+      defaultsTo: "0.1",
+      hide: true);
+  parser.addFlag('verbose-warnings',
+      help: 'Display extra debugging information and help with warnings.',
+      negatable: true,
+      defaultsTo: true);
   parser.addFlag(
     'hide-sdk-text',
     help:

lib/src/config.dart

@@ -16,6 +16,8 @@ class Config {
   final String sdkVersion;
   final bool autoIncludeDependencies;
   final List<String> categoryOrder;
+  final double reexportMinConfidence;
+  final bool verboseWarnings;
   final List<String> dropTextFrom;
   Config._(
       this.inputDir,
@@ -26,6 +28,8 @@ class Config {
       this.sdkVersion,
       this.autoIncludeDependencies,
       this.categoryOrder,
+      this.reexportMinConfidence,
+      this.verboseWarnings,
       this.dropTextFrom);
 }
 
@@ -41,6 +45,8 @@ void setConfig(
     String sdkVersion,
     bool autoIncludeDependencies: false,
     List<String> categoryOrder,
+    double reexportMinConfidence: 0.1,
+    verboseWarnings: true,
     List<String> dropTextFrom}) {
   categoryOrder ??= new UnmodifiableListView<String>([]);
   dropTextFrom ??= new UnmodifiableListView<String>([]);
@@ -53,5 +59,7 @@ void setConfig(
       sdkVersion,
       autoIncludeDependencies,
       categoryOrder,
+      reexportMinConfidence,
+      verboseWarnings,
       dropTextFrom);
 }