Canonicalize elements in remote packages

Author: sigurdm

lib/src/model/model_element.dart

@@ -512,11 +512,10 @@ abstract class ModelElement
     // This is not accurate if we are still constructing the Package.
     assert(packageGraph.allLibrariesAdded);
 
-    var definingLibraryIsLocalPublic =
-        packageGraph.localPublicLibraries.contains(library);
-    var possibleCanonicalLibrary = definingLibraryIsLocalPublic
-        ? library
-        : canonicalLibraryCandidate(this);
+    var definingLibraryIsPublic =
+        packageGraph.publicLibraries.contains(library);
+    var possibleCanonicalLibrary =
+        definingLibraryIsPublic ? library : canonicalLibraryCandidate(this);
 
     if (possibleCanonicalLibrary != null) return possibleCanonicalLibrary;
 

test/packages_test.dart

@@ -263,6 +263,7 @@ library bar;
             .writeAsStringSync('''
 /// Documentation comment.
 library one;
+export 'some_other_lib.dart' show Exported;
 
 class One {}
 ''');
@@ -276,6 +277,10 @@ library script;
 
 class Script {}
 ''');
+        packageOneRoot
+            .getChildAssumingFolder('lib')
+            .getChildAssumingFile('some_other_lib.dart')
+            .writeAsStringSync('''class Exported {}''');
 
         packageTwoRoot =
             utils.writePackage('two', resourceProvider, packageConfigProvider);
@@ -316,6 +321,12 @@ dartdoc:
         expect(packageOne.documentedWhere, equals(DocumentLocation.remote));
         expect(classOne.href,
             equals('https://mypub.topdomain/one/0.0.1/one/One-class.html'));
+        // Validate that canonicalization takes place for remote packages.
+        var exported = libraryOne.classes.named('Exported');
+        expect(
+            exported.href,
+            equals(
+                'https://mypub.topdomain/one/0.0.1/some_other_lib/Exported-class.html'));
       });
 
       test(