Skip to content

Commit 931f2cb

Browse files
committed
400
1 parent c6f3dd4 commit 931f2cb

15 files changed

+91
-93
lines changed

lib/src/model/annotation.dart

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
import 'dart:convert';
66

7-
import 'package:analyzer/dart/element/element2.dart';
7+
import 'package:analyzer/dart/element/element.dart';
88
import 'package:dartdoc/src/element_type.dart';
99
import 'package:dartdoc/src/model/attribute.dart';
1010
import 'package:dartdoc/src/model/class.dart';
@@ -22,7 +22,7 @@ final class Annotation extends Attribute {
2222
final PackageGraph _packageGraph;
2323

2424
Annotation(this._annotation, this._library, this._packageGraph)
25-
: super(_annotation.element2!.name3!);
25+
: super(_annotation.element!.name!);
2626

2727
@override
2828
String get linkedNameWithParameters {
@@ -40,19 +40,19 @@ final class Annotation extends Attribute {
4040
}
4141

4242
@override
43-
String get linkedName => _annotation.element2 is PropertyAccessorElement2
44-
? _packageGraph.getModelForElement(_annotation.element2!).linkedName
43+
String get linkedName => _annotation.element is PropertyAccessorElement
44+
? _packageGraph.getModelForElement(_annotation.element!).linkedName
4545
// TODO(jcollins-g): consider linking to constructor instead of type?
4646
: _modelType.linkedName;
4747

48-
late final ElementType _modelType = switch (_annotation.element2) {
48+
late final ElementType _modelType = switch (_annotation.element) {
4949
ConstructorElement(:var returnType) =>
5050
_packageGraph.getTypeFor(returnType, _library),
5151
PropertyAccessorElement(:var variable) =>
5252
(_packageGraph.getModelForElement(variable) as GetterSetterCombo)
5353
.modelType,
5454
_ => throw StateError(
55-
'non-callable element used as annotation?: ${_annotation.element2}')
55+
'non-callable element used as annotation?: ${_annotation.element}')
5656
};
5757

5858
bool get isPublic {

lib/src/model/canonicalization.dart

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5-
import 'package:analyzer/dart/element/element2.dart';
5+
import 'package:analyzer/dart/element/element.dart';
66
import 'package:dartdoc/src/model/model.dart';
77
import 'package:dartdoc/src/warnings.dart';
88

@@ -19,11 +19,11 @@ Library? canonicalLibraryCandidate(ModelElement modelElement) {
1919

2020
// Since we're looking for a library, go up in the tree until we find it.
2121
var topLevelElement = modelElement.element;
22-
while (topLevelElement.enclosingElement2 is! LibraryElement2 &&
23-
topLevelElement.enclosingElement2 != null) {
24-
topLevelElement = topLevelElement.enclosingElement2!;
22+
while (topLevelElement.enclosingElement is! LibraryElement &&
23+
topLevelElement.enclosingElement != null) {
24+
topLevelElement = topLevelElement.enclosingElement!;
2525
}
26-
var topLevelElementName = topLevelElement.name3;
26+
var topLevelElementName = topLevelElement.name;
2727
if (topLevelElementName == null) {
2828
// Any member of an unnamed extension is not public, and has no
2929
// canonical library.
@@ -84,16 +84,16 @@ final class _Canonicalization {
8484
}
8585
}
8686

87-
String _getElementLocation(Element2 element) {
87+
String _getElementLocation(Element element) {
8888
var components = <String>[];
89-
Element2? ancestor = element;
89+
Element? ancestor = element;
9090
while (ancestor != null) {
91-
if (ancestor is LibraryElement2) {
91+
if (ancestor is LibraryElement) {
9292
components.insert(0, ancestor.uri.toString());
9393
} else {
94-
components.insert(0, ancestor.name3!);
94+
components.insert(0, ancestor.name!);
9595
}
96-
ancestor = ancestor.enclosingElement2;
96+
ancestor = ancestor.enclosingElement;
9797
}
9898
var buffer = StringBuffer();
9999
var length = components.length;

lib/src/model/category.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5-
import 'package:analyzer/dart/element/element2.dart';
5+
import 'package:analyzer/dart/element/element.dart';
66
import 'package:analyzer/file_system/file_system.dart';
77
import 'package:dartdoc/src/dartdoc_options.dart';
88
import 'package:dartdoc/src/model/comment_referable.dart';
@@ -78,7 +78,7 @@ class Category
7878
}
7979

8080
@override
81-
Element2? get element => null;
81+
Element? get element => null;
8282

8383
@override
8484
String get name => _categoryDefinition.displayName;

lib/src/model/class.dart

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5-
import 'package:analyzer/dart/element/element2.dart';
5+
import 'package:analyzer/dart/element/element.dart';
66
import 'package:dartdoc/src/model/kind.dart';
77
import 'package:dartdoc/src/model/model.dart';
88

@@ -15,7 +15,7 @@ import 'package:dartdoc/src/model/model.dart';
1515
/// **inherited**: Filtered getters giving only inherited children.
1616
class Class extends InheritingContainer with Constructable, MixedInTypes {
1717
@override
18-
final ClassElement2 element;
18+
final ClassElement element;
1919

2020
@override
2121
late final List<ModelElement> allModelElements = [
@@ -29,8 +29,8 @@ class Class extends InheritingContainer with Constructable, MixedInTypes {
2929

3030
Class(this.element, Library library, PackageGraph packageGraph)
3131
: super(library, packageGraph) {
32-
if (element.name3 == 'Object' &&
33-
library.element.name3 == 'dart.core' &&
32+
if (element.name == 'Object' &&
33+
library.element.name == 'dart.core' &&
3434
package.name == 'Dart') {
3535
packageGraph.objectClass = this;
3636
}
@@ -46,11 +46,11 @@ class Class extends InheritingContainer with Constructable, MixedInTypes {
4646
bool get isBase => element.isBase && !element.isSealed;
4747

4848
bool get isErrorOrException {
49-
bool isError(InterfaceElement2 e) =>
50-
e.library2.isDartCore && (e.name3 == 'Exception' || e.name3 == 'Error');
49+
bool isError(InterfaceElement e) =>
50+
e.library.isDartCore && (e.name == 'Exception' || e.name == 'Error');
5151

5252
if (isError(element)) return true;
53-
return element.allSupertypes.map((t) => t.element3).any(isError);
53+
return element.allSupertypes.map((t) => t.element).any(isError);
5454
}
5555

5656
@override

lib/src/model/comment_referable.dart

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ library;
88
import 'dart:core';
99

1010
import 'package:analyzer/dart/analysis/features.dart';
11-
import 'package:analyzer/dart/element/element2.dart';
11+
import 'package:analyzer/dart/element/element.dart';
1212
import 'package:analyzer/dart/element/scope.dart';
1313
import 'package:collection/collection.dart';
1414
import 'package:dartdoc/src/model/library.dart';
@@ -105,7 +105,7 @@ mixin CommentReferable implements Nameable {
105105
_ReferenceChildrenLookup referenceLookup, {
106106
required bool Function(CommentReferable?) filter,
107107
}) {
108-
Element2? resultElement;
108+
Element? resultElement;
109109
final scope = this.scope;
110110
if (scope != null) {
111111
resultElement = scope.lookupPreferGetter(referenceLookup.lookup);
@@ -207,16 +207,16 @@ mixin CommentReferable implements Nameable {
207207
Library? get library => null;
208208

209209
/// For testing / comparison only, get the comment referable from where this
210-
/// `ElementType` was defined. Override where an [Element2] is available.
210+
/// `ElementType` was defined. Override where an [Elemen2] is available.
211211
@internal
212212
CommentReferable get definingCommentReferable => this;
213213
}
214214

215215
extension on Scope {
216216
/// Prefer the getter for a bundled lookup if both exist.
217-
Element2? lookupPreferGetter(String id) {
217+
Element? lookupPreferGetter(String id) {
218218
var result = lookup(id);
219-
return result.getter2 ?? result.setter2;
219+
return result.getter ?? result.setter;
220220
}
221221
}
222222

lib/src/model/constructor.dart

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5-
import 'package:analyzer/dart/element/element2.dart';
5+
import 'package:analyzer/dart/element/element.dart';
66
import 'package:analyzer/source/line_info.dart';
77
import 'package:dartdoc/src/element_type.dart';
88
import 'package:dartdoc/src/model/comment_referable.dart';
@@ -12,7 +12,7 @@ import 'package:dartdoc/src/model_utils.dart';
1212

1313
class Constructor extends ModelElement with ContainerMember, TypeParameters {
1414
@override
15-
final ConstructorElement2 element;
15+
final ConstructorElement element;
1616

1717
Constructor(this.element, super.library, super.packageGraph);
1818

@@ -25,7 +25,7 @@ class Constructor extends ModelElement with ContainerMember, TypeParameters {
2525
return enclosingElement.characterLocation;
2626
}
2727
final lineInfo = unitElement.lineInfo;
28-
var offset = element.firstFragment.nameOffset2 ??
28+
var offset = element.firstFragment.nameOffset ??
2929
element.firstFragment.typeNameOffset;
3030
if (offset != null && offset >= 0) {
3131
return lineInfo.getLocation(offset);
@@ -37,10 +37,10 @@ class Constructor extends ModelElement with ContainerMember, TypeParameters {
3737
bool get isPublic {
3838
if (!super.isPublic) return false;
3939
if (element.hasPrivateName) return false;
40-
var class_ = element.enclosingElement2;
40+
var class_ = element.enclosingElement;
4141
// Enums cannot be explicitly constructed or extended.
42-
if (class_ is EnumElement2) return false;
43-
if (class_ is ClassElement2) {
42+
if (class_ is EnumElement) return false;
43+
if (class_ is ClassElement) {
4444
if (element.isFactory) return true;
4545
if (class_.isSealed ||
4646
(class_.isAbstract && class_.isFinal) ||
@@ -60,7 +60,7 @@ class Constructor extends ModelElement with ContainerMember, TypeParameters {
6060

6161
@override
6262
Container get enclosingElement =>
63-
getModelFor(element.enclosingElement2, library) as Container;
63+
getModelFor(element.enclosingElement, library) as Container;
6464

6565
@override
6666
String get fileName =>
@@ -85,7 +85,7 @@ class Constructor extends ModelElement with ContainerMember, TypeParameters {
8585
@override
8686
bool get isConst => element.isConst;
8787

88-
bool get isUnnamedConstructor => element.name3 == 'new';
88+
bool get isUnnamedConstructor => element.name == 'new';
8989

9090
bool get isFactory => element.isFactory;
9191

@@ -100,11 +100,11 @@ class Constructor extends ModelElement with ContainerMember, TypeParameters {
100100
// TODO(jcollins-g): After the old lookup code is retired, rationalize
101101
// [name] around the conventions used in referenceChildren and replace
102102
// code there and elsewhere with simple references to the name.
103-
'${enclosingElement.name}.${element.name3}';
103+
'${enclosingElement.name}.${element.name}';
104104

105105
@override
106106
String get nameWithGenerics {
107-
var constructorName = element.name3!;
107+
var constructorName = element.name!;
108108
if (constructorName == 'new') {
109109
return '${enclosingElement.name}$genericParameters';
110110
}
@@ -113,7 +113,7 @@ class Constructor extends ModelElement with ContainerMember, TypeParameters {
113113

114114
String? get shortName {
115115
if (name.contains('.')) {
116-
return name.substring(element.enclosingElement2.name3!.length + 1);
116+
return name.substring(element.enclosingElement.name!.length + 1);
117117
} else {
118118
return name;
119119
}
@@ -122,11 +122,11 @@ class Constructor extends ModelElement with ContainerMember, TypeParameters {
122122
@override
123123
late final Map<String, CommentReferable> referenceChildren = () {
124124
// Find the element that [parameter] is _really_ referring to.
125-
Element2? dereferenceParameter(FormalParameterElement? parameter) =>
125+
Element? dereferenceParameter(FormalParameterElement? parameter) =>
126126
switch (parameter) {
127-
FieldFormalParameterElement2() => parameter.field2,
128-
SuperFormalParameterElement2() =>
129-
dereferenceParameter(parameter.superConstructorParameter2),
127+
FieldFormalParameterElement() => parameter.field,
128+
SuperFormalParameterElement() =>
129+
dereferenceParameter(parameter.superConstructorParameter),
130130
_ => parameter
131131
};
132132

@@ -142,5 +142,5 @@ class Constructor extends ModelElement with ContainerMember, TypeParameters {
142142

143143
@override
144144
String get referenceName =>
145-
isUnnamedConstructor ? enclosingElement.name : element.name3!;
145+
isUnnamedConstructor ? enclosingElement.name : element.name!;
146146
}

lib/src/model/container.dart

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5-
import 'package:analyzer/dart/element/element2.dart';
5+
import 'package:analyzer/dart/element/element.dart';
66
import 'package:analyzer/dart/element/scope.dart';
77
import 'package:dartdoc/src/model/comment_referable.dart';
88
import 'package:dartdoc/src/model/model.dart';
@@ -32,7 +32,7 @@ abstract class Container extends ModelElement
3232
Container(super.library, super.packageGraph);
3333

3434
@override
35-
Element2 get element;
35+
Element get element;
3636

3737
// TODO(jcollins-g): Implement a ContainerScope that flattens supertypes?
3838
@override
@@ -41,20 +41,20 @@ abstract class Container extends ModelElement
4141
@override
4242
bool get hasParameters => false;
4343

44-
bool get isExtension => element is ExtensionElement2;
44+
bool get isExtension => element is ExtensionElement;
4545

4646
/// Whether this is an enum.
47-
bool get isEnum => element is EnumElement2;
47+
bool get isEnum => element is EnumElement;
4848

4949
/// Whether this is an interface (e.g. class, enum, mixin, or extension type).
50-
bool get isInterface => element is InterfaceElement2;
50+
bool get isInterface => element is InterfaceElement;
5151

5252
/// Whether this is a mixin.
53-
bool get isMixin => element is MixinElement2;
53+
bool get isMixin => element is MixinElement;
5454

5555
/// Whether this container represents the Object class from 'dart:core'.
5656
bool get isDartCoreObject =>
57-
element.name3 == 'Object' && element.library2?.name3 == 'dart.core';
57+
element.name == 'Object' && element.library?.name == 'dart.core';
5858

5959
/// The model elements of all of the members of this container, including
6060
/// declared and inherited ones.
@@ -158,9 +158,9 @@ abstract class Container extends ModelElement
158158

159159
/// This container might be canonical for elements it does not contain.
160160
/// See [Inheritable.canonicalEnclosingContainer].
161-
bool containsElement(Element2? element) => _allElements.contains(element);
161+
bool containsElement(Element? element) => _allElements.contains(element);
162162

163-
late final Set<Element2> _allElements =
163+
late final Set<Element> _allElements =
164164
allModelElements.map((e) => e.element).toSet();
165165

166166
bool get hasPublicStaticFields => staticFields.any((e) => e.isPublic);

lib/src/model/container_member.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ mixin ContainerMember on ModelElement {
2929
@protected
3030
@visibleForTesting
3131
late final Container definingEnclosingContainer =
32-
getModelForElement(element.enclosingElement2!) as Container;
32+
getModelForElement(element.enclosingElement!) as Container;
3333

3434
@override
3535
Set<Attribute> get attributes => {

lib/src/model/documentation_comment.dart

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
/// @docImport 'package:dartdoc/src/model/package_graph.dart';
66
library;
77

8-
import 'package:analyzer/dart/element/element2.dart';
8+
import 'package:analyzer/dart/element/element.dart';
99
import 'package:args/args.dart';
1010
import 'package:crypto/crypto.dart' as crypto;
1111
import 'package:dartdoc/src/model/documentable.dart';
@@ -41,7 +41,7 @@ final _htmlInjectRegExp = RegExp(r'<dartdoc-html>([a-f0-9]+)</dartdoc-html>');
4141
mixin DocumentationComment
4242
implements Documentable, Warnable, Locatable, SourceCode {
4343
@override
44-
Element2 get element;
44+
Element get element;
4545

4646
List<DocumentationComment>? _documentationFrom;
4747

@@ -74,9 +74,7 @@ mixin DocumentationComment
7474

7575
/// Whether `this` has a synthetic/inherited or local documentation comment,
7676
/// and false otherwise.
77-
bool get hasDocumentationComment =>
78-
element is Annotatable &&
79-
(element as Annotatable).documentationComment != null;
77+
bool get hasDocumentationComment => element.documentationComment != null;
8078

8179
/// Whether the raw documentation comment is considered to be 'nodoc', an
8280
/// attribute indicating that any documentation should not be included in

0 commit comments

Comments
 (0)