Remove string substitution-based const value links (#1548)

* Flatten changes one last time

* Get rid of the problematic const linking.

* Fix tests post analyzer update

* Review comments

* Disable travis temporarily

Author: jcollins-g

lib/src/model.dart

@@ -1561,15 +1561,9 @@ abstract class GetterSetterCombo implements ModelElement {
     return _constantValueBase;
   }
 
-  String linkifyWithModelType(String text) {
-    RegExp r = new RegExp("\\b${modelType.name}\\b");
-    return text?.replaceAll(r, modelType.linkedName);
-  }
-
-  String get constantValue => linkifyWithModelType(constantValueBase);
+  String get constantValue => constantValueBase;
 
-  String get constantValueTruncated =>
-      linkifyWithModelType(truncateString(constantValueBase, 200));
+  String get constantValueTruncated => truncateString(constantValueBase, 200);
 
   /// Returns true if both accessors are synthetic.
   bool get hasSyntheticAccessors {

test/model_test.dart

@@ -1902,9 +1902,9 @@ String topLevelFunction(int param1, bool param2, Cool coolBeans,
           "const <String> [COLOR_GREEN, COLOR_ORANGE, 'blue']");
     });
 
-    test('MY_CAT is linked', () {
+    test('MY_CAT is not linked', () {
       expect(cat.constantValue,
-          'const <a href="ex/ConstantCat-class.html">ConstantCat</a>(&#39;tabby&#39;)');
+          'const ConstantCat(&#39;tabby&#39;)');
     });
 
     test('exported property', () {

testing/test_package_docs/ex/MY_CAT-constant.html

@@ -110,7 +110,7 @@ <h5>library ex</h5>
 
     <section class="multi-line-signature">
       <span class="name ">MY_CAT</span>      =
-      <span class="constant-value">const <a href="ex/ConstantCat-class.html">ConstantCat</a>(&#39;tabby&#39;)</span>
+      <span class="constant-value">const ConstantCat(&#39;tabby&#39;)</span>
 
     </section>
 

testing/test_package_docs/ex/deprecated-constant.html

@@ -110,7 +110,7 @@ <h5>library ex</h5>
 
     <section class="multi-line-signature">
       <span class="name ">deprecated</span>      =
-      <span class="constant-value">const <a href="ex/Deprecated-class.html">Deprecated</a>(&quot;next release&quot;)</span>
+      <span class="constant-value">const Deprecated(&quot;next release&quot;)</span>
 
     </section>
 

testing/test_package_docs/ex/ex-library.html

@@ -293,7 +293,7 @@ <h2>Constants</h2>
 
 
   <div>
-            <span class="signature"><code>const <a href="ex/Deprecated-class.html">Deprecated</a>(&quot;next release&quot;)</code></span>
+            <span class="signature"><code>const Deprecated(&quot;next release&quot;)</code></span>
           </div>
         </dd>
         <dt id="incorrectDocReference" class="constant">
@@ -326,7 +326,7 @@ <h2>Constants</h2>
 
 
   <div>
-            <span class="signature"><code>const <a href="ex/ConstantCat-class.html">ConstantCat</a>(&#39;tabby&#39;)</code></span>
+            <span class="signature"><code>const ConstantCat(&#39;tabby&#39;)</code></span>
           </div>
         </dd>
         <dt id="PRETTY_COLORS" class="constant">

testing/test_package_docs/fake/CUSTOM_CLASS-constant.html

@@ -126,7 +126,7 @@ <h5>library fake</h5>
 
     <section class="multi-line-signature">
       <span class="name ">CUSTOM_CLASS</span>      =
-      <span class="constant-value">const <a href="fake/ConstantClass-class.html">ConstantClass</a>(&#39;custom&#39;)</span>
+      <span class="constant-value">const ConstantClass(&#39;custom&#39;)</span>
 
     </section>
 

testing/test_package_docs/fake/fake-library.html

@@ -243,7 +243,7 @@ <h2>Constants</h2>
 
 
   <div>
-            <span class="signature"><code>const <a href="fake/ConstantClass-class.html">ConstantClass</a>(&#39;custom&#39;)</code></span>
+            <span class="signature"><code>const ConstantClass(&#39;custom&#39;)</code></span>
           </div>
         </dd>
         <dt id="DOWN" class="constant">